Am 11.03.2015 um 15:45 schrieb Mark Thomas:
On 11/03/2015 14:44, ma...@apache.org wrote:
Author: markt
Date: Wed Mar 11 14:44:23 2015
New Revision: 1665888
URL: http://svn.apache.org/r1665888
Log:
Fix 57653. Crash when multiple events for same socket are returned via separate
apr_pollfd_t
Mark,
On 3/10/15 4:44 PM, ma...@apache.org wrote:
Author: markt
Date: Tue Mar 10 20:44:56 2015
New Revision: 1665682
URL: http://svn.apache.org/r1665682
Log:
Follow-up to r1665297
Correct output loop. Forgot to increment offset for subsequent writes.
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57653
--- Comment #6 from Rainer Jung rainer.j...@kippdata.de ---
I had a look at the origins of that APR comment:
http://svn.apache.org/viewvc?view=revisionrevision=748951
It was especialy added to allow for an APR internal optimization when used
Mark,
On 3/11/15 2:57 PM, Mark Thomas wrote:
On 11/03/2015 18:09, Christopher Schultz wrote:
Mark,
On 3/11/15 1:02 PM, Christopher Schultz wrote:
Mark,
On 3/10/15 4:44 PM, ma...@apache.org wrote:
Author: markt
Date: Tue Mar 10 20:44:56 2015
New Revision: 1665682
URL:
Mark,
On 3/11/15 4:01 PM, ma...@apache.org wrote:
Author: markt
Date: Wed Mar 11 20:01:28 2015
New Revision: 1665989
URL: http://svn.apache.org/r1665989
Log:
Add a comment
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified:
Author: markt
Date: Wed Mar 11 20:36:26 2015
New Revision: 1665998
URL: http://svn.apache.org/r1665998
Log:
Review of r1665989 by schultz.
Clean-up.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified:
Author: markt
Date: Wed Mar 11 20:39:43 2015
New Revision: 1666004
URL: http://svn.apache.org/r1666004
Log:
Increase the size of the descriptor array to handle the worst case (believed
only to occur on BSD and OSX but there is a chance it may occur on other
platforms).
Modified:
Author: markt
Date: Wed Mar 11 20:52:39 2015
New Revision: 1666008
URL: http://svn.apache.org/r1666008
Log:
Clean-up
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
On 11/03/2015 20:27, Christopher Schultz wrote:
Mark,
On 3/11/15 4:01 PM, ma...@apache.org wrote:
Author: markt
Date: Wed Mar 11 20:01:28 2015
New Revision: 1665989
URL: http://svn.apache.org/r1665989
Log:
Add a comment
Modified:
Author: markt
Date: Wed Mar 11 21:06:53 2015
New Revision: 1666013
URL: http://svn.apache.org/r1666013
Log:
Add a placeholder for the descriptor merging that is going to be necessary for
OSX and BSD.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified:
Author: markt
Date: Wed Mar 11 21:35:39 2015
New Revision: 1666017
URL: http://svn.apache.org/r1666017
Log:
Implement the merging.
I opted for certain clarity over the possible speed improvement of a more
'hands-on' implementation.
Modified:
Mark,
On 3/11/15 1:02 PM, Christopher Schultz wrote:
Mark,
On 3/10/15 4:44 PM, ma...@apache.org wrote:
Author: markt
Date: Tue Mar 10 20:44:56 2015
New Revision: 1665682
URL: http://svn.apache.org/r1665682
Log:
Follow-up to r1665297
Correct output loop. Forgot to increment offset for
Author: markt
Date: Wed Mar 11 19:30:39 2015
New Revision: 1665977
URL: http://svn.apache.org/r1665977
Log:
Return value is never checked.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
Author: markt
Date: Wed Mar 11 19:30:34 2015
New Revision: 1665976
URL: http://svn.apache.org/r1665976
Log:
Fix indent
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57653
--- Comment #7 from Christopher Schultz ch...@christopherschultz.net ---
Not knowing a great deal about the underlying issue...
If the fd is registered for both READ and WRITE, and we get multiple
responses from apr_pollset_poll, are those
Rainer,
On 3/11/15 12:38 PM, Rainer Jung wrote:
Am 11.03.2015 um 15:45 schrieb Mark Thomas:
On 11/03/2015 14:44, ma...@apache.org wrote:
Author: markt
Date: Wed Mar 11 14:44:23 2015
New Revision: 1665888
URL: http://svn.apache.org/r1665888
Log:
Fix 57653. Crash when multiple events for
https://bz.apache.org/bugzilla/show_bug.cgi?id=57653
--- Comment #8 from Mark Thomas ma...@apache.org ---
(In reply to Christopher Schultz from comment #7)
Not knowing a great deal about the underlying issue...
It is worth reading AprEndpoint.Poller.run() and the native implementation of
poll()
On 11/03/2015 18:09, Christopher Schultz wrote:
Mark,
On 3/11/15 1:02 PM, Christopher Schultz wrote:
Mark,
On 3/10/15 4:44 PM, ma...@apache.org wrote:
Author: markt
Date: Tue Mar 10 20:44:56 2015
New Revision: 1665682
URL: http://svn.apache.org/r1665682
Log:
Follow-up to r1665297
https://bz.apache.org/bugzilla/show_bug.cgi?id=57674
--- Comment #17 from Christopher Schultz ch...@christopherschultz.net ---
Looks good in my test case. I'm re-enabling the configuration (by removing the
socket.appWriteBufSize setting) in my development environment to see it under
real use.
--
Author: markt
Date: Wed Mar 11 19:36:03 2015
New Revision: 1665981
URL: http://svn.apache.org/r1665981
Log:
Avoid unexpected closure of the socket if the socket is first registered
for one event and then later registered for another.
Modified:
Author: markt
Date: Wed Mar 11 19:35:58 2015
New Revision: 1665980
URL: http://svn.apache.org/r1665980
Log:
If the socket is being destroyed, need to remove it from the addList as
well.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified:
Author: markt
Date: Wed Mar 11 19:57:07 2015
New Revision: 1665986
URL: http://svn.apache.org/r1665986
Log:
Ensure all additions to the Poller go through the SocketWrapper so it
can check if the socket has been closed first.
Modified:
Author: markt
Date: Wed Mar 11 19:57:01 2015
New Revision: 1665985
URL: http://svn.apache.org/r1665985
Log:
Tighten up the close code to reduce the chances of a socket being closed
more than once.
This also provides some plumbing required by the next commit to ensure
that sockets are not
Author: markt
Date: Wed Mar 11 20:01:23 2015
New Revision: 1665988
URL: http://svn.apache.org/r1665988
Log:
Restore volatile for closed. Not all reads are inside a sync.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified:
Author: markt
Date: Wed Mar 11 20:01:28 2015
New Revision: 1665989
URL: http://svn.apache.org/r1665989
Log:
Add a comment
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-APR
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dexamples.sources.skip=true
Author: markt
Date: Wed Mar 11 22:18:50 2015
New Revision: 1666028
URL: http://svn.apache.org/r1666028
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57683
An aborted request (the only way for the client to disconnect) should not stop
the example from working for future requests.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57683
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Resolution|--- |FIXED
Author: markt
Date: Wed Mar 11 22:08:21 2015
New Revision: 1666024
URL: http://svn.apache.org/r1666024
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57683
An aborted request (the only way for the client to disconnect) should not stop
the example from working for future requests.
-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-NIO
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dexamples.sources.skip=true
-Djdt.jar=/srv
Author: markt
Date: Wed Mar 11 22:17:04 2015
New Revision: 1666027
URL: http://svn.apache.org/r1666027
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57683
An aborted request (the only way for the client to disconnect) should not stop
the example from working for future requests.
/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-APR
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
On 11/03/2015 06:19, Keiichi Fujino wrote:
2015-03-11 7:35 GMT+09:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision: 1665736
URL: http://svn.apache.org/r1665736
Log:
Stop re-using the SocketWrapper
With the introduction of upgrade and non-blocking, I/O can
Author: violetagg
Date: Wed Mar 11 08:11:24 2015
New Revision: 1665779
URL: http://svn.apache.org/r1665779
Log:
%s/comma/semicolon. Issue reported via comments at apache org.
Modified:
tomcat/trunk/webapps/docs/config/valve.xml
Modified: tomcat/trunk/webapps/docs/config/valve.xml
URL:
Author: violetagg
Date: Wed Mar 11 08:18:11 2015
New Revision: 1665786
URL: http://svn.apache.org/r1665786
Log:
Merged revision 1665779 from tomcat/trunk:
%s/comma/semicolon. Issue reported via comments at apache org.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
Author: violetagg
Date: Wed Mar 11 08:16:55 2015
New Revision: 1665783
URL: http://svn.apache.org/r1665783
Log:
Merged revision 1665779 from tomcat/trunk:
%s/comma/semicolon. Issue reported via comments at apache org.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
2015-03-11 16:50 GMT+09:00 Mark Thomas ma...@apache.org:
On 11/03/2015 06:19, Keiichi Fujino wrote:
2015-03-11 7:35 GMT+09:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision: 1665736
URL: http://svn.apache.org/r1665736
Log:
Stop re-using the
2015-03-10 23:35 GMT+01:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision: 1665736
URL: http://svn.apache.org/r1665736
Log:
Stop re-using the SocketWrapper
With the introduction of upgrade and non-blocking, I/O can occur on
non-container threads. This makes
Author: markt
Date: Wed Mar 11 08:13:07 2015
New Revision: 1665781
URL: http://svn.apache.org/r1665781
Log:
Follow-up to r1665736
Fix NPEs
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified:
2015-03-11 7:35 GMT+09:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision: 1665736
URL: http://svn.apache.org/r1665736
Log:
Stop re-using the SocketWrapper
With the introduction of upgrade and non-blocking, I/O can occur on
non-container threads. This makes it
-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-NIO2
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dexamples.sources.skip=true
Author: markt
Date: Wed Mar 11 10:14:17 2015
New Revision: 1665830
URL: http://svn.apache.org/r1665830
Log:
Update version to 1.1.33
Modified:
tomcat/native/branches/1.1.x/build.properties.default
tomcat/native/branches/1.1.x/native/include/tcn_version.h
/junit/target/junit-4.13-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-APR
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dgump.merge=/srv/gump/public/gump/work/merge.xml
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dtest.reports=output/logs-NIO
-Dtomcat
https://bz.apache.org/bugzilla/show_bug.cgi?id=57653
--- Comment #3 from Mark Thomas ma...@apache.org ---
Thanks for the safety patch. I can see what it is doing (and it looks) right
but the crash still occurs.
--
You are receiving this mail because:
You are the assignee for the bug.
On 11/03/2015 08:19, Mark Thomas wrote:
On 11/03/2015 08:01, Keiichi Fujino wrote:
2015-03-11 16:50 GMT+09:00 Mark Thomas ma...@apache.org:
On 11/03/2015 06:19, Keiichi Fujino wrote:
2015-03-11 7:35 GMT+09:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision:
-Dgump.merge=/srv/gump/public/gump/work/merge.xml
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dtest.reports=output/logs-APR
-Dtomcat
Author: markt
Date: Wed Mar 11 08:47:39 2015
New Revision: 1665803
URL: http://svn.apache.org/r1665803
Log:
Follow-up to r1665736
Fix another NPE
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
On 11/03/2015 08:01, Keiichi Fujino wrote:
2015-03-11 16:50 GMT+09:00 Mark Thomas ma...@apache.org:
On 11/03/2015 06:19, Keiichi Fujino wrote:
2015-03-11 7:35 GMT+09:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision: 1665736
URL:
On 11/03/2015 08:07, Rémy Maucherat wrote:
2015-03-10 23:35 GMT+01:00 ma...@apache.org:
Author: markt
Date: Tue Mar 10 22:35:19 2015
New Revision: 1665736
URL: http://svn.apache.org/r1665736
Log:
Stop re-using the SocketWrapper
With the introduction of upgrade and non-blocking, I/O can
https://bz.apache.org/bugzilla/show_bug.cgi?id=57687
Bug ID: 57687
Summary: securitymanager: codeBase cannot be denoted if
unpackWARs=false
Product: Tomcat 8
Version: 8.0.18
Hardware: PC
Status: NEW
Author: kkolinko
Date: Wed Mar 11 12:04:44 2015
New Revision: 1665855
URL: http://svn.apache.org/r1665855
Log:
Mention git diff command as a way to propose patches
Modified:
tomcat/site/trunk/docs/bugreport.html
tomcat/site/trunk/xdocs/bugreport.xml
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57653
--- Comment #4 from Mark Thomas ma...@apache.org ---
This is the line that is failing:
http://svn.eu.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/poll.c?view=annotate#l365
APR_RING_REMOVE(s-pe, link);
And the core dump shows s-pe
Author: kkolinko
Date: Wed Mar 11 12:26:37 2015
New Revision: 1665862
URL: http://svn.apache.org/r1665862
Log:
Describe how Tomcat documentation is built, to encourage submission of
documentation patches.
Modified:
tomcat/site/trunk/docs/bugreport.html
-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-NIO
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dexamples.sources.skip=true
Author: kfujino
Date: Thu Mar 12 02:14:08 2015
New Revision: 1666062
URL: http://svn.apache.org/r1666062
Log:
Make sure that refuse the messages from a different domain in
DomainFilterInterceptor.
Modified:
Author: kfujino
Date: Thu Mar 12 02:26:27 2015
New Revision: 1666065
URL: http://svn.apache.org/r1666065
Log:
Add changelog entry for r1666064.
Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL:
Author: kfujino
Date: Thu Mar 12 02:16:15 2015
New Revision: 1666063
URL: http://svn.apache.org/r1666063
Log:
Remove unnecessary method that always returns true.
The domain filtering works on DomainFilterInterceptor.
Modified:
-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-NIO2
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dexamples.sources.skip=true
-Djdt.jar
https://bz.apache.org/bugzilla/show_bug.cgi?id=57653
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Product|Tomcat 9|Tomcat Native
Author: markt
Date: Wed Mar 11 14:44:23 2015
New Revision: 1665888
URL: http://svn.apache.org/r1665888
Log:
Fix 57653. Crash when multiple events for same socket are returned via separate
apr_pollfd_t structures
Modified:
tomcat/native/branches/1.1.x/native/src/poll.c
Modified:
On 11/03/2015 14:44, ma...@apache.org wrote:
Author: markt
Date: Wed Mar 11 14:44:23 2015
New Revision: 1665888
URL: http://svn.apache.org/r1665888
Log:
Fix 57653. Crash when multiple events for same socket are returned via
separate apr_pollfd_t structures
Review appreciated from folks
-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-NIO
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150311-native-src.tar.gz
-Dexamples.sources.skip=true
-Djdt.jar=/srv
Author: kfujino
Date: Thu Mar 12 05:39:16 2015
New Revision: 1666083
URL: http://svn.apache.org/r1666083
Log:
Remove unused message.
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
Author: kfujino
Date: Thu Mar 12 05:40:44 2015
New Revision: 1666085
URL: http://svn.apache.org/r1666085
Log:
Remove unused message.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
Author: kfujino
Date: Thu Mar 12 05:40:01 2015
New Revision: 1666084
URL: http://svn.apache.org/r1666084
Log:
Remove unused message.
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
Author: kfujino
Date: Thu Mar 12 02:28:42 2015
New Revision: 1666066
URL: http://svn.apache.org/r1666066
Log:
Remove unnecessary method that always returns true.
The domain filtering works on DomainFilterInterceptor.
Modified:
Author: kfujino
Date: Thu Mar 12 02:44:00 2015
New Revision: 1666070
URL: http://svn.apache.org/r1666070
Log:
Make sure that refuse the messages from a different domain in
DomainFilterInterceptor.
Modified:
Author: kfujino
Date: Thu Mar 12 02:48:59 2015
New Revision: 1666071
URL: http://svn.apache.org/r1666071
Log:
Remove unnecessary method that always returns true.
The domain filtering works on DomainFilterInterceptor.
Modified:
Author: kfujino
Date: Thu Mar 12 02:24:10 2015
New Revision: 1666064
URL: http://svn.apache.org/r1666064
Log:
Make sure that refuse the messages from a different domain in
DomainFilterInterceptor.
Modified:
70 matches
Mail list logo
