Re: removing empty stubs in tc-native trunk

2015-06-15 Thread Mark Thomas
On 15/06/2015 12:27, jean-frederic clere wrote: Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? Yes, if we want to be able to support the APR/native connector without OpenSSL. With NIO and NIO2 connectors we don't need native when we aren't using

removing empty stubs in tc-native trunk

2015-06-15 Thread jean-frederic clere
Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? With NIO and NIO2 connectors we don't need native when we aren't using SSL. Comments? Cheers Jean-Frederic - To unsubscribe,

Multi-threaded unit tests

2015-06-15 Thread Mark Thomas
I have been experimenting with the free Azure credits that come with the MSDN subscription Microsoft kindly offers to all Apache committers to use for their ASF work. I have been looking at options for making the unit tests run faster. All the figures below are for running the trunk unit tests

Re: removing empty stubs in tc-native trunk

2015-06-15 Thread Mark Thomas
On 15/06/2015 12:39, jean-frederic clere wrote: On 06/15/2015 01:32 PM, Mark Thomas wrote: On 15/06/2015 12:27, jean-frederic clere wrote: Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? Yes, if we want to be able to support the APR/native

Re: removing empty stubs in tc-native trunk

2015-06-15 Thread jean-frederic clere
On 06/15/2015 01:32 PM, Mark Thomas wrote: On 15/06/2015 12:27, jean-frederic clere wrote: Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? Yes, if we want to be able to support the APR/native connector without OpenSSL. With NIO and NIO2 connectors

svn commit: r1685562 - in /tomcat/tc8.0.x/trunk: java/org/apache/tomcat/websocket/WsSession.java java/org/apache/tomcat/websocket/WsWebSocketContainer.java test/org/apache/tomcat/websocket/TestWsWebSo

2015-06-15 Thread remm
Author: remm Date: Mon Jun 15 12:04:06 2015 New Revision: 1685562 URL: http://svn.apache.org/r1685562 Log: Port fix for 57974: Key the open session map on the endpoint instance rather than endpoint class. Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java

[GitHub] tomcat-native pull request: Port Netty-tc-native code to tomcat-na...

2015-06-15 Thread jfclere
GitHub user jfclere opened a pull request: https://github.com/apache/tomcat-native/pull/2 Port Netty-tc-native code to tomcat-native That PR to merge https://github.com/netty/netty-tcnative/ back to tomcat-native. Note that the netty uses the code from 1.1.x and I am porting it

svn commit: r1685556 - /tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 11:36:01 2015 New Revision: 1685556 URL: http://svn.apache.org/r1685556 Log: Make it possible to run unit tests in parallel using new threads attribute of Ant's JUnit task Modified: tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java Modified:

Re: JASPIC Implementation pointers

2015-06-15 Thread Fjodor Vershinin
Hi, all! Here is my report for previous week. I'd ported JASPIC api classes and implemented skeleton for JASPIC support. The skeleton was implemented using plan proposed by Mark. It contains very basic AuthConfigFactory, callback handler's, and JaspicAuthenticator. I did some hacking on weekend

Re: removing empty stubs in tc-native trunk

2015-06-15 Thread Rémy Maucherat
2015-06-15 13:32 GMT+02:00 Mark Thomas ma...@apache.org: On 15/06/2015 12:27, jean-frederic clere wrote: Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? Yes, if we want to be able to support the APR/native connector without OpenSSL. With

[Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

2015-06-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 Christopher L. Simons christopherleesim...@gmail.com changed: What|Removed |Added Target Milestone|-

svn commit: r1685570 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/websocket/WsSession.java java/org/apache/tomcat/websocket/WsWebSocketContainer.java test/org/apache/tomcat/websocket/TestWsWebSo

2015-06-15 Thread remm
Author: remm Date: Mon Jun 15 12:33:59 2015 New Revision: 1685570 URL: http://svn.apache.org/r1685570 Log: Port r1685562 57974: Key the open session map on the endpoint instance rather than endpoint class. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java

Re: Multi-threaded unit tests

2015-06-15 Thread Mark Thomas
On 15/06/2015 13:02, Mark Thomas wrote: I have been experimenting with the free Azure credits that come with the MSDN subscription Microsoft kindly offers to all Apache committers to use for their ASF work. I have been looking at options for making the unit tests run faster. All the

[Bug 57974] getOpenSessions() bug

2015-06-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57974 Remy Maucherat r...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1685591 - in /tomcat/trunk: BUILDING.txt build.properties.default build.xml webapps/docs/changelog.xml

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 14:48:44 2015 New Revision: 1685591 URL: http://svn.apache.org/r1685591 Log: Update the minimum Ant version 1.9.5 and enable parallel running of junit tests Modified: tomcat/trunk/BUILDING.txt tomcat/trunk/build.properties.default tomcat/trunk/build.xml

buildbot failure in ASF Buildbot on tomcat-trunk

2015-06-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1383 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: SSLSocket.getALPN()

2015-06-15 Thread Mark Thomas
On 15/06/2015 15:17, jean-frederic clere wrote: Hi, We are using SSLSocket.getALPN() but in fact that belongs to SSL according to the C code, should we move that to SSL and use the netty-tc-native code there? I don't understand. ALPN is negotiated per socket and all the per socket methods

Re: JASPIC Implementation pointers

2015-06-15 Thread Mark Thomas
On 15/06/2015 12:14, Fjodor Vershinin wrote: Hi, all! Here is my report for previous week. I'd ported JASPIC api classes and implemented skeleton for JASPIC support. The skeleton was implemented using plan proposed by Mark. It contains very basic AuthConfigFactory, callback handler's, and

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2015-06-15 Thread Mark Thomas
On 15/06/2015 15:56, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1383 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: JASPIC Implementation pointers

2015-06-15 Thread Mark Thomas
On 15/06/2015 16:42, Fjodor Vershinin wrote: 2015-06-15 17:53 GMT+03:00 Mark Thomas ma...@apache.org: On 15/06/2015 12:14, Fjodor Vershinin wrote: Hi, all! Here is my report for previous week. I'd ported JASPIC api classes and implemented skeleton for JASPIC support. The skeleton was

svn commit: r1685593 - /tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 15:10:18 2015 New Revision: 1685593 URL: http://svn.apache.org/r1685593 Log: Trivial Javadoc commit to test CI system Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java Modified:

Re: JASPIC Implementation pointers

2015-06-15 Thread Fjodor Vershinin
2015-06-15 17:53 GMT+03:00 Mark Thomas ma...@apache.org: On 15/06/2015 12:14, Fjodor Vershinin wrote: Hi, all! Here is my report for previous week. I'd ported JASPIC api classes and implemented skeleton for JASPIC support. The skeleton was implemented using plan proposed by Mark. It

SSLSocket.getALPN()

2015-06-15 Thread jean-frederic clere
Hi, We are using SSLSocket.getALPN() but in fact that belongs to SSL according to the C code, should we move that to SSL and use the netty-tc-native code there? SSL.getAlpnSelected() would do the trick, Cheers Jean-Frederic

Re: SSLSocket.getALPN()

2015-06-15 Thread jean-frederic clere
On 06/15/2015 04:25 PM, Mark Thomas wrote: On 15/06/2015 15:17, jean-frederic clere wrote: Hi, We are using SSLSocket.getALPN() but in fact that belongs to SSL according to the C code, should we move that to SSL and use the netty-tc-native code there? I don't understand. ALPN is negotiated

svn commit: r1685633 - /tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 17:16:11 2015 New Revision: 1685633 URL: http://svn.apache.org/r1685633 Log: Extracted method for getting factory class name Patch by fjodorver Modified: tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java Modified:

svn commit: r1685637 - /tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 17:22:05 2015 New Revision: 1685637 URL: http://svn.apache.org/r1685637 Log: Trivial clean-up. Based on a patch by fjodorver Modified: tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java Modified:

buildbot success in ASF Buildbot on tomcat-trunk

2015-06-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1384 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

2015-06-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 Christopher L. Simons christopherleesim...@gmail.com changed: What|Removed |Added CC|

[Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

2015-06-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 Christopher L. Simons christopherleesim...@gmail.com changed: What|Removed |Added Attachment #32821|Initial draft of patch to

svn commit: r1685671 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic: ./ AuthConfigFactoryImpl.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 21:17:50 2015 New Revision: 1685671 URL: http://svn.apache.org/r1685671 Log: Add stubbed out AuthConfigFactory implementation. Patch by fjodorver Added: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/

svn commit: r1685673 - in /tomcat/trunk/java/org/apache/catalina: authenticator/jaspic/JaspicAuthenticator.java startup/Authenticators.properties

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 21:20:17 2015 New Revision: 1685673 URL: http://svn.apache.org/r1685673 Log: Add stubbed out JaspicAuthenticator implementation. Patch by fjodorver Added: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/JaspicAuthenticator.java (with props)

svn commit: r1685674 - in /tomcat/trunk/java: javax/security/auth/message/config/AuthConfigFactory.java org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 21:34:00 2015 New Revision: 1685674 URL: http://svn.apache.org/r1685674 Log: Initial AuthConfigFactory implementation. Patch by fjodorver Modified: tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java

svn commit: r1685678 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic: JaspicAuthenticator.java JaspicCallbackHandler.java MessageInfoImpl.java PrincipalGroupCallback.java

2015-06-15 Thread markt
Author: markt Date: Mon Jun 15 22:11:10 2015 New Revision: 1685678 URL: http://svn.apache.org/r1685678 Log: Implemented very basic JASPIC support with ability to register providers Patch by fjodorver Added:

Re: porting netty-tcnative to tomcat-native

2015-06-15 Thread jean-frederic clere
On 06/15/2015 08:25 AM, Mark Thomas wrote: On 15/06/2015 06:55, jean-frederic clere wrote: Hi, The netty-tcnative is based on the 1.1.x so the porting taking more than excepted. Are you going to be able to commit this in multiple commits or is it going to be one big commit? A big commit it

Re: porting netty-tcnative to tomcat-native

2015-06-15 Thread Mark Thomas
On 15/06/2015 09:35, jean-frederic clere wrote: On 06/15/2015 08:25 AM, Mark Thomas wrote: On 15/06/2015 06:55, jean-frederic clere wrote: Hi, The netty-tcnative is based on the 1.1.x so the porting taking more than excepted. Are you going to be able to commit this in multiple commits or

Re: porting netty-tcnative to tomcat-native

2015-06-15 Thread Mark Thomas
On 15/06/2015 06:55, jean-frederic clere wrote: Hi, The netty-tcnative is based on the 1.1.x so the porting taking more than excepted. Are you going to be able to commit this in multiple commits or is it going to be one big commit? I would like some comments on the class caching for