svn commit: r1715434 - in /tomcat/trunk: java/org/apache/catalina/Globals.java java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2015-11-20 Thread schultz
Author: schultz Date: Fri Nov 20 22:26:21 2015 New Revision: 1715434 URL: http://svn.apache.org/viewvc?rev=1715434&view=rev Log: Make a web application's CredentialHandler available through a context attribute. Modified: tomcat/trunk/java/org/apache/catalina/Globals.java tomcat/trunk/jav

Re: svn commit: r1715425 - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2015-11-20 Thread Mark Thomas
On 20/11/2015 21:35, ma...@apache.org wrote: > Author: markt > Date: Fri Nov 20 21:35:41 2015 > New Revision: 1715425 > > URL: http://svn.apache.org/viewvc?rev=1715425&view=rev > Log: > Update presentation list and add navigation link The presentation list is a bit me, me, me at the moment. Pleas

svn commit: r1715425 - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 21:35:41 2015 New Revision: 1715425 URL: http://svn.apache.org/viewvc?rev=1715425&view=rev Log: Update presentation list and add navigation link Modified: tomcat/site/trunk/docs/bugreport.html tomcat/site/trunk/docs/ci.html tomcat/site/trunk/docs/contact

Re: Policy for changelogs now that Tomcat 9 has an official release

2015-11-20 Thread Mark Thomas
On 20/11/2015 20:54, Christopher Schultz wrote: > All, > > IF I'm going to commit to trunk (Tomcat 9) and then back-port something, > shall I add it to both the Tomcat 9 changelog as well as the Tomcat 8 > (etc.) changelogs? Yes. > Since Tomcat 9's build is really a pre-release, I can see an arg

[Bug 58631] New: Documentation uses wrong syntax for windows command line continuation

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58631 Bug ID: 58631 Summary: Documentation uses wrong syntax for windows command line continuation Product: Tomcat 9 Version: unspecified Hardware: All OS: All

Policy for changelogs now that Tomcat 9 has an official release

2015-11-20 Thread Christopher Schultz
All, IF I'm going to commit to trunk (Tomcat 9) and then back-port something, shall I add it to both the Tomcat 9 changelog as well as the Tomcat 8 (etc.) changelogs? Since Tomcat 9's build is really a pre-release, I can see an argument for ignoring the changelog for now and only mentioning chang

[Bug 58629] Container is not initialized while starting tomcat in embedded mode.

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58629 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1715421 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardService.java java/org/apache/catalina/mapper/MapperListener.java webapps/docs/changelog.xml

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:38:09 2015 New Revision: 1715421 URL: http://svn.apache.org/viewvc?rev=1715421&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58629 Allow an embedded Tomcat instance to start when the Service has no Engine configured. Modified: tomcat/tc8.0.

svn commit: r1715418 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/mapper/ java/org/apache/catali

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:33:53 2015 New Revision: 1715418 URL: http://svn.apache.org/viewvc?rev=1715418&view=rev Log: Back-port prep for 9.0.x refactoring. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/Service.java tomcat/tc8.

svn commit: r1715413 - in /tomcat/trunk/java/org/apache/catalina: Service.java core/StandardService.java

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:28:32 2015 New Revision: 1715413 URL: http://svn.apache.org/viewvc?rev=1715413&view=rev Log: Service.container is always an Engine to so use Engine explicitly Modified: tomcat/trunk/java/org/apache/catalina/Service.java tomcat/trunk/java/org/apache/catali

svn commit: r1715416 - /tomcat/trunk/java/org/apache/catalina/core/StandardService.java

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:28:46 2015 New Revision: 1715416 URL: http://svn.apache.org/viewvc?rev=1715416&view=rev Log: Clean-up Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java URL: ht

svn commit: r1715414 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/mapper/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/storeconfig

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:28:37 2015 New Revision: 1715414 URL: http://svn.apache.org/viewvc?rev=1715414&view=rev Log: Remove deprecated code. Service.container Container->Engine Modified: tomcat/trunk/java/org/apache/catalina/Service.java tomcat/trunk/java/org/apache/catalina/cor

svn commit: r1715417 - in /tomcat/trunk: java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardService.java webapps/docs/changelog.xml

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:28:51 2015 New Revision: 1715417 URL: http://svn.apache.org/viewvc?rev=1715417&view=rev Log: Correctly notify the MapperListener associated with a Service if the Engine for that Service is changed. Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStr

svn commit: r1715415 - in /tomcat/trunk: java/org/apache/catalina/core/StandardService.java java/org/apache/catalina/mapper/MapperListener.java webapps/docs/changelog.xml

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 20:28:42 2015 New Revision: 1715415 URL: http://svn.apache.org/viewvc?rev=1715415&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58629 Allow an embedded Tomcat instance to start when the Service has no Engine configured. Modified: tomcat/trunk/

Re: access log valve not using logger?

2015-11-20 Thread Romain Manni-Bucau
+1, that is more or less what I just hacked for tomcat 7/8. Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2015-11-20 12:01 GMT-08:00 Christopher Schultz : > Romain, > > On 11/20/15 2:44 PM, Romain Manni-Bucau wrote: >> any reason the AccessLogValve doesnt rely on JULI

Re: access log valve not using logger?

2015-11-20 Thread Christopher Schultz
Romain, On 11/20/15 2:44 PM, Romain Manni-Bucau wrote: > any reason the AccessLogValve doesnt rely on JULI - > https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/valves/AccessLogValve.java#L515 > ? Because JULI is slow, and we want logging to be fast. Logging frameworks are sup

Re: svn commit: r1715382 - in /tomcat/trunk/java/org/apache/catalina: authenticator/jaspic/JaspicAuthenticator.java startup/ContextConfig.java

2015-11-20 Thread Rémy Maucherat
2015-11-20 19:06 GMT+01:00 Christopher Schultz : > Rémy, > > Is there any performance benefit to avoiding these String concatenations > for (potentially) every request? I mean... there *is* a performance > benefit to not concatenating String every time, but I'm wondering how > often will this kind

access log valve not using logger?

2015-11-20 Thread Romain Manni-Bucau
Hi guys, any reason the AccessLogValve doesnt rely on JULI - https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/valves/AccessLogValve.java#L515 ? Makes it quite complicated to extend the logging logic or use another logging framework with more rotation policy for instance. Roma

[Tomcat Wiki] Update of "Security/Ciphers" by OgnjenBlagojevic

2015-11-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Security/Ciphers" page has been changed by OgnjenBlagojevic: https://wiki.apache.org/tomcat/Security/Ciphers?action=diff&rev1=6&rev2=7 There is no right choice since there are

[Bug 58621] HTTP APR connector does not supply certificate chain

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58621 Ognjen Blagojevic changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #2 from Ognjen

Re: svn commit: r1715382 - in /tomcat/trunk/java/org/apache/catalina: authenticator/jaspic/JaspicAuthenticator.java startup/ContextConfig.java

2015-11-20 Thread Christopher Schultz
Rémy, On 11/20/15 11:11 AM, r...@apache.org wrote: > Author: remm > Date: Fri Nov 20 16:11:59 2015 > New Revision: 1715382 > > URL: http://svn.apache.org/viewvc?rev=1715382&view=rev > Log: > Remove duplication for the appContext. > > Modified: > > tomcat/trunk/java/org/apache/catalina/authe

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
Mark, On 11/20/15 9:26 AM, Mark Thomas wrote: > On 20/11/2015 14:23, Mark Thomas wrote: >>> 2015-11-20 13:47 GMT+01:00 Christopher Schultz > > why does StandardContext.startInternal call getRealmInternal().start() when ContainerBase.setRealm already calls Realm.start()?) >> >> N

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
Mark, On 11/20/15 9:23 AM, Mark Thomas wrote: > On 20/11/2015 13:07, Rémy Maucherat wrote: >> 2015-11-20 13:47 GMT+01:00 Christopher Schultz >> : >> >>> All, >>> >>> I thought there was a BZ issue for this, but I didn't find one. It's >>> been suggested (and I agree completely) that an application

svn commit: r1715382 - in /tomcat/trunk/java/org/apache/catalina: authenticator/jaspic/JaspicAuthenticator.java startup/ContextConfig.java

2015-11-20 Thread remm
Author: remm Date: Fri Nov 20 16:11:59 2015 New Revision: 1715382 URL: http://svn.apache.org/viewvc?rev=1715382&view=rev Log: Remove duplication for the appContext. Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/JaspicAuthenticator.java tomcat/trunk/java/org/apache/

buildbot success in ASF Buildbot on tomcat-trunk

2015-11-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/640 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

svn commit: r1715370 - /tomcat/trunk/webapps/docs/config/http.xml

2015-11-20 Thread remm
Author: remm Date: Fri Nov 20 14:39:01 2015 New Revision: 1715370 URL: http://svn.apache.org/viewvc?rev=1715370&view=rev Log: Add another clarification, since that's what mod_ssl documentation says. Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/confi

buildbot failure in ASF Buildbot on tomcat-trunk

2015-11-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/639 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Mark Thomas
On 20/11/2015 14:23, Mark Thomas wrote: >> 2015-11-20 13:47 GMT+01:00 Christopher Schultz >>> why does StandardContext.startInternal call >>> getRealmInternal().start() when ContainerBase.setRealm already calls >>> Realm.start()?) > > Not sure right now. I'll take a quick look. Because setRealm

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Rémy Maucherat
2015-11-20 15:17 GMT+01:00 Christopher Schultz : > Rémy, > > > > +1 for removing those pointless locks. > > Okay. I'm not going to remove those myself, though. If I don't hear from > anyone in a while, I'll commit my patch which always calls delegates to > getRealmInternal.getCredentialHandler.cal

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Mark Thomas
On 20/11/2015 13:07, Rémy Maucherat wrote: > 2015-11-20 13:47 GMT+01:00 Christopher Schultz > : > >> All, >> >> I thought there was a BZ issue for this, but I didn't find one. It's >> been suggested (and I agree completely) that an application ought to be >> able to fetch the CredentialHandler for

svn commit: r1715369 - /tomcat/trunk/webapps/docs/config/http.xml

2015-11-20 Thread remm
Author: remm Date: Fri Nov 20 14:18:57 2015 New Revision: 1715369 URL: http://svn.apache.org/viewvc?rev=1715369&view=rev Log: Add an important note from the JNI javadoc (confirmed at: http://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslcertificatechainfile) when using multiple certificates. Mo

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
Rémy, On 11/20/15 8:07 AM, Rémy Maucherat wrote: > 2015-11-20 13:47 GMT+01:00 Christopher Schultz > : > >> All, >> >> I thought there was a BZ issue for this, but I didn't find one. It's >> been suggested (and I agree completely) that an application ought to be >> able to fetch the CredentialHand

[Bug 58621] HTTP APR connector does not supply certificate chain

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58621 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1715366 - /tomcat/trunk/webapps/docs/config/http.xml

2015-11-20 Thread remm
Author: remm Date: Fri Nov 20 14:11:55 2015 New Revision: 1715366 URL: http://svn.apache.org/viewvc?rev=1715366&view=rev Log: Add cert chain property documentation. Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache

svn commit: r1715365 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/openssl/ webapps/docs/

2015-11-20 Thread remm
Author: remm Date: Fri Nov 20 14:07:10 2015 New Revision: 1715365 URL: http://svn.apache.org/viewvc?rev=1715365&view=rev Log: 58621: Add back the certificate chain attribute. Testing with the test keys, the chain includes the main cert as the first one, so in that case the "strip first" argument

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Rémy Maucherat
2015-11-20 13:47 GMT+01:00 Christopher Schultz : > All, > > I thought there was a BZ issue for this, but I didn't find one. It's > been suggested (and I agree completely) that an application ought to be > able to fetch the CredentialHandler for the context's realm so that it > could mutate user cr

Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
All, I thought there was a BZ issue for this, but I didn't find one. It's been suggested (and I agree completely) that an application ought to be able to fetch the CredentialHandler for the context's realm so that it could mutate user credentials in the same way that the Realm expects to do. That

[Bug 58481] JAX WS Request fails with "Premature end of file"

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58481 immo.schulz-gerl...@fernuni-hagen.de changed: What|Removed |Added CC||immo.schulz-gerla

[Bug 58481] JAX WS Request fails with "Premature end of file"

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58481 --- Comment #6 from Oliver Schönwald --- As this error does not happen with every Tomcat Release, I have tried out several releases and come to this conclusion: This error started with release 7.0.61 in der Tomcat 7 line. In the Tomcat 8 line t

[VOTE] Release Apache Tomcat 8.0.29

2015-11-20 Thread Mark Thomas
The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes - Correct a regression in the fix for 56777 that added support for URIs in config file locations - A

svn commit: r11250 [1/2] - in /dev/tomcat/tomcat-8/v8.0.29: ./ bin/ bin/embed/ bin/extras/ src/

2015-11-20 Thread markt
Author: markt Date: Fri Nov 20 09:47:34 2015 New Revision: 11250 Log: Upload 8.0.29 for voting Added: dev/tomcat/tomcat-8/v8.0.29/ dev/tomcat/tomcat-8/v8.0.29/KEYS (with props) dev/tomcat/tomcat-8/v8.0.29/README.html (with props) dev/tomcat/tomcat-8/v8.0.29/RELEASE-NOTES d

svn commit: r11250 [2/2] - in /dev/tomcat/tomcat-8/v8.0.29: ./ bin/ bin/embed/ bin/extras/ src/

2015-11-20 Thread markt
Added: dev/tomcat/tomcat-8/v8.0.29/bin/extras/catalina-ws.jar.asc == --- dev/tomcat/tomcat-8/v8.0.29/bin/extras/catalina-ws.jar.asc (added) +++ dev/tomcat/tomcat-8/v8.0.29/bin/extras/catalina-ws.jar.asc Fri Nov 20 09:47:34

8.0.29 update

2015-11-20 Thread Mark Thomas
More problems with the Symantec code signing service. I'm going to skip the Windows code signing for the 8.0.29 release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2015-11-20 Thread Bill Barker
Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151120.jar -

[Bug 58629] Container is not initialized while starting tomcat in embedded mode.

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58629 Sagar Gandhi changed: What|Removed |Added OS||All -- You are receiving this mail bec

[Bug 58629] New: Container is not initialized while starting tomcat in embedded mode.

2015-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58629 Bug ID: 58629 Summary: Container is not initialized while starting tomcat in embedded mode. Product: Tomcat 9 Version: 9.0.0.M1 Hardware: PC Status: NEW