svn commit: r1725851 - /tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java

2016-01-20 Thread schultz
Author: schultz Date: Thu Jan 21 01:46:11 2016 New Revision: 1725851 URL: http://svn.apache.org/viewvc?rev=1725851=rev Log: Fix potential resource leak. Modified: tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java Modified:

[Bug 58900] Memory leak due to infinite redeploy loop

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58900 --- Comment #3 from Christopher Schultz --- I think the root issue is that your application leaks a ClassLoader for some reason (and you should definitely fix that), but Tomcat should also not be endlessly

svn commit: r1725852 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/realm/DataSourceRealm.java webapps/docs/changelog.xml

2016-01-20 Thread schultz
Author: schultz Date: Thu Jan 21 01:52:19 2016 New Revision: 1725852 URL: http://svn.apache.org/viewvc?rev=1725852=rev Log: Back-port r1725851 to fix a potential resource leak. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1725853 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/DataSourceRealm.java webapps/docs/changelog.xml

2016-01-20 Thread schultz
Author: schultz Date: Thu Jan 21 01:56:04 2016 New Revision: 1725853 URL: http://svn.apache.org/viewvc?rev=1725853=rev Log: Back-port r1725851 to fix a potential resource leak. Modified: tomcat/tc7.0.x/trunk/ (props changed)

[GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2016-01-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-make has an issue affecting its community integration. This

[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2016-01-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community

svn commit: r1725859 - /tomcat/native/branches/1.1.x/native/src/sslutils.c

2016-01-20 Thread billbarker
Author: billbarker Date: Thu Jan 21 02:47:08 2016 New Revision: 1725859 URL: http://svn.apache.org/viewvc?rev=1725859=rev Log: OpenSSL master has changed EVP_PKEY to an abstract type Modified: tomcat/native/branches/1.1.x/native/src/sslutils.c Modified:

[Bug 58891] Bad and/or dangerous SSL/TLS documentation

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58891 --- Comment #3 from Christopher Schultz --- I like the idea, I don't like your re-write as it stands. A certificate, for instance, does not guarantee security of a site. The site can be full of malware designed to

svn commit: r1725733 - in /tomcat/trunk/java/org/apache/tomcat/dbcp/pool2: ./ impl/

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 14:55:42 2016 New Revision: 1725733 URL: http://svn.apache.org/viewvc?rev=1725733=rev Log: Update Tomcat's internal fork of Pool2 to pool2/trunk Added: tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/BaseObject.java - copied, changed from r1725731,

svn commit: r1725734 - in /tomcat/trunk/java/org/apache/tomcat/util: digester/ArrayStack.java http/fileupload/util/mime/QuotedPrintableDecoder.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 14:58:19 2016 New Revision: 1725734 URL: http://svn.apache.org/viewvc?rev=1725734=rev Log: Javadoc stragglers Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/ArrayStack.java

buildbot failure in ASF Buildbot on tomcat-trunk

2016-01-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/970 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1725737 - in /tomcat/trunk/java/org/apache/tomcat/dbcp/pool2: ./ impl/GenericObjectPool.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 15:03:53 2016 New Revision: 1725737 URL: http://svn.apache.org/viewvc?rev=1725737=rev Log: Merge in a Javadoc fix from pool2 (update to latest trunk) Modified: tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/ (props changed)

svn commit: r1725746 - /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 16:10:04 2016 New Revision: 1725746 URL: http://svn.apache.org/viewvc?rev=1725746=rev Log: No recent changes to fileupload Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) Propchange:

buildbot success in ASF Buildbot on tomcat-trunk

2016-01-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/971 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1725739 - in /tomcat/trunk/java/org/apache/tomcat/dbcp/pool2: ./ impl/LinkedBlockingDeque.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 15:20:52 2016 New Revision: 1725739 URL: http://svn.apache.org/viewvc?rev=1725739=rev Log: Merge in a Javadoc fix from pool2 (update to latest trunk) Modified: tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/ (props changed)

Re: svn commit: r1725706 - /tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java

2016-01-20 Thread Mark Thomas
On 20/01/2016 12:56, Konstantin Kolinko wrote: > 2016-01-20 15:21 GMT+03:00 : >> Author: markt >> Date: Wed Jan 20 12:21:26 2016 >> New Revision: 1725706 >> >> URL: http://svn.apache.org/viewvc?rev=1725706=rev >> Log: >> Don't need to bind the thread when saving sessions.

svn commit: r1725749 - in /tomcat/trunk/java/org/apache/tomcat/util/codec: ./ binary/Base64.java binary/BaseNCodec.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 16:14:52 2016 New Revision: 1725749 URL: http://svn.apache.org/viewvc?rev=1725749=rev Log: Update Tomcat's internal fork of codec to codec/trunk Modified: tomcat/trunk/java/org/apache/tomcat/util/codec/ (props changed)

svn commit: r1725750 - /tomcat/trunk/webapps/docs/changelog.xml

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 16:24:39 2016 New Revision: 1725750 URL: http://svn.apache.org/viewvc?rev=1725750=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

Re: svn commit: r1725706 - /tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java

2016-01-20 Thread Mark Thomas
On 20/01/2016 16:07, Mark Thomas wrote: > On 20/01/2016 12:56, Konstantin Kolinko wrote: >> 2016-01-20 15:21 GMT+03:00 : >>> Author: markt >>> Date: Wed Jan 20 12:21:26 2016 >>> New Revision: 1725706 >>> >>> URL: http://svn.apache.org/viewvc?rev=1725706=rev >>> Log: >>> Don't

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2016-01-20 Thread Bill Barker
-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160120.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x

svn commit: r1725816 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java test/org/apache/catalina/startup/TestHostConfigAutomaticDeployment.java webapps/docs/changelog.xml

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 21:21:35 2016 New Revision: 1725816 URL: http://svn.apache.org/viewvc?rev=1725816=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58867 Improve WAR modification checking on Host start Modified:

[Bug 58867] Having a context.xml in conf prevents redeployment on startup

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58867 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1725818 - in /tomcat/trunk/java/org/apache/jasper: compiler/TagFileProcessor.java compiler/TagLibraryInfoImpl.java runtime/PageContextImpl.java xmlparser/SymbolTable.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 21:33:44 2016 New Revision: 1725818 URL: http://svn.apache.org/viewvc?rev=1725818=rev Log: A handful of Jasper Javadoc fixes Modified: tomcat/trunk/java/org/apache/jasper/compiler/TagFileProcessor.java

svn commit: r1725817 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java test/org/apache/catalina/startup/TestHostConfigAutomaticDeployment.java webapps/docs/changelog.x

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 21:25:35 2016 New Revision: 1725817 URL: http://svn.apache.org/viewvc?rev=1725817=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58867 Improve WAR modification checking on Host start Modified: tomcat/tc8.0.x/trunk/ (props changed)

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2016-01-20 Thread Bill Barker
/commons-daemon-20160120-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20160120/lib -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public

[Bug 58900] New: Memory leak due to infinite redeploy loop

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58900 Bug ID: 58900 Summary: Memory leak due to infinite redeploy loop Product: Tomcat 8 Version: trunk Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity:

[Bug 58900] Memory leak due to infinite redeploy loop

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58900 Lauri Lehtinen changed: What|Removed |Added CC|

[Bug 58900] Memory leak due to infinite redeploy loop

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58900 --- Comment #2 from Lauri Lehtinen --- Easy fix for this particular problem would be to remove the getCanonicalFile call in HostConfig

[Bug 58891] Bad and/or dangerous SSL/TLS documentation

2016-01-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58891 --- Comment #2 from Alexander Kjäll --- Hi I agree that SSL is complex, and I don't think it's within the scope of the tomcat documentation to address all aspects of it, it can be very lengthy to describe how

svn commit: r1725686 - /tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 08:59:17 2016 New Revision: 1725686 URL: http://svn.apache.org/viewvc?rev=1725686=rev Log: Add Javadoc section Modified: tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt Modified:

svn commit: r1725687 - in /tomcat/trunk/java/org/apache/jasper/compiler: ELNode.java Generator.java Node.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 09:09:08 2016 New Revision: 1725687 URL: http://svn.apache.org/viewvc?rev=1725687=rev Log: Javadoc Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELNode.java tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Re: svn commit: r1725687 - in /tomcat/trunk/java/org/apache/jasper/compiler: ELNode.java Generator.java Node.java

2016-01-20 Thread Rémy Maucherat
2016-01-20 10:09 GMT+01:00 : > Author: markt > Date: Wed Jan 20 09:09:08 2016 > New Revision: 1725687 > > URL: http://svn.apache.org/viewvc?rev=1725687=rev > Log: > Javadoc > > Modified: > tomcat/trunk/java/org/apache/jasper/compiler/ELNode.java >

svn commit: r1725696 - in /tomcat/trunk/java/org/apache/catalina/session: FileStore.java JDBCStore.java StoreBase.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 10:52:57 2016 New Revision: 1725696 URL: http://svn.apache.org/viewvc?rev=1725696=rev Log: Ensure that when sessions are loaded from the Store that the correct class loader is used. In most cases it was already set but some code paths from early in the processing

svn commit: r1725697 - /tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 10:53:25 2016 New Revision: 1725697 URL: http://svn.apache.org/viewvc?rev=1725697=rev Log: Store.load() will now set TCCL if necessary. No need to set it here. Modified: tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java Modified:

buildbot success in ASF Buildbot on tomcat-trunk

2016-01-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/966 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1725694 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 10:28:37 2016 New Revision: 1725694 URL: http://svn.apache.org/viewvc?rev=1725694=rev Log: Further fix to regression in r1725599 Trigger a call to stop() if a component puts itself into the FAILED state during start(). Modified:

Re: svn commit: r1725687 - in /tomcat/trunk/java/org/apache/jasper/compiler: ELNode.java Generator.java Node.java

2016-01-20 Thread Mark Thomas
On 20/01/2016 10:05, Rémy Maucherat wrote: > 2016-01-20 10:09 GMT+01:00 : > >> Author: markt >> Date: Wed Jan 20 09:09:08 2016 >> New Revision: 1725687 >> >> URL: http://svn.apache.org/viewvc?rev=1725687=rev >> Log: >> Javadoc >> >> Modified: >>

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-01-20 Thread Bill Barker
/daemon/dist/bin/commons-daemon-20160120-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20160120/lib -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-01-20 Thread Bill Barker
/commons-daemon-20160120-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160120.jar -Dcommons

Re: svn commit: r1725706 - /tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java

2016-01-20 Thread Konstantin Kolinko
2016-01-20 15:21 GMT+03:00 : > Author: markt > Date: Wed Jan 20 12:21:26 2016 > New Revision: 1725706 > > URL: http://svn.apache.org/viewvc?rev=1725706=rev > Log: > Don't need to bind the thread when saving sessions. Classes already have > the necessary reference to their class

svn commit: r1725706 - /tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 12:21:26 2016 New Revision: 1725706 URL: http://svn.apache.org/viewvc?rev=1725706=rev Log: Don't need to bind the thread when saving sessions. Classes already have the necessary reference to their class loader. Modified:

svn commit: r1725713 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 13:09:22 2016 New Revision: 1725713 URL: http://svn.apache.org/viewvc?rev=1725713=rev Log: Merge BCEL changes (none) up to BCEL6 re-packaging Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/ (props changed) Propchange:

svn commit: r1725727 - in /tomcat/trunk: ./ java/org/apache/catalina/startup/ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 14:35:09 2016 New Revision: 1725727 URL: http://svn.apache.org/viewvc?rev=1725727=rev Log: Update Tomcat's internal fork of BCEL to BCEL/trunk Added: tomcat/trunk/java/org/apache/tomcat/util/bcel/Const.java - copied, changed from r1725726,

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2016-01-20 Thread Bill Barker
-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160120.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x

svn commit: r1725731 - in /tomcat/trunk/java/org/apache/tomcat/dbcp/dbcp2: ./ datasources/

2016-01-20 Thread markt
Author: markt Date: Wed Jan 20 14:47:31 2016 New Revision: 1725731 URL: http://svn.apache.org/viewvc?rev=1725731=rev Log: Update Tomcat's fork of DBCP2 to dbcp2/trunk Modified: tomcat/trunk/java/org/apache/tomcat/dbcp/dbcp2/ (props changed)

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2016-01-20 Thread Bill Barker
/dist/bin/commons-daemon-20160120-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160120.jar -Dcommons