Re: svn commit: r1791050 - in /tomcat/trunk/java: javax/el/ javax/security/auth/message/config/ javax/websocket/ javax/websocket/server/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/c

2017-04-12 Thread Konstantin Kolinko
2017-04-12 1:36 GMT+03:00 : > Author: markt > Date: Tue Apr 11 22:36:01 2017 > New Revision: 1791050 > > URL: http://svn.apache.org/viewvc?rev=1791050&view=rev > Log: > Refactoring in preparation for Java 9. Refactor to avoid using some methods > that will be deprecated in Java 9 onwards. > > Mod

Re: svn commit: r1791050 - in /tomcat/trunk/java: javax/el/ javax/security/auth/message/config/ javax/websocket/ javax/websocket/server/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/c

2017-04-12 Thread Mark Thomas
On 12/04/17 09:24, Konstantin Kolinko wrote: > 2017-04-12 1:36 GMT+03:00 : >> Author: markt >> Date: Tue Apr 11 22:36:01 2017 >> New Revision: 1791050 >> >> URL: http://svn.apache.org/viewvc?rev=1791050&view=rev >> Log: >> Refactoring in preparation for Java 9. Refactor to avoid using some methods

svn commit: r1791090 - in /tomcat/trunk: java/javax/el/ java/javax/security/auth/message/config/ java/javax/websocket/ java/javax/websocket/server/ java/org/apache/catalina/authenticator/jaspic/ java/

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 08:39:22 2017 New Revision: 1791090 URL: http://svn.apache.org/viewvc?rev=1791090&view=rev Log: Review of r1791068 by kkolinko Class.getConstructor().newInstance() is a better replacement for Class.newInstance() than Class.getDeclaredConstructor().newInstance() Mod

svn commit: r1791092 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2017-04-12 Thread remm
Author: remm Date: Wed Apr 12 08:45:04 2017 New Revision: 1791092 URL: http://svn.apache.org/viewvc?rev=1791092&view=rev Log: WS Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.j

buildbot failure in on tomcat-trunk

2017-04-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2297 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

buildbot success in on tomcat-trunk

2017-04-12 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2298 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1791095 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/Cipher.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 09:15:46 2017 New Revision: 1791095 URL: http://svn.apache.org/viewvc?rev=1791095&view=rev Log: Align with OpenSSL Master Remove ECDH(E) ciphers from SSLv3 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/Cipher.java Modified: tomcat/trun

svn commit: r1791096 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TestCipher.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 09:22:09 2017 New Revision: 1791096 URL: http://svn.apache.org/viewvc?rev=1791096&view=rev Log: Follow-up to r1791095 Need to update OpenSSL names for ciphers that are not supported by IBM JREs Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphe

svn commit: r1791099 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 09:46:59 2017 New Revision: 1791099 URL: http://svn.apache.org/viewvc?rev=1791099&view=rev Log: Enable tests to pass when running against OpenSSL master and OpenSSL 1.0.2 Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

svn commit: r1791101 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 09:58:12 2017 New Revision: 1791101 URL: http://svn.apache.org/viewvc?rev=1791101&view=rev Log: Need to process renames later, once cipher name has been extracted from OpenSSL output Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/Tester

svn commit: r1791102 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherConfigurationParser.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 10:08:38 2017 New Revision: 1791102 URL: http://svn.apache.org/viewvc?rev=1791102&view=rev Log: Enable tests to pass when running against OpenSSL master and OpenSSL 1.0.2 Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherCo

svn commit: r1791103 - /tomcat/trunk/webapps/docs/changelog.xml

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 10:12:56 2017 New Revision: 1791103 URL: http://svn.apache.org/viewvc?rev=1791103&view=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/

svn commit: r1791104 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/ciphers/ test/org/apache/tomcat/util/net/openssl/ciphers/ webapps/docs/

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 10:13:30 2017 New Revision: 1791104 URL: http://svn.apache.org/viewvc?rev=1791104&view=rev Log: Align with OpenSSL Master Remove ECDH(E) ciphers from SSLv3 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/ne

svn commit: r1791105 - /tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 10:22:14 2017 New Revision: 1791105 URL: http://svn.apache.org/viewvc?rev=1791105&view=rev Log: Fix back-port Modified: tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java Modified: tomcat/tc8.5.x/trunk/test/org/apache/tomc

ServletOutputStream#isReady throws ISE

2017-04-12 Thread Violeta Georgieva
Hi, I have a question about ServletOutputStream#isReady. I have the following scenario: - thread A removes the Read/WriteListeners when async timeout/error happens [1], [2] - before receiving AsyncListener#onTimeout/onError, thread B checks whether it is save to perform write invoking ServletOutp

svn commit: r1791124 - in /tomcat/trunk: java/org/apache/coyote/http2/Http2UpgradeHandler.java test/org/apache/coyote/http2/Http2TestBase.java test/org/apache/coyote/http2/TestHttp2UpgradeHandler.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 14:25:50 2017 New Revision: 1791124 URL: http://svn.apache.org/viewvc?rev=1791124&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60970 Fix infinite loop if application tries to write a large header to the response when using HTTP/2. Added: to

svn commit: r1791125 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Http2UpgradeHandler.java test/org/apache/coyote/http2/Http2TestBase.java test/org/apache/coyote/http2/TestHttp2UpgradeH

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 14:27:29 2017 New Revision: 1791125 URL: http://svn.apache.org/viewvc?rev=1791125&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60970 Fix infinite loop if application tries to write a large header to the response when using HTTP/2. Added: t

[Bug 60970] Endless loop in Http2UpgradeHandler#writeHeaders

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60970 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 60963] Optimize class loading for unpackWARs=false case

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60963 --- Comment #3 from Mark Thomas --- Looking at this is on my TODO list. The main question I have is does it still avoid file locking issues? These will be more obvious Windows (you won't be able to delete the WAR) but they affect all platforms.

buildbot failure in on tomcat-trunk

2017-04-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2304 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

Re: ServletOutputStream#isReady throws ISE

2017-04-12 Thread Mark Thomas
On 12/04/17 12:22, Violeta Georgieva wrote: > Hi, > > I have a question about ServletOutputStream#isReady. > > I have the following scenario: > - thread A removes the Read/WriteListeners when async timeout/error happens > [1], [2] > - before receiving AsyncListener#onTimeout/onError, thread B che

svn commit: r1791129 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2AsyncUpgradeHandler.java Http2UpgradeHandler.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 15:00:09 2017 New Revision: 1791129 URL: http://svn.apache.org/viewvc?rev=1791129&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60970 Nio2 needs separate fix. Optimise Nio/Apr fix a little Modified: tomcat/trunk/java/org/apache/coyote/http2/Ht

svn commit: r1791130 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Http2UpgradeHandler.java

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 15:00:51 2017 New Revision: 1791130 URL: http://svn.apache.org/viewvc?rev=1791130&view=rev Log: Optimise fix a little Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Propchange: to

Re: ServletOutputStream#isReady throws ISE

2017-04-12 Thread Violeta Georgieva
Hi, 2017-04-12 17:44 GMT+03:00 Mark Thomas : > > On 12/04/17 12:22, Violeta Georgieva wrote: > > Hi, > > > > I have a question about ServletOutputStream#isReady. > > > > I have the following scenario: > > - thread A removes the Read/WriteListeners when async timeout/error happens > > [1], [2] > >

buildbot success in on tomcat-trunk

2017-04-12 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2305 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

Re: ServletOutputStream#isReady throws ISE

2017-04-12 Thread Mark Thomas
On 12/04/17 16:05, Violeta Georgieva wrote: > Ok > I'm going to commit a change. If you are quick, it will make it in before I tag 9.0.x and 8.5.x. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additio

svn commit: r1791134 - in /tomcat/trunk: java/org/apache/coyote/Response.java webapps/docs/changelog.xml

2017-04-12 Thread violetagg
Author: violetagg Date: Wed Apr 12 15:34:26 2017 New Revision: 1791134 URL: http://svn.apache.org/viewvc?rev=1791134&view=rev Log: When there is no javax.servlet.WriteListener registered then a call to javax.servlet.ServletOutputStream#isReady will return 'false' instead of throwing IllegalState

Re: svn commit: r1791134 - in /tomcat/trunk: java/org/apache/coyote/Response.java webapps/docs/changelog.xml

2017-04-12 Thread Mark Thomas
On 12/04/17 16:34, violet...@apache.org wrote: > Author: violetagg > Date: Wed Apr 12 15:34:26 2017 > New Revision: 1791134 > > URL: http://svn.apache.org/viewvc?rev=1791134&view=rev > Log: > When there is no javax.servlet.WriteListener registered then a call to > javax.servlet.ServletOutputStrea

svn commit: r1791136 - /tomcat/trunk/webapps/docs/changelog.xml

2017-04-12 Thread violetagg
Author: violetagg Date: Wed Apr 12 15:41:54 2017 New Revision: 1791136 URL: http://svn.apache.org/viewvc?rev=1791136&view=rev Log: Fix typos Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/web

Re: svn commit: r1791134 - in /tomcat/trunk: java/org/apache/coyote/Response.java webapps/docs/changelog.xml

2017-04-12 Thread Violeta Georgieva
2017-04-12 18:36 GMT+03:00 Mark Thomas : > > On 12/04/17 16:34, violet...@apache.org wrote: > > Author: violetagg > > Date: Wed Apr 12 15:34:26 2017 > > New Revision: 1791134 > > > > URL: http://svn.apache.org/viewvc?rev=1791134&view=rev > > Log: > > When there is no javax.servlet.WriteListener reg

[Bug 60769] Problem with Jsp character encoding configuration

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60769 --- Comment #2 from Lazar --- Created attachment 34908 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34908&action=edit A sample reproducing the problem with exotic encoding -- You are receiving this mail because: You are the assignee

svn commit: r1791137 - in /tomcat/trunk: java/org/apache/catalina/connector/InputBuffer.java webapps/docs/changelog.xml

2017-04-12 Thread violetagg
Author: violetagg Date: Wed Apr 12 15:52:06 2017 New Revision: 1791137 URL: http://svn.apache.org/viewvc?rev=1791137&view=rev Log: When there is no javax.servlet.ReadListener registered then a call to javax.servlet.ServletInputStream#isReady will return 'false' instead of throwing IllegalStateEx

Re: svn commit: r1791134 - in /tomcat/trunk: java/org/apache/coyote/Response.java webapps/docs/changelog.xml

2017-04-12 Thread Violeta Georgieva
2017-04-12 18:36 GMT+03:00 Mark Thomas : > > On 12/04/17 16:34, violet...@apache.org wrote: > > Author: violetagg > > Date: Wed Apr 12 15:34:26 2017 > > New Revision: 1791134 > > > > URL: http://svn.apache.org/viewvc?rev=1791134&view=rev > > Log: > > When there is no javax.servlet.WriteListener reg

[Bug 60769] Problem with Jsp character encoding configuration

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60769 --- Comment #3 from Lazar --- Hello Marc, I noticed that the second scenario is still failing if the encoding is more exotic - I tried with IBM871 - IBM EBCDIC (Icelandic). I debugged a little and noticed that EncodingDetector.getPrologEncod

svn commit: r1791138 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/Response.java webapps/docs/changelog.xml

2017-04-12 Thread violetagg
Author: violetagg Date: Wed Apr 12 15:56:23 2017 New Revision: 1791138 URL: http://svn.apache.org/viewvc?rev=1791138&view=rev Log: When there is no javax.servlet.WriteListener registered then a call to javax.servlet.ServletOutputStream#isReady will return 'false' instead of throwing IllegalState

svn commit: r1791139 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/InputBuffer.java webapps/docs/changelog.xml

2017-04-12 Thread violetagg
Author: violetagg Date: Wed Apr 12 16:02:39 2017 New Revision: 1791139 URL: http://svn.apache.org/viewvc?rev=1791139&view=rev Log: When there is no javax.servlet.ReadListener registered then a call to javax.servlet.ServletInputStream#isReady will return 'false' instead of throwing IllegalStateEx

Re: ServletOutputStream#isReady throws ISE

2017-04-12 Thread Violeta Georgieva
2017-04-12 18:34 GMT+03:00 Mark Thomas : > > On 12/04/17 16:05, Violeta Georgieva wrote: > > > > > Ok > > I'm going to commit a change. > > If you are quick, it will make it in before I tag 9.0.x and 8.5.x. > I committed the changes. Thanks, Violeta > Mark > > >

[Bug 57830] Add support for ProxyProtocol

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830 --- Comment #18 from Christopher Schultz --- The PROXY protocol should be "easy" to roll into an existing class: just have a look at the first few bytes of a request to see if it's got a valid "PROXY" command in there. If so, validate the sourc

svn commit: r1791176 - in /tomcat/tags/TOMCAT_9_0_0_M20: ./ build.properties.default webapps/docs/changelog.xml

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 19:17:46 2017 New Revision: 1791176 URL: http://svn.apache.org/viewvc?rev=1791176&view=rev Log: Tag 9.0.0.M20 Added: tomcat/tags/TOMCAT_9_0_0_M20/ - copied from r1791174, tomcat/trunk/ Modified: tomcat/tags/TOMCAT_9_0_0_M20/build.properties.default

svn commit: r19128 - in /dev/tomcat/tomcat-9/v9.0.0.M20: ./ bin/ bin/embed/ bin/extras/ src/

2017-04-12 Thread markt
Author: markt Date: Wed Apr 12 19:50:52 2017 New Revision: 19128 Log: Upload 9.0.0.M20 for voting Added: dev/tomcat/tomcat-9/v9.0.0.M20/ dev/tomcat/tomcat-9/v9.0.0.M20/KEYS dev/tomcat/tomcat-9/v9.0.0.M20/README.html dev/tomcat/tomcat-9/v9.0.0.M20/RELEASE-NOTES dev/tomcat/tomca

[ANN] TomcatCon prices rise after April 16th

2017-04-12 Thread Mark Thomas
All, If you haven't already got your ticket to join us at TomcatCon in Miami, now is a great time to get it before prices rise on 17th April. The schedule can be found at: https://apachecon2017.sched.com/overview/type/TomcatCon and registration is open at: http://events.linuxfoundation.org/eve

[VOTE] Release Apache Tomcat 9.0.0.M20

2017-04-12 Thread Mark Thomas
The proposed Apache Tomcat 9.0.0.M20 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes com

[Bug 60963] Optimize class loading for unpackWARs=false case

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60963 --- Comment #4 from Christopher Schultz --- It looks like isInWAR in getJarInputStreamWrapper can be leaked. Will calling getWebResourceSet().closeJarFile undo this performance optimization? For ZipInputStreamWithPosition constructor, should

[Bug 53138] Not able to download a file size of 740KB using NIO connector in tomcat version 7.0.27. But with the same configuration I was able to download that in tomcat 7.0.26.

2017-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=53138 Christopher Schultz changed: What|Removed |Added Summary|Not able to download a file |Not able to download a file