[Bug 57767] Websocket client proprietary configuration

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Remy Maucherat changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1812172 - /tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java

2017-10-13 Thread remm
Author: remm Date: Sat Oct 14 06:23:35 2017 New Revision: 1812172 URL: http://svn.apache.org/viewvc?rev=1812172&view=rev Log: Fix test cases for Tomcat 7 API. Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java Modified: tomcat/tc7.0.x/trunk/test/o

buildbot failure in on tomcat-7-trunk

2017-10-13 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/916 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1812171 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-10-13 Thread remm
Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java?rev=1812171&r1=1812170&r2=1812171&view=diff =

svn commit: r1812171 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-10-13 Thread remm
Author: remm Date: Sat Oct 14 05:51:02 2017 New Revision: 1812171 URL: http://svn.apache.org/viewvc?rev=1812171&view=rev Log: 57767: Add support for authentication to the websocket client. Patch submitted by J Fernandez. Added: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/Authentic

Re: [Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread Mark Thomas
On 13/10/17 20:44, Igal @ Lucee.org wrote: > Can anyone ban this idiot from BZ/mailing-lists/etc.? Account locked in Bugzilla. The issue containing the failed attempt to deface Bugzilla has been deleted. I didn't bother adding the address to the ASF block list as they aren't subscribed to any ma

[Bug 61614] The request object has been recycled and is no longer associated with this facade] with root

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61614 --- Comment #2 from Chuck Caldarale --- Also, consider moving up to the current version of 9.0. The one you specified is almost a year and a half old. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61614] The request object has been recycled and is no longer associated with this facade] with root

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61614 Christopher Schultz changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 60195] No javadoc in Maven Central

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60195 Тарас changed: What|Removed |Added OS|All |Windows XP Hardware|PC

Re: [Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread Igal @ Lucee.org
Can anyone ban this idiot from BZ/mailing-lists/etc.? Igal Sapir Lucee Core Developer Lucee.org

[Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 --- Comment #3 from Azizul --- Comment on attachment 35420 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35420 Deface > > > > > > > > > > > > > > >

[Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 Azizul changed: What|Removed |Added Attachment #35419|0 |1 is obsolete|

[Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 Coty Sutherland changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 --- Comment #1 from Azizul --- Created attachment 35419 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35419&action=edit Deface -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 Azizul changed: What|Removed |Added CC||azizulhakim...@gmail.com -- You are receivin

[Bug 61615] Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 Azizul changed: What|Removed |Added Alias||Web -- You are receiving this mail because:

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-10-13 Thread Bill Barker
mmons/beanutils/dist/commons-beanutils-20171013.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g ump/public/work

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2017-10-13 Thread Bill Barker
space/apache-commons/beanutils/dist/commons-beanutils-20171013.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2017-10-13 Thread Bill Barker
space/apache-commons/beanutils/dist/commons-beanutils-20171013.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g

[Bug 61615] New: Haked mr.B45T4RD

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61615 Bug ID: 61615 Summary: Haked mr.B45T4RD Product: Tomcat Modules Version: unspecified Hardware: HP OS: Linux Status: NEW Severity: normal Prior

[Bug 61614] New: The request object has been recycled and is no longer associated with this facade] with root

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61614 Bug ID: 61614 Summary: The request object has been recycled and is no longer associated with this facade] with root Product: Tomcat 9 Version: 9.0.0.M6 Hardware: Other

[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171

2017-10-13 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/63 Great, I will implement as advised on BZ. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: Hello everyone!

2017-10-13 Thread Mark Thomas
On 13/10/2017 16:02, Kapil Kumar wrote: > Hello everyone, > > Hope you find this well. > > My name is Kapil Kumar and I joined the mailing list today. > > I work as an Oracle DBA professionally and I really appreciate the efforts > of the apache community. > > Mark helped me getting subscribed

svn commit: r1812154 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 17:22:07 2017 New Revision: 1812154 URL: http://svn.apache.org/viewvc?rev=1812154&view=rev Log: Fix remaining SpotBugs failures in the jdbc-pool code when the rank is set to 16 (the maximum rank is 20 so there are still quite a few other issues to look at) Modified:

svn commit: r1812151 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java test/org/apache/catalina/startup/SimpleHttpClient.java tes

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 16:50:39 2017 New Revision: 1812151 URL: http://svn.apache.org/viewvc?rev=1812151&view=rev Log: Fix remaining SpotBugs failures in the test code when the rank is set to 16 (the maximum rank is 20 so there are still quite a few other issues to look at) Modified:

svn commit: r1812150 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 16:30:39 2017 New Revision: 1812150 URL: http://svn.apache.org/viewvc?rev=1812150&view=rev Log: 57767: Add support for authentication to the websocket client. Patch submitted by J Fernandez. Added: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/Authentic

svn commit: r1812145 - /tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/BasicAuthenticator.java

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 15:44:43 2017 New Revision: 1812145 URL: http://svn.apache.org/viewvc?rev=1812145&view=rev Log: Fix compilation of BasicAuthenticator. Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/BasicAuthenticator.java Modified: tomcat/tc8.5.x/trunk/java/o

svn commit: r1812143 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 15:27:32 2017 New Revision: 1812143 URL: http://svn.apache.org/viewvc?rev=1812143&view=rev Log: 57767: Add support for authentication to the websocket client. Patch submitted by J Fernandez. Added: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/Authentic

svn commit: r1812142 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsWebSocketContainer.java

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 15:25:23 2017 New Revision: 1812142 URL: http://svn.apache.org/viewvc?rev=1812142&view=rev Log: Fix the merge mess caused by me cut&pasting the client code back to the container class. Noticed while porting to 8.5. Also fix the i18n property names. Modified: tom

[GitHub] tomcat issue #77: Removed findbugs bad practice warnings by making classes f...

2017-10-13 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/77 I actually started with using super.clone() but upon further research opted for marking the classes as `final`. All the "best practices" advocates say to avoid using the faulty clone() method as descr

[GitHub] tomcat issue #76: added SessionInitializerFilter

2017-10-13 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/76 Sure, I will add the documentation. Thanks :) --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additiona

svn commit: r1812139 - in /tomcat/trunk/test/org/apache: catalina/valves/ coyote/http11/upgrade/ jasper/ tomcat/util/net/

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 15:04:47 2017 New Revision: 1812139 URL: http://svn.apache.org/viewvc?rev=1812139&view=rev Log: Fix some SpotBugs false positives Modified: tomcat/trunk/test/org/apache/catalina/valves/TestLoadBalancerDrainingValve.java tomcat/trunk/test/org/apache/coyote/h

Hello everyone!

2017-10-13 Thread Kapil Kumar
Hello everyone, Hope you find this well. My name is Kapil Kumar and I joined the mailing list today. I work as an Oracle DBA professionally and I really appreciate the efforts of the apache community. Mark helped me getting subscribed and I am thankful for that but I would really ap

svn commit: r1812136 - in /tomcat/trunk/java/org/apache/tomcat/websocket: DigestAuthenticator.java WsWebSocketContainer.java

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 14:42:19 2017 New Revision: 1812136 URL: http://svn.apache.org/viewvc?rev=1812136&view=rev Log: Fix IDE nags Modified: tomcat/trunk/java/org/apache/tomcat/websocket/DigestAuthenticator.java tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.j

[Bug 57767] Websocket client proprietary configuration

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #23 from Remy Maucherat --- I prefer getting rid of the field instead, the GC savings are minimal and not worth it IMO. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1812135 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 14:18:37 2017 New Revision: 1812135 URL: http://svn.apache.org/viewvc?rev=1812135&view=rev Log: Follow up to fix bad interaction with the recursive algorithm. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/tru

svn commit: r1812134 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 14:14:22 2017 New Revision: 1812134 URL: http://svn.apache.org/viewvc?rev=1812134&view=rev Log: Remove redirectSet field to avoid thread safety problems. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/trunk/ja

[Bug 57767] Websocket client proprietary configuration

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #22 from Remy Maucherat --- Yes, that would be a big problem with my "simplification" then. Ooops. I will restore the separate client class, it's a good solution for the issue. -- You are receiving this mail because: You are the a

[Bug 57767] Websocket client proprietary configuration

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #21 from Mark Thomas --- Wasn't the point of the new class that the redirectSet wasn't thread safe? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57767] Websocket client proprietary configuration

2017-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #20 from Remy Maucherat --- I committed the patch to trunk, with a few changes: - Adding javadocs - Merged all client code back to WsWebSocketContainer (the new client class was taking over nearly all its code so I didn't really see

svn commit: r1812129 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ webapps/docs/

2017-10-13 Thread remm
Author: remm Date: Fri Oct 13 13:42:25 2017 New Revision: 1812129 URL: http://svn.apache.org/viewvc?rev=1812129&view=rev Log: 57767: Add support for authentication to the websocket client. Patch submitted by J Fernandez. Added: tomcat/trunk/java/org/apache/tomcat/websocket/AuthenticationExce

[GitHub] tomcat issue #73: Bug 57767 - Websocket client proprietary configuration

2017-10-13 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/73 No objections to back-porting here. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-ma

svn commit: r1812119 - in /tomcat/trunk/test/org/apache/catalina: authenticator/jaspic/ connector/ core/ loader/ startup/

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 12:01:23 2017 New Revision: 1812119 URL: http://svn.apache.org/viewvc?rev=1812119&view=rev Log: Fix some FindBugs warnings in the test cases Modified: tomcat/trunk/test/org/apache/catalina/authenticator/jaspic/TestPersistentProviderRegistrations.java tomcat

buildbot success in on tomcat-trunk

2017-10-13 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2764 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

[GitHub] tomcat issue #73: Bug 57767 - Websocket client proprietary configuration

2017-10-13 Thread rmaucher
Github user rmaucher commented on the issue: https://github.com/apache/tomcat/pull/73 Well, it looks ok to me overall, so I'll add a bit of javadoc and merge it. Any issue with backporting it ? --- - To unsubscribe,

svn commit: r1812113 - /tomcat/trunk/java/org/apache/tomcat/util/compat/JreCompat.java

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 11:40:48 2017 New Revision: 1812113 URL: http://svn.apache.org/viewvc?rev=1812113&view=rev Log: Fix Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/util/compat/JreCompat.java Modified: tomcat/trunk/java/org/apache/tomcat/util/compat/JreCompat.java URL: h

svn commit: r1812107 - /tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 10:38:00 2017 New Revision: 1812107 URL: http://svn.apache.org/viewvc?rev=1812107&view=rev Log: multiRelease needs to be volatile for DCL to work correctly (thanks SpotBugs) Modified: tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResou

buildbot failure in on tomcat-trunk

2017-10-13 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2762 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1812103 - in /tomcat/trunk: java/org/apache/catalina/webresources/ java/org/apache/tomcat/util/compat/ java/org/apache/tomcat/util/scan/ test/org/apache/catalina/webresources/

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 10:10:33 2017 New Revision: 1812103 URL: http://svn.apache.org/viewvc?rev=1812103&view=rev Log: Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=61601 Handle multi-release JARs for unpacked web applications Modified: tomcat/trunk/java/org/apache/c

svn commit: r1812098 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/changelog.xml

2017-10-13 Thread rjung
Author: rjung Date: Fri Oct 13 09:40:27 2017 New Revision: 1812098 URL: http://svn.apache.org/viewvc?rev=1812098&view=rev Log: Fix JMX descriptor for Wrapper.findInitParameter(). Extended backport of r1812092 from trunk and r1812093 from TC 8.5.x. Backport of r1812096 from TC 8.0.x. Modified:

svn commit: r1812096 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/changelog.xml

2017-10-13 Thread rjung
Author: rjung Date: Fri Oct 13 09:37:41 2017 New Revision: 1812096 URL: http://svn.apache.org/viewvc?rev=1812096&view=rev Log: Fix JMX descriptor for Wrapper.findInitParameter(). Extended backport of r1812092 from trunk and r1812093 from TC 8.5.x. Modified: tomcat/tc8.0.x/trunk/ (props cha

svn commit: r1812095 - in /tomcat/tc8.5.x/trunk: ./ res/findbugs/filter-false-positives.xml

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:31:10 2017 New Revision: 1812095 URL: http://svn.apache.org/viewvc?rev=1812095&view=rev Log: Fix additional false positives exposed by previous fixes for typos Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/res/findbugs/filter-fals

svn commit: r1812094 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:30:25 2017 New Revision: 1812094 URL: http://svn.apache.org/viewvc?rev=1812094&view=rev Log: Fix additional false positives exposed by previous fixes for typos Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs

svn commit: r1812093 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/mbeans-descriptors.xml

2017-10-13 Thread rjung
Author: rjung Date: Fri Oct 13 09:30:03 2017 New Revision: 1812093 URL: http://svn.apache.org/viewvc?rev=1812093&view=rev Log: Fix trivial copy and paste error in JMX operation description for Wrapper.findInitParameter(). Backport of r1812092 from trunk. Modified: tomcat/tc8.5.x/trunk/ (pr

svn commit: r1812092 - /tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml

2017-10-13 Thread rjung
Author: rjung Date: Fri Oct 13 09:27:55 2017 New Revision: 1812092 URL: http://svn.apache.org/viewvc?rev=1812092&view=rev Log: Fix trivial copy and paste error in JMX operation description for Wrapper.findInitParameter(). Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors

[GitHub] tomcat issue #78: added findbugs false positive

2017-10-13 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/78 Thanks. Patch applied to trunk and back-ported to 8.5.x, 8.0.x and 7.0.x. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.ap

[GitHub] tomcat pull request #78: added findbugs false positive

2017-10-13 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/78 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1812091 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/ha/deploy/FileMessageFactory.java res/findbugs/filter-false-positives.

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:16:58 2017 New Revision: 1812091 URL: http://svn.apache.org/viewvc?rev=1812091&view=rev Log: Fix some FindBugs false positives Patch provided by isapir Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters

svn commit: r1812090 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/ha/deploy/FileMessageFactory.java res/findbugs/filter-false-positives.

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:15:31 2017 New Revision: 1812090 URL: http://svn.apache.org/viewvc?rev=1812090&view=rev Log: Fix some FindBugs false positives Patch provided by isapir Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/filters

svn commit: r1812089 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/ha/deploy/FileMessageFactory.java res/findbugs/filter-false-positives.

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:14:03 2017 New Revision: 1812089 URL: http://svn.apache.org/viewvc?rev=1812089&view=rev Log: Fix some FindBugs false positives Patch provided by isapir Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/filters

svn commit: r1812088 - in /tomcat/trunk: java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/ha/deploy/FileMessageFactory.java res/findbugs/filter-false-positives.xml

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:11:52 2017 New Revision: 1812088 URL: http://svn.apache.org/viewvc?rev=1812088&view=rev Log: Fix some FindBugs false positives Patch provided by isapir Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java tomcat/trunk/java/org/apach

svn commit: r1812087 - /tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java

2017-10-13 Thread markt
Author: markt Date: Fri Oct 13 09:11:47 2017 New Revision: 1812087 URL: http://svn.apache.org/viewvc?rev=1812087&view=rev Log: Fix SpotBugs warning Better null handling Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/

[GitHub] tomcat issue #77: Removed findbugs bad practice warnings by making classes f...

2017-10-13 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/77 Making those classes final will cause problems if users have extended any of them. While that seems unlikely, experience suggests it has probably been done somewhere. Is there any reason super.clon

[GitHub] tomcat issue #76: added SessionInitializerFilter

2017-10-13 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/76 I did wonder if this would be better as configuration on WsFilter but on reflection a separate Filter looks to be simpler for users to configure. The patch needs documentation (webapps/docs/

[GitHub] tomcat issue #73: Bug 57767 - Websocket client proprietary configuration

2017-10-13 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/73 Chris's original concern with the BZ 57767 patch (lack of Javadoc) still needs to be addressed. --- - To unsubscribe, e-mail: de

[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171

2017-10-13 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/63 I've added some comments to the bugzilla issue on how this might be addressed. --- - To unsubscribe, e-mail: dev-unsubscr...@tom

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2017-10-13 Thread Bill Barker
space/apache-commons/beanutils/dist/commons-beanutils-20171013.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-10-13 Thread Bill Barker
mmons/beanutils/dist/commons-beanutils-20171013.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g ump/public/work

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2017-10-13 Thread Bill Barker
space/apache-commons/beanutils/dist/commons-beanutils-20171013.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g