Re: [Git migration] trunk or master

2018-01-08 Thread Violeta Georgieva
Hi, 2018-01-09 9:06 GMT+02:00 Martin Grigorov : > > Hi, > > On Jan 8, 2018 15:33, "Mark Thomas" wrote: > > This is the third of the per issue e-mails to discuss the issues > associated with migrating from svn to git. > > The standard name for the main

Re: [Git migration] trunk or master

2018-01-08 Thread Martin Grigorov
Hi, On Jan 8, 2018 15:33, "Mark Thomas" wrote: This is the third of the per issue e-mails to discuss the issues associated with migrating from svn to git. The standard name for the main branch where development takes place in svn is 'trunk'. In git the standard name is

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-01-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.

[Bug 61977] New: JNDIRealm with SPNEGO, GSSAPI and SRV record fails to find LDAP SPN due to training sname period

2018-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61977 Bug ID: 61977 Summary: JNDIRealm with SPNEGO, GSSAPI and SRV record fails to find LDAP SPN due to training sname period Product: Tomcat 8 Version: 8.5.20 Hardware: PC

Re: [Git Migration] Review board

2018-01-08 Thread Mark Thomas
On 08/01/18 16:14, Christopher Schultz wrote: > Mark, > > On 1/4/18 5:29 AM, Mark Thomas wrote: >> Happy New Year all! > >> This is the first of the per issue e-mails to discuss the issues >> associated with migrating from svn to git. > >> Some years ago we looked at using review board. It

Re: [Git Migration] Review board

2018-01-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/4/18 5:29 AM, Mark Thomas wrote: > Happy New Year all! > > This is the first of the per issue e-mails to discuss the issues > associated with migrating from svn to git. > > Some years ago we looked at using review board. It didn't

svn commit: r1820576 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2018-01-08 Thread markt
Author: markt Date: Mon Jan 8 15:52:15 2018 New Revision: 1820576 URL: http://svn.apache.org/viewvc?rev=1820576=rev Log: When using WebDAV to copy a file resource to a destination that requires a collection to be overwritten, ensure that the operation succeeds rather than fails (with a 500

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2018-01-08 Thread ChristopherSchultz
Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/96 WRT WebDav, [RFC2618](https://tools.ietf.org/html/rfc2518) says that WebDav is an extension to HTTP/1.1 so I think we are always okay using 405 from `WebDavServlet`. We should, however,

[Bug 61886] 7.0.83 Calling [asyncComplete()] is not valid for a request with Async state [MUST_COMPLETE]

2018-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61886 --- Comment #9 from Konstantin Kolinko --- (In reply to Konstantin Kolinko from comment #8) > Testing current Tomcat 8.5-dev @r1820546 That ConcurrentModificationException was when running with Java 7u80. With Java

Re: [Git migration] trunk or master

2018-01-08 Thread Leon Rosenberg
I think the standard name for the main branch where development takes place in git is 'develop'. Master contains the last released version and is used to branch from for patches etc. At least with branch-based development models like gitflow or githubflow. regards Leon On Mon, Jan 8, 2018 at

[Git migration] trunk or master

2018-01-08 Thread Mark Thomas
This is the third of the per issue e-mails to discuss the issues associated with migrating from svn to git. The standard name for the main branch where development takes place in svn is 'trunk'. In git the standard name is 'master'. We can use either of these going forwards. Or something

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2018-01-08 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/96 No argument with Konstantin's points here. I started to look at implementing this and I realised that the WebDAV is inconsistent with how the allow header is generated. A method may not be included

[Bug 61886] 7.0.83 Calling [asyncComplete()] is not valid for a request with Async state [MUST_COMPLETE]

2018-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61886 --- Comment #8 from Konstantin Kolinko --- Testing current Tomcat 8.5-dev @r1820546 A ConcurrentModificationException is printed on the console, but not in the logs. Nothing interesting in the logs. Not attaching them

[Bug 61886] 7.0.83 Calling [asyncComplete()] is not valid for a request with Async state [MUST_COMPLETE]

2018-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61886 --- Comment #7 from Konstantin Kolinko --- Created attachment 35659 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35659=edit catalina.2018-01-08.log.txt Testing current Tomcat 9.0-dev @r1820558. Generally -

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2018-01-08 Thread kkolinko
Github user kkolinko commented on the issue: https://github.com/apache/tomcat/pull/96 1) POST fallsback to GET, I think since RFC1945 (HTTP/1.0). Both HEAD and POST were improvements over single GET method supported by original HTTP protocol (0.9). 2) DefaultServlet can be used

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2018-01-08 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/96 Lack of response == lazy consensus. I plan to look at applying these patches (or possibly a variation of them) before tagging 9.0.x. ---

svn commit: r1820552 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ java/org/apache/tomcat/util/net/openssl/ we

2018-01-08 Thread markt
Author: markt Date: Mon Jan 8 11:44:24 2018 New Revision: 1820552 URL: http://svn.apache.org/viewvc?rev=1820552=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61566 Expose the currently in use certificate chain and list of trusted certificates for all virtual hosts configured using

svn commit: r1820551 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLContext.java java/org/apache/tomcat/util/net/openssl/OpenSSLSessionContext.java

2018-01-08 Thread markt
Author: markt Date: Mon Jan 8 11:31:12 2018 New Revision: 1820551 URL: http://svn.apache.org/viewvc?rev=1820551=rev Log: Refactor the OpenSSLContext implementation so that a reference is retained to the instance while a request that is using it is in progress. This allows destruction to be

[Bug 47214] Inner classes that are explicitly referenced - should not be anonymous

2018-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=47214 Konstantin Kolinko changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1820550 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/security/SecurityClassLoad.java java/org/apache/jasper/security/SecurityClassLoad.java webapps/docs/changelog.xml

2018-01-08 Thread kkolinko
Author: kkolinko Date: Mon Jan 8 11:00:17 2018 New Revision: 1820550 URL: http://svn.apache.org/viewvc?rev=1820550=rev Log: Use a loop to preload anonymous inner classes, to be safe for future changes in the code or using a different compiler..

svn commit: r1820548 - in /tomcat/tc8.0.x/trunk/java/org/apache: catalina/security/SecurityClassLoad.java jasper/security/SecurityClassLoad.java

2018-01-08 Thread kkolinko
Author: kkolinko Date: Mon Jan 8 10:55:06 2018 New Revision: 1820548 URL: http://svn.apache.org/viewvc?rev=1820548=rev Log: Done auto-formatting. No functional change. Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

svn commit: r1820546 - in /tomcat/tc8.5.x/trunk: java/org/apache/catalina/security/SecurityClassLoad.java java/org/apache/jasper/security/SecurityClassLoad.java webapps/docs/changelog.xml

2018-01-08 Thread kkolinko
Author: kkolinko Date: Mon Jan 8 10:42:12 2018 New Revision: 1820546 URL: http://svn.apache.org/viewvc?rev=1820546=rev Log: Use a loop to preload anonymous inner classes, to be safe for future changes in the code or using a different compiler..

svn commit: r1820544 - in /tomcat/tc8.5.x/trunk/java/org/apache: catalina/security/SecurityClassLoad.java jasper/security/SecurityClassLoad.java

2018-01-08 Thread kkolinko
Author: kkolinko Date: Mon Jan 8 10:34:14 2018 New Revision: 1820544 URL: http://svn.apache.org/viewvc?rev=1820544=rev Log: Done auto-formatting. No functional change. Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

svn commit: r1820543 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

2018-01-08 Thread kkolinko
Author: kkolinko Date: Mon Jan 8 10:23:37 2018 New Revision: 1820543 URL: http://svn.apache.org/viewvc?rev=1820543=rev Log: Followup to r1817901 (BZ 47214) Remove explicit loading of classes that are already leaded by loadAnonymousInnerClasses() call. Modified:

[Bug 61312] NullPointerException in StatementCache.isCached

2018-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61312 changjun changed: What|Removed |Added OS||All --- Comment #1 from

Re: Tagging 9.0.x and 8.5.x

2018-01-08 Thread Mark Thomas
On 08/01/18 09:31, Konstantin Kolinko wrote: > 2018-01-04 23:42 GMT+03:00 Mark Thomas : >> Hi all, >> >> It is the start of a new month and the open issue list looks to be clear >> so I'm planning on tagging 9.0.x and 8.5.x early next week. > > Is there a need for a new

Re: Tagging 9.0.x and 8.5.x

2018-01-08 Thread Konstantin Kolinko
2018-01-04 23:42 GMT+03:00 Mark Thomas : > Hi all, > > It is the start of a new month and the open issue list looks to be clear > so I'm planning on tagging 9.0.x and 8.5.x early next week. Is there a need for a new Tomcat-Native build for Windows, to update to OpenSSL 1.0.2n