[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio2 (in module tomcat-8.5.x) failed

2018-10-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-nio2 has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio (in module tomcat-8.5.x) failed

2018-10-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-nio has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-10-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.

[GUMP@vmgump-vm3]: Project tomcat-native-1.2-1.1.1-configure (in module tomcat-native-1.2-1.1.1) failed

2018-10-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-1.2-1.1.1-configure has an issue affecting its community

Re: Refactoring and Cleanup of OS Name property usage

2018-10-02 Thread Igal Sapir
Regarding this: On 10/2/2018 3:54 PM, Igal Sapir wrote: Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAME, as well as IS_LINUX and IS_MACOS, and use these fields instead of calling

[Bug 62797] Client aborts are being written as 500 instead of 200

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62797 gr...@bluenile.com changed: What|Removed |Added CC||gr...@bluenile.com -- You are

Refactoring and Cleanup of OS Name property usage

2018-10-02 Thread Igal Sapir
Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAME, as well as IS_LINUX and IS_MACOS, and use these fields instead of calling System.getProperty("os.name") in multiple places - some

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-02 Thread Igal Sapir
Rainer, On 10/2/2018 3:03 PM, Igal Sapir wrote: Hi Rainer, On 10/2/2018 2:54 PM, Rainer Jung wrote: Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct  2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed

svn commit: r1842664 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coyote/

2018-10-02 Thread isapir
Author: isapir Date: Tue Oct 2 22:25:37 2018 New Revision: 1842664 URL: http://svn.apache.org/viewvc?rev=1842664=rev Log: Refactored r1842657 to use o.a.t.util.compat.JrePlatform per feedback Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

[Bug 62797] New: Client aborts are being written as 500 instead of 200

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62797 Bug ID: 62797 Summary: Client aborts are being written as 500 instead of 200 Product: Tomcat 9 Version: 9.0.10 Hardware: PC OS: Linux Status: NEW

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-02 Thread Igal Sapir
Hi Rainer, On 10/2/2018 2:54 PM, Rainer Jung wrote: Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct  2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path case

svn commit: r1842660 - /tomcat/tc8.5.x/trunk/test/org/apache/coyote/http2/Http2TestBase.java

2018-10-02 Thread rjung
Author: rjung Date: Tue Oct 2 21:57:35 2018 New Revision: 1842660 URL: http://svn.apache.org/viewvc?rev=1842660=rev Log: Fix typo in message. Backport of r1842659 from trunk. Modified: tomcat/tc8.5.x/trunk/test/org/apache/coyote/http2/Http2TestBase.java Modified:

svn commit: r1842659 - /tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java

2018-10-02 Thread rjung
Author: rjung Date: Tue Oct 2 21:56:26 2018 New Revision: 1842659 URL: http://svn.apache.org/viewvc?rev=1842659=rev Log: Fix typo in message. Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java URL:

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-02 Thread Rainer Jung
Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct 2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path case sentsitivity on Windows ... Modified:

svn commit: r1842658 - /tomcat/trunk/webapps/docs/config/http.xml

2018-10-02 Thread rjung
Author: rjung Date: Tue Oct 2 21:50:00 2018 New Revision: 1842658 URL: http://svn.apache.org/viewvc?rev=1842658=rev Log: Add TLSv1.3 for JSSE to SSLHostConfig docs. Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL:

Re: svn commit: r1842656 - in /tomcat/trunk: java/org/apache/tomcat/util/compat/TLS.java java/org/apache/tomcat/util/net/SSLHostConfig.java webapps/docs/changelog.xml

2018-10-02 Thread Rainer Jung
Some remarks for this: Am 02.10.2018 um 23:34 schrieb rj...@apache.org: Author: rjung Date: Tue Oct 2 21:34:11 2018 New Revision: 1842656 URL: http://svn.apache.org/viewvc?rev=1842656=rev Log: Add TLSv1.3 to the default protocols and to the "all" alias for JSSE based TLS connectors when

svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coyote/

2018-10-02 Thread isapir
Author: isapir Date: Tue Oct 2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path case sentsitivity on Windows e.g. Testcase: testNestedJarGetURL took 2.628 sec FAILED expected: but was:

svn commit: r1842656 - in /tomcat/trunk: java/org/apache/tomcat/util/compat/TLS.java java/org/apache/tomcat/util/net/SSLHostConfig.java webapps/docs/changelog.xml

2018-10-02 Thread rjung
Author: rjung Date: Tue Oct 2 21:34:11 2018 New Revision: 1842656 URL: http://svn.apache.org/viewvc?rev=1842656=rev Log: Add TLSv1.3 to the default protocols and to the "all" alias for JSSE based TLS connectors when running on a JVM that supports TLS version 1.3. One such JVM is OpenJDK version

[GitHub] tomcat pull request #123: Checking the signing service response

2018-10-02 Thread adriannistor
GitHub user adriannistor opened a pull request: https://github.com/apache/tomcat/pull/123 Checking the signing service response The code at lines

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 --- Comment #8 from Jordi Llach --- Cool, I'll review it and test it tomorrow -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 --- Comment #7 from Mark Thomas --- Created attachment 36186 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36186=edit Alternative patch Thanks for the additional explanation. I agree with all of it. I had similar concerns when I was

[Bug 62792] Race condition NullpointerException in JspServletWrapper

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62792 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Mark Thomas changed: What|Removed |Added CC||jul...@beti.name --- Comment #6 from

Re: SSL Unit Tests Failing

2018-10-02 Thread Igal Sapir
Mark / Chris, On 10/2/2018 6:36 AM, Mark Thomas wrote: On 02/10/18 06:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2]

Re: SSL Unit Tests Failing

2018-10-02 Thread Igal Sapir
Chris, On 10/2/2018 7:25 AM, Christopher Schultz wrote: On 10/2/18 01:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2]

[Bug 62791] SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler."

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62791 --- Comment #5 from Mark Thomas --- I agree the check is pointless for the reasons outlined in comment #3. Having looked at the openjdk source I think there is a lot of scope to clean this up. The TLS spec specifies a maximum of 2^14. Java

[Bug 62791] SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler."

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62791 --- Comment #4 from Mark Thomas --- I am currently looking at the openjdk sources to see what circumstances, if any, a resize would be required. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62791] SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler."

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62791 --- Comment #3 from Remy Maucherat --- Either way the check is pointless, removing it means it will cause an IOE later only if a resize is (somehow) needed. The scenario is handled well in the code. -- You are receiving this mail because:

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #12 from Azat --- after disabling http2 on tomcat9 firefox beta returns its usual secure connection failed just like patched tomcat 7 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62791] SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler."

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62791 --- Comment #2 from Mark Thomas --- I'll do some svn archaeology to see if I can find out why that check was added in the first place and if that reason is still valid. -- You are receiving this mail because: You are the assignee for the

[Bug 62739] Tomcat should allow blank Host header

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 --- Comment #5 from Mark Thomas --- OK. The other open issues are looking to be trickier than expected so we have a little more time than I first thought. I'll leave this until last to give you as much time as possible. -- You are receiving

Re: Bug 62140 implementation question

2018-10-02 Thread Marek Czernek
Well, I personally would prefer if it was  a soure-able (or call-able for windows) script; otherwise, you'd have to parse the text file to check which part of the text you want to output, since you don't want to output all the text at once, but only for one particular verb. Any particular

Re: Bug 62140 implementation question

2018-10-02 Thread Mitch Claborn
Are the available verbs the same for both .sh and .bat? If so, perhaps a text file that contains the actual help text that could be output from both .bat and .sh. Mitch On 10/01/2018 02:48 PM, Marek Czernek wrote: Hi there, I'd like to resolve Bug 62140 [0]. I just wanted to gather some

SSL Unit Tests Failing

2018-10-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 10/2/18 01:58, Igal Sapir wrote: > When trying to run the unit test cases with `ant clean test` on the > current trunk [1] I am getting two (per connector) failures: > > org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2] >

[Bug 62794] New: Tomcat request-read fails when using TLSv1.3 with APR connector

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62794 Bug ID: 62794 Summary: Tomcat request-read fails when using TLSv1.3 with APR connector Product: Tomcat 9 Version: unspecified Hardware: PC OS: Mac OS X

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #11 from Azat --- Created attachment 36184 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36184=edit screenshots from latest mozilla beta build with an error on tomcat 9 mozilla beta with patched tomcat 9 -- You are

Re: SSL Unit Tests Failing

2018-10-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 10/2/18 01:58, Igal Sapir wrote: > When trying to run the unit test cases with `ant clean test` on the > current trunk [1] I am getting two (per connector) failures: > > org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2] >

Re: Gump, Tomcat Native, OpenSSL and Tomcat versions

2018-10-02 Thread Mark Thomas
On 12/09/18 17:22, Mark Thomas wrote: > On 12/09/18 15:57, Rainer Jung wrote: >> Am 12.09.2018 um 13:12 schrieb Mark Thomas: >>> As a starting point for discussion how about: >>> - Build all current OpenSSL versions (currently 4) >>> - Build Tomcat Native 1.2.x for each OpenSSL version (i.e. 4)

[Bug 62791] SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler."

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62791 --- Comment #1 from Remy Maucherat --- I couldn't figure out why it was such a drama to not use the container buffer for NIO SSL (except: no resize ...), so I didn't put it in NIO2, that's why it works. The code path clearly uses the

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #10 from Azat --- I did apply the same patches to tomcat 9 src and tomcat native src still no luck pretty much the same results ssllabs, htbridge ok ,chrome beta fails with ERR_CONNECTION_CLOSED, firefox beta doesn't show

[Bug 62761] CORS filter example in docs not working in versions since 9.0.9

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62761 Sam Weston changed: What|Removed |Added CC||weston@gmail.com -- You are

[Bug 62761] CORS filter example in docs not working in versions since 9.0.9

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62761 Sam Weston changed: What|Removed |Added Summary|CORS filter is not working |CORS filter example in docs

[Bug 62761] CORS filter is not working in tomcat 9.0.11 and 9.0.12

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62761 --- Comment #3 from Sam Weston --- I can confirm that this is definitely a bug in this documentation page in tomcat 7, 8 and 9. The CORS behaviour has been changed but not this part of the docs.

Re: SSL Unit Tests Failing

2018-10-02 Thread Mark Thomas
On 02/10/18 06:58, Igal Sapir wrote: > When trying to run the unit test cases with `ant clean test` on the current > trunk [1] I am getting two (per connector) failures: > > org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2] > >

svn commit: r1842618 - in /tomcat/trunk: java/org/apache/tomcat/util/net/jsse/PEMFile.java webapps/docs/changelog.xml

2018-10-02 Thread remm
Author: remm Date: Tue Oct 2 13:01:42 2018 New Revision: 1842618 URL: http://svn.apache.org/viewvc?rev=1842618=rev Log: Make PEM file parser a public utility class. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/PEMFile.java tomcat/trunk/webapps/docs/changelog.xml

Re: Bugzilla permanent CC addresses

2018-10-02 Thread Mark Thomas
On 02/10/18 01:11, Christopher Schultz wrote: > Mark, > > On 10/1/18 15:10, Mark Thomas wrote: >> On 01/10/18 20:04, Christopher Schultz wrote: >>> All, >>> >>> Does anyone know why these two email addresses are CC'd every >>> time a BZ message is sent? >>> >>> kakvi...@yahoo.co.in

[Bug 62792] Race condition NullpointerException in JspServletWrapper

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62792 --- Comment #2 from Julien Béti --- I would suggest to keep the "if(reload)" outside the synchronized block, and check again inside with "getReloadInternal()" Something like if(reload) { synchronized (this) { if(getReloadInternal()) {

[ASF Bugzilla] Your account dev@tomcat.apache.org is being impersonated

2018-10-02 Thread bugzilla
Mark Thomas has used the 'sudo' feature to access ASF Bugzilla using your account. Mark Thomas provided the following reason for doing this: Checking user settings If you feel that this action was inappropriate, please contact bugzilla-ad...@apache.org. For more information on

[Bug 62739] Tomcat should allow blank Host header

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 --- Comment #4 from Michael Orr --- Hi Mark, it won't happen this week. Possibly by the end of next week. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62792] Race condition NullpointerException in JspServletWrapper

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62792 --- Comment #1 from Julien Béti --- Sorry, the caused-by part of the trace was missing: Caused by: java.lang.NullPointerException: null at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:458) ... 74

[Bug 62792] Race condition NullpointerException in JspServletWrapper

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62792 Julien Béti changed: What|Removed |Added Depends on||62603 Referenced Bugs:

[Bug 62603] Changes in tag files are not reflected in the rendered view or they end up with a java.lang.NoClassDefFoundError

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62603 Julien Béti changed: What|Removed |Added Blocks||62792 Referenced Bugs:

[Bug 62792] New: Race condition NullpointerException in JspServletWrapper

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62792 Bug ID: 62792 Summary: Race condition NullpointerException in JspServletWrapper Product: Tomcat 9 Version: 9.0.12 Hardware: PC OS: Linux

[Bug 62791] New: SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler."

2018-10-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62791 Bug ID: 62791 Summary: SecureNioChannel fails with "IllegalArgumentException: You can only read using the application read buffer provided by the handler." Product:

svn commit: r1842605 - in /tomcat/trunk: java/org/apache/catalina/tribes/ java/org/apache/catalina/tribes/membership/ webapps/docs/

2018-10-02 Thread kfujino
Author: kfujino Date: Tue Oct 2 08:40:02 2018 New Revision: 1842605 URL: http://svn.apache.org/viewvc?rev=1842605=rev Log: Add setMembershipService method to the MembershipProvider. Modified: tomcat/trunk/java/org/apache/catalina/tribes/MembershipProvider.java