Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-08 Thread Martin Grigorov
Hi, On Mon, Oct 7, 2019 at 2:51 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.27 release is now available for voting. > > The major changes compared to the 9.0.26 release are: > > - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in > Commons Daemon 1.2.0 and 1.2.1

Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-08 Thread Konstantin Kolinko
вт, 8 окт. 2019 г. в 21:00, Mark Thomas : > > On 08/10/2019 17:49, Mark Thomas wrote: > > On 07/10/2019 17:40, Igal Sapir wrote: > >> Mark, > >> > >> On 10/7/2019 4:51 AM, Mark Thomas wrote: > >>> The proposed Apache Tomcat 9.0.27 release is now available for voting. > >> > >> I'm getting the

org.apache.tomcat.jni.TestSocketServer timeout test failures (was: VOTE 9.0.27)

2019-10-08 Thread Konstantin Kolinko
Hi! Splitting from "VOTE 9.0.27" thread. вт, 8 окт. 2019 г. в 21:00, Mark Thomas : > > On 08/10/2019 17:49, Mark Thomas wrote: > > On 07/10/2019 17:40, Igal Sapir wrote: > > > > > > > >> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt: FAILED > >>

svn commit: r1868163 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 22:17:30 2019 New Revision: 1868163 URL: http://svn.apache.org/viewvc?rev=1868163=rev Log: Use number comparison where appropriate. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified: tomcat/jk/trunk/tools/jkrelease.sh URL:

svn commit: r1868162 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 22:16:02 2019 New Revision: 1868162 URL: http://svn.apache.org/viewvc?rev=1868162=rev Log: Restrict use of explicit revision to trunk, branch or local directory. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified: tomcat/jk/trunk/tools/jkrelease.sh URL:

[Bug 63816] java.lang.IllegalStateException: Calling [asyncMustError()] is not valid for a request with Async state [STARTING]

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63816 --- Comment #3 from Alex --- I also filed https://bz.apache.org/bugzilla/show_bug.cgi?id=63817 for a similar problem, so may be the fix can be for both together? -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1868161 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 22:07:14 2019 New Revision: 1868161 URL: http://svn.apache.org/viewvc?rev=1868161=rev Log: Further syntax fixes. Tests for svn look good, old functionality should work again. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified:

svn commit: r1868159 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 21:53:06 2019 New Revision: 1868159 URL: http://svn.apache.org/viewvc?rev=1868159=rev Log: Fix new syntax errors in script. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified: tomcat/jk/trunk/tools/jkrelease.sh URL:

svn commit: r1868158 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 21:51:49 2019 New Revision: 1868158 URL: http://svn.apache.org/viewvc?rev=1868158=rev Log: Add support for using tags, branches, revisions (hashes) and local directories when using the script with git. Still untested. Modified:

[Bug 63816] java.lang.IllegalStateException: Calling [asyncMustError()] is not valid for a request with Async state [STARTING]

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63816 --- Comment #2 from Mark Thomas --- I've been able to create a test case for this. This is one of those areas of the Servlet spec that could benefit from some clarification. There is this text in the spec: The application is responsible to

[Bug 63815] Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63815 --- Comment #2 from Konstantin Kolinko --- What exact change are you asking for? Please note that on the last step (when invoking a java executable) the JAVA_OPTS must produce several separate command line arguments: java expects that each -D

[tomcat] branch BZ-63681/8.5.x created (now 6be96eb)

2019-10-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch BZ-63681/8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 6be96eb Frist draft This branch includes the following new commits: new 6be96eb Frist draft The 1

[tomcat] 01/01: Frist draft

2019-10-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch BZ-63681/8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6be96ebba4e7056d5c9621bada2c496f8c0a82d0 Author: Michael Osipov AuthorDate: Wed Aug 21 23:23:19 2019 +0200

[tomcat] branch BZ-63681/8.5.x deleted (was 6be96eb)

2019-10-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch BZ-63681/8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. was 6be96eb Frist draft This change permanently discards the following revisions: discard 6be96eb Frist

[Bug 63816] java.lang.IllegalStateException: Calling [asyncMustError()] is not valid for a request with Async state [STARTING]

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63816 --- Comment #1 from Mark Thomas --- Please provide the full stack trace and as much detail as you can on the conditions that trigger the error. -- You are receiving this mail because: You are the assignee for the bug.

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-08 Thread Mark Thomas
On 08/10/2019 17:19, Igal Sapir wrote: > On 10/7/2019 6:58 AM, Mark Thomas wrote: >> The proposed Apache Tomcat 8.5.47 release is now available for voting. >> >> The major changes compared to the 8.5.46 release are: > > I'm getting similar test failures as I did for 9.0.27 on that same > Windows

Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-08 Thread Mark Thomas
On 08/10/2019 17:49, Mark Thomas wrote: > On 07/10/2019 17:40, Igal Sapir wrote: >> Mark, >> >> On 10/7/2019 4:51 AM, Mark Thomas wrote: >>> The proposed Apache Tomcat 9.0.27 release is now available for voting. >> >> I'm getting the failures below [1] for unit tests on Windows 10 with >> Java

[Bug 63817] New: Calling [asyncComplete()] is not valid for a request with Async state [MUST_ERROR]

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63817 Bug ID: 63817 Summary: Calling [asyncComplete()] is not valid for a request with Async state [MUST_ERROR] Product: Tomcat 9 Version: 9.0.22 Hardware: PC

[Bug 63815] Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63815 --- Comment #1 from Mark Thomas --- I'm wondering how important it is to remove newlines backwards compatibility. might it be sufficient to document the change in behaviour? -- You are receiving this mail because: You are the assignee for

[Bug 63816] New: java.lang.IllegalStateException: Calling [asyncMustError()] is not valid for a request with Async state [STARTING]

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63816 Bug ID: 63816 Summary: java.lang.IllegalStateException: Calling [asyncMustError()] is not valid for a request with Async state [STARTING] Product: Tomcat 9

Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-08 Thread Mark Thomas
On 07/10/2019 17:40, Igal Sapir wrote: > Mark, > > On 10/7/2019 4:51 AM, Mark Thomas wrote: >> The proposed Apache Tomcat 9.0.27 release is now available for voting. > > I'm getting the failures below [1] for unit tests on Windows 10 with > Java 1.8u181.  False positives? Don't know yet. I

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-08 Thread Igal Sapir
On 10/7/2019 6:58 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.47 release is now available for voting. The major changes compared to the 8.5.46 release are: I'm getting similar test failures as I did for 9.0.27 on that same Windows machine: > grep -A 5 FAILED

[tomcat] branch master updated: Avoid possible Windows path issues

2019-10-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ad3de0b Avoid possible Windows path issues

[tomcat] branch 7.0.x updated: Update URL for code signing service.

2019-10-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new aba8fd8 Update URL for code signing service.

[tomcat] branch 8.5.x updated: Update URL for code signing service.

2019-10-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4a9f854 Update URL for code signing service.

[tomcat] branch master updated: Update URL for code signing service.

2019-10-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new eb1eb55 Update URL for code signing service.

Re: [tomcat] branch 7.0.x updated: 63814: Do not set server socket timeout with negative values in NIO

2019-10-08 Thread Rémy Maucherat
On Tue, Oct 8, 2019 at 3:35 PM Mark Thomas wrote: > On 08/10/2019 12:31, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch 7.0.x > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

[tomcat] branch 7.0.x updated: Fix issue spotted by Mark, 0 can be passed along as well for infinite

2019-10-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new f140942 Fix issue spotted by Mark, 0 can be passed

Re: [tomcat] branch 7.0.x updated: 63814: Do not set server socket timeout with negative values in NIO

2019-10-08 Thread Mark Thomas
On 08/10/2019 12:31, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch 7.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/7.0.x by this push: >

Re: Migrating Tomcat Connectors to Git

2019-10-08 Thread Mark Thomas
On 08/10/2019 13:32, Rainer Jung wrote: > Am 08.10.2019 um 13:39 schrieb Rainer Jung: >> Am 08.10.2019 um 13:09 schrieb Mark Thomas: >>> Hi all, >>> >>> Tomcat Connectors (mod_jk, isapi_redirect) are currently in svn. There >>> hasn't been much activity on these over the last year or so so there

Re: Migrating Tomcat Connectors to Git

2019-10-08 Thread Rainer Jung
Am 08.10.2019 um 13:39 schrieb Rainer Jung: Am 08.10.2019 um 13:09 schrieb Mark Thomas: Hi all, Tomcat Connectors (mod_jk, isapi_redirect) are currently in svn. There hasn't been much activity on these over the last year or so so there has been no reason to migrate the project to Git. I've

svn commit: r1868135 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 12:30:18 2019 New Revision: 1868135 URL: http://svn.apache.org/viewvc?rev=1868135=rev Log: Simplify and try to guess future JK git repos URL. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified: tomcat/jk/trunk/tools/jkrelease.sh URL:

svn commit: r1868134 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 12:20:45 2019 New Revision: 1868134 URL: http://svn.apache.org/viewvc?rev=1868134=rev Log: Add "-R git" and "-R svn" to mod_jk release skript. With git only releasing a version is currently supported. Not tested. Modified: tomcat/jk/trunk/tools/jkrelease.sh

[Bug 63815] New: Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63815 Bug ID: 63815 Summary: Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux Product: Tomcat 8 Version: 8.5.x-trunk Hardware: Other

[Bug 63808] the fact that JkMount makes other directives ineffective is undocumented

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63808 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement Component|mod_jk

svn commit: r1868132 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 11:47:32 2019 New Revision: 1868132 URL: http://svn.apache.org/viewvc?rev=1868132=rev Log: Don't roll ".git" (just in case e do a full checkout). Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified: tomcat/jk/trunk/tools/jkrelease.sh URL:

svn commit: r1868131 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 11:45:48 2019 New Revision: 1868131 URL: http://svn.apache.org/viewvc?rev=1868131=rev Log: Make variable names more agnostic about our code repos technology. No functional change, still only works for svn. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified:

Re: Migrating Tomcat Connectors to Git

2019-10-08 Thread Rainer Jung
Am 08.10.2019 um 13:09 schrieb Mark Thomas: Hi all, Tomcat Connectors (mod_jk, isapi_redirect) are currently in svn. There hasn't been much activity on these over the last year or so so there has been no reason to migrate the project to Git. I've recently fixed a mod_jk bug and I have a patch

[Bug 63814] Socket timeout -1 no longer allowed since Java 13, leading to IllegalArgumentException and unit test hang for TestAbstractAjpProcessor

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63814 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1868130 - /tomcat/jk/trunk/tools/jkrelease.sh

2019-10-08 Thread rjung
Author: rjung Date: Tue Oct 8 11:35:32 2019 New Revision: 1868130 URL: http://svn.apache.org/viewvc?rev=1868130=rev Log: Remove unused svn revision retrieval when releasing from a tag. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified: tomcat/jk/trunk/tools/jkrelease.sh URL:

[tomcat] branch 7.0.x updated: 63814: Do not set server socket timeout with negative values in NIO

2019-10-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 0a18642 63814: Do not set server socket timeout

[Bug 63808] the fact that JkMount makes other directives ineffective is undocumented

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63808 Arpad Magosanyi changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

[Bug 63814] Socket timeout -1 no longer allowed since Java 13, leading to IllegalArgumentException and unit test hang for TestAbstractAjpProcessor

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63814 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy

[Bug 63814] New: Socket timeout -1 no longer allowed since Java 13, leading to IllegalArgumentException and unit test hang for TestAbstractAjpProcessor

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63814 Bug ID: 63814 Summary: Socket timeout -1 no longer allowed since Java 13, leading to IllegalArgumentException and unit test hang for TestAbstractAjpProcessor Product:

Migrating Tomcat Connectors to Git

2019-10-08 Thread Mark Thomas
Hi all, Tomcat Connectors (mod_jk, isapi_redirect) are currently in svn. There hasn't been much activity on these over the last year or so so there has been no reason to migrate the project to Git. I've recently fixed a mod_jk bug and I have a patch ready to fix a second. These seems like a good

svn commit: r1868127 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2019-10-08 Thread markt
Author: markt Date: Tue Oct 8 11:03:48 2019 New Revision: 1868127 URL: http://svn.apache.org/viewvc?rev=1868127=rev Log: Update changelog Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL:

[Bug 63214] Using JkAutoAlias, Filenames with Spaces Cannot be found

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63214 --- Comment #3 from Mark Thomas --- Thanks for the review. I'll proceed on that basis. -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 63808] the fact that JkMount makes other directives ineffective is undocumented

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63808 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 63214] Using JkAutoAlias, Filenames with Spaces Cannot be found

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63214 --- Comment #2 from Rainer Jung --- The use of ap_os_escape_path() goes back to the original implementation of the JkAutoAlias feature for httpd 1.3.x. svn logs do not give any idication why it was used. Currently in the 2.0 code, IMHO the

Re: [PROPOSAL] Tomcat 10: Drop APR Connector

2019-10-08 Thread Rainer Jung
Am 07.10.2019 um 16:39 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I recently gave a presentation on locking-down Apache Tomcat[1] and I briefly discussed the "sharp edges" present in Tomcat. Some of them are unnecessarily sharp and may be actually

Re: [PROPOSAL] Tomcat 10: Remove CGI Servlet

2019-10-08 Thread Rainer Jung
Am 07.10.2019 um 18:37 schrieb Igal Sapir: On 10/7/2019 8:14 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/7/19 11:10, Mark Thomas wrote: All, I recently gave a presentation on locking-down Apache Tomcat[1] and I briefly discussed the "sharp

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-08 Thread Rainer Jung
Am 07.10.2019 um 20:01 schrieb Rémy Maucherat: On Mon, Oct 7, 2019 at 4:46 PM Christopher Schultz mailto:ch...@christopherschultz.net>> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I recently gave a presentation on locking-down Apache Tomcat[1] and I

[Bug 63808] the fact that JkMount makes other directives ineffective is undocumented

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63808 Arpad Magosanyi changed: What|Removed |Added Summary|user and certificate info |the fact that JkMount makes

[Bug 63808] user and certificate info is not passed to tomcat

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63808 --- Comment #5 from Arpad Magosanyi --- Upps, tested the nonredundant version, but forget to update it here. JkMount worker1 DirectoryIndex off RewriteEngine Off AuthType openid-connect AllowOverride None

[Bug 63808] user and certificate info is not passed to tomcat

2019-10-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63808 --- Comment #4 from Arpad Magosanyi --- The cause is found to be the fact that if you have a JkMount in a Location (or perhaps also a Directory) directive, all other autorization and authorization (or even all other?) directives are