[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #9 from Ralf Hauser --- Every penetration tester will complain about it. If they can be made happy in one go, that would be great. In the current setup, they in most cases will have two points to raise... -- You are receiving

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #8 from Mark Thomas --- (In reply to Ralf Hauser from comment #5) >showServerInfo=false > achieves a similar goal, but why not be consistent with the "server" > attribute of server.xml ? There are some subtle differences. The

[Bug 63817] Calling [asyncComplete()] is not valid for a request with Async state [MUST_ERROR]

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63817 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] 02/07: Refactor

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8e17930703c3d6c96cd2d0e8ff450c0ecf0d4519 Author: Mark Thomas AuthorDate: Tue Oct 15 21:14:25 2019 +0100 Refactor ---

[tomcat] 05/07: Hack to fix failing test

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4eec200b72e8059c4cc7b501f83d45cb9cdfc05c Author: Mark Thomas AuthorDate: Tue Oct 15 21:36:52 2019 +0100 Hack to fix

[tomcat] 01/07: Expand test for https://bz.apache.org/bugzilla/show_bug.cgi?id=63816

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 5e3b0aa030e726c3f01c6ee3517f757900784399 Author: Mark Thomas AuthorDate: Tue Oct 15 14:18:26 2019 +0100 Expand test

[tomcat] 04/07: Remove an illegal state transition

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d2d46f0a220066329c258e5fd6d3be355c5ea232 Author: Mark Thomas AuthorDate: Tue Oct 15 21:27:10 2019 +0100 Remove an

[tomcat] 03/07: Refactor

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f353d63c7df7113b70b6c35b3d203879382e0efa Author: Mark Thomas AuthorDate: Tue Oct 15 21:16:11 2019 +0100 Refactor ---

[tomcat] 06/07: Fix back-port to Java 6 errors

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 79af7e2c5dd57127e8d695e5bd3b3490defb75a0 Author: Mark Thomas AuthorDate: Tue Oct 15 21:48:21 2019 +0100 Fix

[tomcat] 07/07: Refactor the unit test to avoid race conditions

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 87dbf83dd51616cbca6b5ee7406684ebcade1c4e Author: Mark Thomas AuthorDate: Tue Oct 15 23:11:59 2019 +0100 Refactor the

[tomcat] branch 7.0.x updated (fe65d4c -> 87dbf83)

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from fe65d4c Remove sync that triggers deadlock with BZ 63816 test case new 5e3b0aa Expand test for

buildbot success in on tomcat-85-trunk

2019-10-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1979 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #7 from Mark Thomas --- The tone of some of the comments on this issue is getting a little unfriendly. I'd ask that everyone remind themselves of the ASF code of conduct - particularly guideline 2: "Be empathetic, welcoming,

[Bug 63851] Response's "Location" header must not disclose internal IPs

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63851 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[tomcat] branch 8.5.x updated: Refactor the unit test to avoid race conditions

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 333ece2 Refactor the unit test to avoid race

buildbot success in on tomcat-trunk

2019-10-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4674 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch master updated: Refactor the unit test to avoid race conditions

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e7988cc Refactor the unit test to avoid race

buildbot failure in on tomcat-85-trunk

2019-10-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1978 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] 03/05: Refactor

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 29bf1c53fa58fda3f76e94f2bea5e05c3a1eb0e2 Author: Mark Thomas AuthorDate: Tue Oct 15 21:16:11 2019 +0100 Refactor ---

[tomcat] 02/05: Refactor

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit eb9ca417184edc90bcbb51a817e83e7dc8781674 Author: Mark Thomas AuthorDate: Tue Oct 15 21:14:25 2019 +0100 Refactor ---

[tomcat] 01/05: Expand test for https://bz.apache.org/bugzilla/show_bug.cgi?id=63816

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7c0a689e78512686978a8ce71ca7d4cd2216fa8e Author: Mark Thomas AuthorDate: Tue Oct 15 14:18:26 2019 +0100 Expand test

[tomcat] branch 8.5.x updated (0495f66 -> 6e1b6a9)

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 0495f66 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63816 async errors new 7c0a689 Expand test for

[tomcat] 05/05: Hack to fix failing test

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6e1b6a9a4f358132b57e795170906108b8365311 Author: Mark Thomas AuthorDate: Tue Oct 15 21:36:52 2019 +0100 Hack to fix

[tomcat] 04/05: Remove an illegal state transition

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a6b3d5b56fb0f1dff9e481596048f255773ae86a Author: Mark Thomas AuthorDate: Tue Oct 15 21:27:10 2019 +0100 Remove an

[tomcat] 04/04: Hack to fix fialing test

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8d4d6637176816bb4d6c1f39d94e32bb28058d8d Author: Mark Thomas AuthorDate: Tue Oct 15 21:36:52 2019 +0100 Hack to fix

[tomcat] 03/04: Remove an illegal state transition

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a7303954ab34d45e1f4693a9484e0833bbf38c5b Author: Mark Thomas AuthorDate: Tue Oct 15 21:27:10 2019 +0100 Remove an

[tomcat] 01/04: Refactor

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b0376a270b6471c782bb5882184af543acaa164b Author: Mark Thomas AuthorDate: Tue Oct 15 21:14:25 2019 +0100 Refactor

[tomcat] 02/04: Refactor

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0a7deb568827a7d55162fca0c2306a20b246530c Author: Mark Thomas AuthorDate: Tue Oct 15 21:16:11 2019 +0100 Refactor

[tomcat] branch master updated (a80693f -> 8d4d663)

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from a80693f Expand test for https://bz.apache.org/bugzilla/show_bug.cgi?id=63816 new b0376a2 Refactor new

Re: buildbot failure in on tomcat-trunk

2019-10-15 Thread Mark Thomas
On 15/10/2019 15:02, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/4672 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for

[Bug 63853] allow to overwrite/extend org.apache.catalina.valves.ErrorReportValve.getPartialServletStackTrace()

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63853 --- Comment #3 from Ralf Hauser --- please extend the http://tomcat.apache.org/tomcat-8.5-doc/config/valve.html#Error_Report_Valve with a hint to "errorReportValveClass" and that it can be sub-classed -- You are receiving this mail because:

[Bug 63853] allow to overwrite/extend org.apache.catalina.valves.ErrorReportValve.getPartialServletStackTrace()

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63853 --- Comment #2 from Ralf Hauser --- https://tomcat.apache.org/tomcat-8.5-doc/config/host.html "errorReportValveClass" seems to be the solution, apologies ;) -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #6 from Michael Osipov --- (In reply to Ralf Hauser from comment #5) > Hi Violeta, > > Sure, >showServerInfo=false > achieves a similar goal, but why not be consistent with the "server" > attribute of server.xml ? Because

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 Ralf Hauser changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #5 from Ralf Hauser

[Bug 63853] allow to overwrite/extend org.apache.catalina.valves.ErrorReportValve.getPartialServletStackTrace()

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63853 Remy Maucherat changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #4 from Violeta Georgieva --- (In reply to Ralf Hauser from comment #2) > Hi Michael, > > Thanks for your comment. > > "Apache Tomcat/8.5.47 (Ubuntu)" > > is not the true version and OS I am using, this is just for

[Bug 63853] New: allow to overwrite/extend org.apache.catalina.valves.ErrorReportValve.getPartialServletStackTrace()

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63853 Bug ID: 63853 Summary: allow to overwrite/extend org.apache.catalina.valves.ErrorReportValve.getPartial ServletStackTrace() Product: Tomcat 8 Version: 8.5.14

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 Michael Osipov changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Michael

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 Ralf Hauser changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from Ralf Hauser

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 Michael Osipov changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Michael

[Bug 63852] New: ServerInfo.java

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 Bug ID: 63852 Summary: ServerInfo.java Product: Tomcat 8 Version: 8.5.14 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 Ralf Hauser changed: What|Removed |Added Summary|ServerInfo.java |ServerInfo.java discloses

buildbot failure in on tomcat-trunk

2019-10-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4672 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[Bug 63851] Response's "Location" header must not disclose internal IPs

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63851 Michael Osipov changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Michael

[tomcat] branch master updated: Expand test for https://bz.apache.org/bugzilla/show_bug.cgi?id=63816

2019-10-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a80693f Expand test for

[Bug 63851] New: Response's "Location" header must not disclose internal IPs

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63851 Bug ID: 63851 Summary: Response's "Location" header must not disclose internal IPs Product: Tomcat 8 Version: 8.5.14 Hardware: PC OS: Linux

buildbot success in on tomcat-trunk

2019-10-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4671 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch master updated: Fix debug message formatting

2019-10-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 302b06b Fix debug message formatting 302b06b is

[Bug 60918] Process Send File releases the same Http11Processor in two threads, leading to java.lang.IllegalStateException: Unexpected state: headers already parsed. Buffer not recycled?

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60918 --- Comment #14 from Jennifer Hinnant --- Branded event tech app by Eventeca.com will drive your sales sky- high & give your audience the engagement they want with our customized & knowledgeable event application solutions! Connect with us via

[Bug 63815] Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

2019-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63815 --- Comment #6 from mrog...@zaizi.com --- There are various style guides on the web suggesting that it is good practice to always quote the use of variables in bash scripts e.g. Google https://google.github.io/styleguide/shell.xml