[Bug 63824] Http11Processor does not compare Connection header value case-insensitively

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63824 --- Comment #4 from Michael Osipov --- (In reply to Mark Thomas from comment #3) > (In reply to Michael Osipov from comment #2) > > As per defition, only one token is allowed, > > so "close, close2" ist not valid. > > "1#connection-option" mea

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #13 from Christopher Schultz --- (In reply to Ralf Hauser from comment #9) > Every script kiddie pen tester will complain about it. FTFY -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 63824] Http11Processor does not compare Connection header value case-insensitively

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63824 --- Comment #3 from Mark Thomas --- (In reply to Michael Osipov from comment #2) >Connection options are case-insensitive. Thanks. I missed that statement below the formal grammar. > As per defition, only one token is allowed, > so "clos

[Bug 63824] Http11Processor does not compare Connection header value case-insensitively

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63824 --- Comment #2 from Michael Osipov --- https://tools.ietf.org/html/rfc7230#section-6.1 says: The Connection header field's value has the following grammar: Connection= 1#connection-option connection-option = token Co

[Bug 63824] Http11Processor does not compare Connection header value case-insensitively

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63824 --- Comment #1 from Mark Thomas --- HTTP header values are case sensitive (HTTP header names are insensitive). Both RFC 2616 and RFC 7230 define the relevant token as "close" so the current case sensitive comparison is correct. The current cod

Re: [Bug 63833] NPE in DBCP when attempting to connect to a database that doesn't exist

2019-10-16 Thread Mark Thomas
On 12/10/2019 00:03, Phil Steitz wrote: > How about adding the DBCP unit tests to the source tree?  I suspect some > would have failed due to this change.  If others think this is a good > idea, I could take a stab at genericising them and creating a PR to add > them. +1 I'd suggest several commi

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-16 Thread Mark Thomas
On 11/10/2019 15:20, Rémy Maucherat wrote: > Hi, > > This vote is to regulate the use of branches in the official Tomcat > repository beyond branches that are approved by the community such as > 8.5.x and 7.0.x. It is possible to do development in private branches > directly in the official Tomcat

[Bug 63820] Install with JDK13 is not working

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63820 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 63815] Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63815 --- Comment #7 from Mark Thomas --- (In reply to Konstantin Kolinko from comment #2) > Please note that on the last step (when invoking a java executable) the > JAVA_OPTS must produce several separate command line arguments: java expects > tha

[tomcat] branch 7.0.x updated: Fix typo

2019-10-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new af963c6 Fix typo af963c6 is described below commi

[tomcat] branch 7.0.x updated: Restore the necessary syncs for correct async processing,

2019-10-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 91aa7e8 Restore the necessary syncs for correct as

[GitHub] [tomcat] jgallimore opened a new pull request #214: Avoid reusing a processor from a request that has timed out

2019-10-16 Thread GitBox
jgallimore opened a new pull request #214: Avoid reusing a processor from a request that has timed out URL: https://github.com/apache/tomcat/pull/214 When a async request times out, this change will stop the associated processor from being added back to the pool for re-use. --

[GitHub] [tomcat] jgallimore opened a new pull request #213: Avoid reusing a processor from a request that has timed out

2019-10-16 Thread GitBox
jgallimore opened a new pull request #213: Avoid reusing a processor from a request that has timed out URL: https://github.com/apache/tomcat/pull/213 When a async request times out, this change will stop the associated processor from being added back to the pool for re-use. --

[Bug 63832] Unable to stop because WebappClassLoaderBase.checkThreadLocalMapForLeaks can't load class(class from deployed aplication - probably undeployed)

2019-10-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63832 Rafał Gała changed: What|Removed |Added CC||rafal.g...@ingbank.pl -- You are receivi

[tomcat] branch 7.0.x updated: Temporary fix. Deadlock in the recently added async state tests

2019-10-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new b6bba7b Temporary fix. Deadlock in the recently ad

Re: [tomcat] 04/04: Remove sync that triggers deadlock with BZ 63816 test case

2019-10-16 Thread Mark Thomas
On 14/10/2019 17:58, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch 7.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit fe65d4c1aac1759e99befe417afde51dded567b5 > Author: Mark Thomas >

[tomcat] branch 7.0.x updated: Fix BZ number

2019-10-16 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new aaef01d Fix BZ number aaef01d is described below c

[tomcat] branch 8.5.x updated: Fix BZ number

2019-10-16 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 57c6917 Fix BZ number 57c6917 is described below c

[tomcat] branch master updated: Fix BZ number

2019-10-16 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 339f910 Fix BZ number 339f910 is described below