Re: Native Image - Reflectionless Concept

2020-07-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Filip, On 7/13/20 17:59, Filip Hanik wrote: > for discussion, all feedback and questions welcome: > > > I've created a concept of having Apache Tomcat, embedded, run > without reflection in a native image. This concept creates a jar, > tomcat-embedd

Re: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-07-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Merlin, On 7/13/20 06:09, Merlin Beedell wrote: > Hi all, > > Thank you for your valuable assistance and suggestions so far. > > > > I did eventually try this (again, using ‘groovy’ as a > simple-to-use scriptable wrapper to Java), which looks like

[GitHub] [tomcat] ChristopherSchultz commented on pull request #321: Simplify some #toString() methods

2020-07-13 Thread GitBox
ChristopherSchultz commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-657831187 > @ChristopherSchultz [...] Others switched it to concatenation. I don't see a single case of concatenation where it wasn't already there (in some form or other).

Native Image - Reflectionless Concept

2020-07-13 Thread Filip Hanik
for discussion, all feedback and questions welcome: I've created a concept of having Apache Tomcat, embedded, run without reflection in a native image. This concept creates a jar, tomcat-embedded-programmatic.jar, that can be fine tuned to only include what is needed in a default configuration

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] 02/02: Fix BZ 64593. Delay 404 when Context is null.

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a372184ecc3dca8abfef5b432effc90358d68f8c Author: Mark Thomas AuthorDate: Mon Jul 13 16:46:23 2020 +0100 Fix BZ 64593.

[tomcat] branch 8.5.x updated (200da3c -> a372184)

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 200da3c Simplify some #toString() methods new 74edb31 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=53411

[tomcat] 01/02: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=53411

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 74edb3133edb52af9b3490192aab27ec1c96194e Author: Mark Thomas AuthorDate: Thu Jun 28 12:13:34 2018 + Fix https://b

[tomcat] branch 9.0.x updated: Fix BZ 64593. Delay 404 when Context is null.

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f486275 Fix BZ 64593. Delay 404 when Context is nu

[tomcat] branch master updated: Fix BZ 64593. Delay 404 when Context is null.

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 519251c Fix BZ 64593. Delay 404 when Context is

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 --- Comment #6 from Remy Maucherat --- (In reply to Mark Thomas from comment #5) > I think that could be a better option that the one I was looking at. Undoing > the effects of calling sendError() gets messy rather quickly. I'll > experiment.

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 --- Comment #5 from Mark Thomas --- I think that could be a better option that the one I was looking at. Undoing the effects of calling sendError() gets messy rather quickly. I'll experiment. -- You are receiving this mail because: You are th

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 --- Comment #4 from Remy Maucherat --- It could be possible to remove the sendError(404) here: https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/connector/CoyoteAdapter.java#L696 And move it to StandardHostValve (if request.

[tomcat] branch 8.5.x updated: Simplify some #toString() methods

2020-07-13 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 200da3c Simplify some #toString() methods 200d

[tomcat] branch 9.0.x updated: Simplify some #toString() methods

2020-07-13 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b81ed7b Simplify some #toString() methods b81e

[tomcat] branch master updated: Simplify some #toString() methods

2020-07-13 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 768524f Simplify some #toString() methods

[GitHub] [tomcat] martin-g commented on pull request #321: Simplify some #toString() methods

2020-07-13 Thread GitBox
martin-g commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-657513641 @hazendaz Thanks for your comments! See https://www.guardsquare.com/en/blog/string-concatenation-java-9-untangling-invokedynamic - Java 8 already uses StringBuilder. Java 9+ makes

[GitHub] [tomcat] martin-g merged pull request #321: Simplify some #toString() methods

2020-07-13 Thread GitBox
martin-g merged pull request #321: URL: https://github.com/apache/tomcat/pull/321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [tomcat] branch 9.0.x updated: Fix BZ 64548 - generate JPMS metadata

2020-07-13 Thread Martin Grigorov
On Mon, Jul 13, 2020 at 1:02 PM Mark Thomas wrote: > There are some Java EE / Jakarta EE issues here. > > Tomcat 10 is Jakarta EE. > Tomcat 9 is Java EE. > > There should not be any references to Jakarta in Tomcat 9. This needs to > be fixed before the next Tomcat 9 release. > > I don't think the

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 --- Comment #3 from Mark Thomas --- Thanks for the offer. I've tracked down the root cause. The missing ROOT context puts the response into the error state which then doesn't get cleared in the RewriteValve. What I haven't figured out is the be

Re: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-07-13 Thread Mark Thomas
On 13/07/2020 11:09, Merlin Beedell wrote: > If the connector section in server.xml is edited to point to a new > certificate path/filename, it is ignored.  The current certificate > config continues to be used. As expected. server.xml is only read on Tomcat start. Changes made after that point

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 --- Comment #2 from Remy Maucherat --- Yes, Catalina never likes unmapped requests, it's kind of a lost cause and an empty "ROOT" folder will usually solve all the problems at no cost. Mark, I can look at this issue if you don't have time [I w

[Bug 64593] Rewrites incorrectly 404 when there is no source context

2020-07-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 --- Comment #1 from Mark Thomas --- I am able to reproduce this using the steps provided. Thank you for providing a simple test case for this issue. It saves a considerable amount of time. I'll note at this point that creating webapps/ROOT is

RE: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-07-13 Thread Merlin Beedell
Hi all, Thank you for your valuable assistance and suggestions so far. I did eventually try this (again, using ‘groovy’ as a simple-to-use scriptable wrapper to Java), which looks like it works: @Grab(group='com.github.groovy-wslite', module='groovy-wslite', version='1.1.3') import wslite.rest

Re: [tomcat] branch 9.0.x updated: Fix BZ 64548 - generate JPMS metadata

2020-07-13 Thread Mark Thomas
There are some Java EE / Jakarta EE issues here. Tomcat 10 is Jakarta EE. Tomcat 9 is Java EE. There should not be any references to Jakarta in Tomcat 9. This needs to be fixed before the next Tomcat 9 release. I don't think there are definitive JPMS names for the Java EE 8 modules as Java EE 8

[tomcat] branch 9.0.x updated: Replace tabs with four spaces

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f911447 Replace tabs with four spaces f911447 is d

[tomcat] branch master updated: Replace tabs with four spaces

2020-07-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c0c7d9e Replace tabs with four spaces c0c7d9e is