[GitHub] [tomcat] stokito edited a comment on pull request #325: Simplify ETag check

stokito edited a comment on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661356032 a related ticket https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 This is an automated message from the

[GitHub] [tomcat] reschke commented on pull request #325: Simplify ETag check

reschke commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661607221 > At least twice fast because creates less memory garbage And this is measurable in practice., not in an isolated unit test?

[GitHub] [tomcat] stokito commented on pull request #325: Simplify ETag check

stokito commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661356032 I found related ticket https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 This is an automated message from the A

[GitHub] [tomcat] stokito edited a comment on pull request #324: Change ETag format to Nginx like

stokito edited a comment on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661312436 > we cannot make any assumptions. But we already did when implemented the default method :) I used Tomcat for about 10 years in different projects and once even patche

[GitHub] [tomcat] markt-asf commented on pull request #324: Change ETag format to Nginx like

markt-asf commented on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661338844 I think it is unlikely this patch will get applied as-is. I think a patch that made is easier to provide custom ETags (without changing the current behaviour by default) is muc

[GitHub] [tomcat] stokito edited a comment on pull request #325: Simplify ETag check

stokito edited a comment on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661298600 At least twice fast because creates less memory garbage. For two comma separated ETags may work 5 times faster. Here is a benchmark with results https://gist.github.com/s

[GitHub] [tomcat] stokito commented on pull request #324: Change ETag format to Nginx like

stokito commented on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661312436 > we cannot make any assumptions. But we already did when implemented the default method :) I used Tomcat for about 10 years in different projects and once even patched it fo

[GitHub] [tomcat] stokito edited a comment on pull request #325: Simplify ETag check

stokito edited a comment on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661298600 At least twice fast because creates less memory garbage. Here is a benchmark with results https://gist.github.com/stokito/a82eed1aef6ad965e2a279825f1c3420 I tested with

[GitHub] [tomcat] stokito commented on pull request #325: Simplify ETag check

stokito commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661298600 At least twice fast because and creates less memory garbage. Here is a benchmark with results https://gist.github.com/stokito/a82eed1aef6ad965e2a279825f1c3420 I tested with fo

Re: Native Image - Reflectionless Concept

Xml-less Tomcat would also be very useful for OSGi http whiteboard implementation which I'd like to work on in the coming months. So I +1 more programmatic API. Just let's not forget about tear down. So many APIs completely ignore a tear down lifecycle. - Ray On Mon, Jul 20, 2020, 12:16 Romain

[GitHub] [tomcat] reschke commented on pull request #325: Simplify ETag check

reschke commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661279813 > But the change improves performance a lot. Can you quantify that? This is an automated message from the Ap

[GitHub] [tomcat] michael-o commented on pull request #324: Change ETag format to Nginx like

michael-o commented on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661265371 Why don't you delete the ETags send from Tomcat in nginx config, use a caching module and rely on nginx ETags only? -

[GitHub] [tomcat] michael-o commented on pull request #324: Change ETag format to Nginx like

michael-o commented on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661263952 Even if file and JAR are fine, the ETag implementation is on the `AbstractResource` and from here we cannot make any assumptions. ---

[Bug 64616] Change ETag format to Nginx like

https://bz.apache.org/bugzilla/show_bug.cgi?id=64616 --- Comment #4 from Sergey Ponomarev --- I also thought to make ETag configurable like in Apache HTTPD but in fact for clients this is still opaque value and the Nginx is not configurable anyway while Apache Htttpd can be configured to be compl

[GitHub] [tomcat] stokito commented on pull request #325: Simplify ETag check

stokito commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661232860 Yeah, that's why I said "in fact should do". This is not a big deal while Tomcat generates those ETag itself. I'm not even sure that there is any clients who sends multiple ETags.

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #5 from jfclere --- I need to investigate a little I will come with a better patch later this week. -- You are receiving this mail because: You are the assignee for the bug.

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

This commit is problematic :( It's broken some projects that depend on Tomcat because now the tomcat-coyote.jar doesn't contain the org.apache.tomcat.util.net.jsse or org.apache.tomcat.util.modeler.modules packages which results in ClassNotFoundExceptions. I haven't seen any issues with other jars

[GitHub] [tomcat] reschke edited a comment on pull request #325: Simplify ETag check

reschke edited a comment on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661164935 You are citing the spec very selectively (hint: there are strong and weak comparison functions). This is an

[GitHub] [tomcat] reschke commented on pull request #325: Simplify ETag check

reschke commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661164935 You are citing the spec very selectively (hint: there are strong and weak comparion functions). This is an automat

Re: Native Image - Reflectionless Concept

I think a xml-less tomcat is awaited since servlet 3 - graal or not - but agree risk is a bit higher. That said path is different so wonder if skipping a temp solution can not be worth after all for the community. Le lun. 20 juil. 2020 à 17:58, Filip Hanik a écrit : > > On 7/20/20 8:47 AM, Romai

Re: Native Image - Reflectionless Concept

On 7/20/20 8:47 AM, Romain Manni-Bucau wrote: Le lun. 20 juil. 2020 à 17:41, Filip Hanik > a écrit : Thanks for chiming in: On 7/16/20 6:46 AM, Romain Manni-Bucau wrote: Hi everyone, I think the generation is the sanest option since code stay clean

[GitHub] [tomcat] stokito edited a comment on pull request #325: Simplify ETag check

stokito edited a comment on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-66650 Thank you, good points! I checked spec https://tools.ietf.org/html/rfc7232#section-2.3.2 and it looks like we still fine here because Tomcat in fact should do a weak compari

Re: Native Image - Reflectionless Concept

Le lun. 20 juil. 2020 à 17:41, Filip Hanik a écrit : > Thanks for chiming in: > On 7/16/20 6:46 AM, Romain Manni-Bucau wrote: > > Hi everyone, > > I think the generation is the sanest option since code stay clean but it > shouldn't be done in tomcat IMHO but in user code and with a nice wrapper >

Re: Native Image - Reflectionless Concept

Thanks for chiming in: On 7/16/20 6:46 AM, Romain Manni-Bucau wrote: Hi everyone, I think the generation is the sanest option since code stay clean but it shouldn't be done in tomcat IMHO but in user code and with a nice wrapper (mvn tomcat:dump/gradle tomcatDump etc, or whatever name you li

[tomcat] branch 9.0.x updated: Enable graal reflection on all ParallelWebappClassLoader methods

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0599a24 Enable graal reflection on all ParallelWe

[tomcat] branch master updated: Enable graal reflection on all ParallelWebappClassLoader methods

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 06958d1 Enable graal reflection on all Parallel

[GitHub] [tomcat] stokito commented on pull request #325: Simplify ETag check

stokito commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-66650 Thank you, good points! I checked spec https://tools.ietf.org/html/rfc7232#section-2.3.2 and it looks like we still fine here because Tomcat in fact should do a weak comparison.

[GitHub] [tomcat] reschke commented on pull request #325: Simplify ETag check

reschke commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-661095956 The suggested change will cause incorrect behaviour, for instance "foobar" would match W/"foobar" That said, the existing code is broken as well,

[Bug 64616] Change ETag format to Nginx like

https://bz.apache.org/bugzilla/show_bug.cgi?id=64616 --- Comment #3 from Julian Reschke --- 3) So the ETag is not incorrect, it just might be suboptimal. 4) I would think your chances of this getting accepted would be bigger if you left the default handling as is, and added a way to configure so

[GitHub] [tomcat] stokito opened a new pull request #325: Simplify ETag check

stokito opened a new pull request #325: URL: https://github.com/apache/tomcat/pull/325 The If-None-Match header many have multiple ETags https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.26 Even if Tomcat returns a single ETag clients may want to send few of them. Since ET

[GitHub] [tomcat] stokito commented on pull request #324: Change ETag format to Nginx like

stokito commented on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661083626 > The format of the ETag is opaque, it is up to the caching instance to generate one Yes, you are right. In the same time too smart client may not send Ranges requests to do

[Bug 64616] Change ETag format to Nginx like

https://bz.apache.org/bugzilla/show_bug.cgi?id=64616 --- Comment #2 from Sergey Ponomarev --- 3) What exactly is "incorrect" about the current format? Weak ETag means that server tells to client that the resource can't be octal compatible. The client MAY decide not to send Range requests to down

Re: JDK 15 is now in Rampdown Phase Two

Many thanks for that Martin! Rgds,Rory On 20/07/2020 14:40, Martin Grigorov wrote: Hi Rory, Apache Tomcat build and tests are fine with JDK 15 b32 and JDK 16 b06 on x86_64 and aarch64 CPU architectures! Regards, Martin On Fri, Jul 17, 2020 at 12:03 PM Rory O'Donnell mailto:rory.odonn...@o

Re: JDK 15 is now in Rampdown Phase Two

Hi Rory, Apache Tomcat build and tests are fine with JDK 15 b32 and JDK 16 b06 on x86_64 and aarch64 CPU architectures! Regards, Martin On Fri, Jul 17, 2020 at 12:03 PM Rory O'Donnell wrote: > Hi Mark, > > *Per the JDK 15 schedule, we are in Rampdown Phase Two* *[1]* > Per the JDK Release Proc

[GitHub] [tomcat] michael-o commented on pull request #324: Change ETag format to Nginx like

michael-o commented on pull request #324: URL: https://github.com/apache/tomcat/pull/324#issuecomment-661045812 I do not consider your points to be valid: * The format of the ETag is opaque, it is upto the caching instance to generate one * We cannot guarantee any strong ETags because

[Bug 64616] Change ETag format to Nginx like

https://bz.apache.org/bugzilla/show_bug.cgi?id=64616 --- Comment #1 from Julian Reschke --- 1) You are combining two different things in a single change request, this is unwise. 2) It's not a "W3C" discussion; it's the IETF HTTP WG mailing list (which just happens to use a W3C list for historic

[Bug 64616] New: Change ETag format to Nginx like

https://bz.apache.org/bugzilla/show_bug.cgi?id=64616 Bug ID: 64616 Summary: Change ETag format to Nginx like Product: Tomcat 10 Version: unspecified Hardware: All OS: All Status: NEW Severity: normal

[GitHub] [tomcat] stokito opened a new pull request #324: Change ETag format to Nginx like

stokito opened a new pull request #324: URL: https://github.com/apache/tomcat/pull/324 Currently Tomcat 9 generates ETag like `W/"1047-157831529"` i.e. `Weak"Size-MTime in Milliseconds"`. This is incorrect ETag because it should be strong as for a static file i.e. octal compatibilit

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #4 from Remy Maucherat --- Yes, it would prevent using a key alias, which was the only reason for the wrapper. So I get FIPS mode prevents creative key manager uses then ? Idea: maybe don't use a wrapper if there's no key alias set

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #3 from Mark Thomas --- Doesn't the patch defeat the point of using Tomcat's JSSEKeyManager thereby breaking the use cases that required it in the first place? -- You are receiving this mail because: You are the assignee for the b

[tomcat] branch 9.0.x updated: Add missing code generation for remaining digester rules

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 09b8bea Add missing code generation for remaining d

[tomcat] branch master updated: Add missing code generation for remaining digester rules

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 07d6188 Add missing code generation for remaining

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 jfclere changed: What|Removed |Added CC||jfcl...@gmail.com --- Comment #2 from jfcler

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #1 from jfclere --- To configure I did the following: modutil -create -dbdir /home/jfclere/db touch /home/jfclere/db/secmod.db (for what?). modutil -fips true -dbdir /home/jfclere/db modutil -list -dbdir /home/jfclere/db (looks OK)

[Bug 64614] New: tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 Bug ID: 64614 Summary: tomcat doesn't work with JSSE FIPS-compliant with NSS Product: Tomcat 9 Version: 9.0.x Hardware: PC OS: Linux Status: NEW Severit