Re: Publishing EOL dates on whichversion?

Chris, On Thu, Aug 6, 2020 at 8:29 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > I'm wondering if we shouldn't add EOL dates to the "which version" page. > > The table on that page is very busy, but I think it would

[GitHub] [tomcat] MilovdZee commented on pull request #336: Fix SSHA documentation and cleanup the code

MilovdZee commented on pull request #336: URL: https://github.com/apache/tomcat/pull/336#issuecomment-670671787 Strange. Travis starts to fail... And at unrelated locations... This is an automated message from the Apache Git

Re: JDK 15 is now in the Initial Release Candidate Phase

Many Thanks Martin! Rgds,Rory On 07/08/2020 14:13, Martin Grigorov wrote: Hi Rory, The Apache Tomcat build and tests are fine with JDK 15+35-1559 and JDK 16-ea+9-365 both on x86_64 and aarch64 architectures! Regards, Martin On Fri, Aug 7, 2020 at 12:01 PM Rory O'Donnell mailto:rory.odonn.

[GitHub] [tomcat] MilovdZee commented on a change in pull request #336: fix SSHA by implementing SSHAv2

MilovdZee commented on a change in pull request #336: URL: https://github.com/apache/tomcat/pull/336#discussion_r467140671 ## File path: java/org/apache/catalina/realm/MessageDigestCredentialHandler.java ## @@ -32,16 +32,13 @@ /** * This credential handler supports the follo

[GitHub] [tomcat] MilovdZee commented on a change in pull request #336: fix SSHA by implementing SSHAv2

MilovdZee commented on a change in pull request #336: URL: https://github.com/apache/tomcat/pull/336#discussion_r467133771 ## File path: java/org/apache/catalina/realm/MessageDigestCredentialHandler.java ## @@ -32,16 +32,13 @@ /** * This credential handler supports the follo

[GitHub] [tomcat] MilovdZee commented on pull request #336: fix SSHA by implementing SSHAv2

MilovdZee commented on pull request #336: URL: https://github.com/apache/tomcat/pull/336#issuecomment-670590235 True. With SHA-1 it works. But the documentation does not enforce SHA-1. Even the code suggests that longer digests should be possible. But because of the implementation only alg

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #336: fix SSHA by implementing SSHAv2

ChristopherSchultz commented on a change in pull request #336: URL: https://github.com/apache/tomcat/pull/336#discussion_r467125860 ## File path: java/org/apache/catalina/realm/MessageDigestCredentialHandler.java ## @@ -32,16 +32,13 @@ /** * This credential handler supports

[GitHub] [tomcat] ChristopherSchultz edited a comment on pull request #336: fix SSHA by implementing SSHAv2

ChristopherSchultz edited a comment on pull request #336: URL: https://github.com/apache/tomcat/pull/336#issuecomment-670585072 While the documentation may have been misleading, the implementation was correct: the stored credential is a literal `{SSHA}` + `base64(concat(sha1(concat(passwor

[GitHub] [tomcat] ChristopherSchultz edited a comment on pull request #336: fix SSHA by implementing SSHAv2

ChristopherSchultz edited a comment on pull request #336: URL: https://github.com/apache/tomcat/pull/336#issuecomment-670585072 While the documentation may have been misleading, the implementation was correct: the stored credential is a literal `{SSHA}` + `base64(concat(sha1(concat(passwor

[GitHub] [tomcat] ChristopherSchultz commented on pull request #336: fix SSHA by implementing SSHAv2

ChristopherSchultz commented on pull request #336: URL: https://github.com/apache/tomcat/pull/336#issuecomment-670585072 While the documentation may have been misleading, the implementation was correct: the stored credential is a literal `{SSHA}` + `base64(concat(sha1(concat(password, salt

[GitHub] [tomcat] MilovdZee opened a new pull request #336: fix SSHA by implementing SSHAv2

MilovdZee opened a new pull request #336: URL: https://github.com/apache/tomcat/pull/336 For SSHA the order of salt and digest was reverse to the documentation. It actually was "{SSHA}". I added SSHAv2 to also allow for SHA-256 and other algorithms. I introduced {SSHAv2} for this. S

Re: JDK 15 is now in the Initial Release Candidate Phase

Hi Rory, The Apache Tomcat build and tests are fine with JDK 15+35-1559 and JDK 16-ea+9-365 both on x86_64 and aarch64 architectures! Regards, Martin On Fri, Aug 7, 2020 at 12:01 PM Rory O'Donnell wrote: > > Hi Mark, > > > *Per the JDK 15 schedule , we are now in the Initial Release Candidate

[GitHub] [tomcat] MilovdZee commented on pull request #335: Message digest credential handler fix

MilovdZee commented on pull request #335: URL: https://github.com/apache/tomcat/pull/335#issuecomment-670498590 oops. wrong master This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [tomcat] MilovdZee closed pull request #335: Message digest credential handler fix

MilovdZee closed pull request #335: URL: https://github.com/apache/tomcat/pull/335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] MilovdZee opened a new pull request #335: Message digest credential handler fix

MilovdZee opened a new pull request #335: URL: https://github.com/apache/tomcat/pull/335 For SSHA the order of salt and digest was reverse to the documentation. It was "{SSHA}". I added SSHA2 to also allow for SHA-256 and other algorithms. I introduced {SSHA2} for this. It could be

JDK 15 is now in the Initial Release Candidate Phase

Hi Mark, *Per the JDK 15 schedule  , we are now in the Initial Release Candidate Phase * ***Please advise if you have any open high priority issues.*** * Schedule for JDK 15 o *2020/08/06 Initial Release Candidate* o 2020/08/20 Final Release Candidate o 2020/09/15 General Av