Re: [Bug 56492] Avoid eclipse debugger pausing on uncaught exceptions when tomcat renews its threads

2020-08-12 Thread Felix Schumacher
Am 12.08.20 um 22:13 schrieb bugzi...@apache.org: > https://bz.apache.org/bugzilla/show_bug.cgi?id=56492 > > --- Comment #7 from ganjilgenap --- > Spam reverted and the account has been disabled. Felix - To unsubscribe, e-mail

[Bug 56492] Avoid eclipse debugger pausing on uncaught exceptions when tomcat renews its threads

2020-08-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56492 --- Comment #7 from ganjilgenap --- https://ganjilgenap.com/forum-prediksi-singapura/ Forum Syair sgp ,The prediction of the king of singapore lottery -- You are receiving this mail because: You are the assignee for the bug. -

[tomcat] branch master updated: Attempt to get JDK 8 smoke tests working on Github

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new cb52d5d Attempt to get JDK 8 smoke tests working

[tomcat] branch 9.0.x updated: Add in an ability to configure a custom class loader

2020-08-12 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 44c8234 Add in an ability to configure a custom c

[tomcat] branch master updated: It should probably do what JavaDoc says

2020-08-12 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 481e448 It should probably do what JavaDoc says

[tomcat] branch master updated: Add in an ability to configure a custom class loader

2020-08-12 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7cd2aaa Add in an ability to configure a custom

[tomcat] branch 8.5.x updated: Avoid potential NPEs introduced in smaller footprint for closed streams

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 0cf Avoid potential NPEs introduced in smaller

[tomcat] branch 9.0.x updated: Avoid potential NPEs introduced in smaller footprint for closed streams

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 868287c Avoid potential NPEs introduced in smaller

[tomcat] branch master updated: Avoid potential NPEs introduced in smaller footprint for closed streams

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 583b7ad Avoid potential NPEs introduced in small

buildbot success in on tomcat-7-trunk

2020-08-12 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1748 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSched

[GitHub] [tomcat] kamnani commented on pull request #331: Remove White Spaces and extra lines from the JSP files

2020-08-12 Thread GitBox
kamnani commented on pull request #331: URL: https://github.com/apache/tomcat/pull/331#issuecomment-672976308 I can remove this optimization for the pre tag, so pre tags are untouched. This is an automated message from the A

[tomcat] branch 7.0.x updated: Java 6 compat

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 89deceb Java 6 compat 89deceb is described below

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 8/12/20 10:02, Konstantin Kolinko wrote: > вт, 28 июл. 2020 г. в 16:55, Christopher Schultz > : >> >> All, >> >> I was looking at this PR[1] and wondering why we have huge swaths >> of CSS and HTML in a Java source file, instead of us

[tomcat] branch master updated: Added changes required for ppc64le support

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 30e0a59 Added changes required for ppc64le suppo

[GitHub] [tomcat] markt-asf merged pull request #326: Added changes required for ppc64le support

2020-08-12 Thread GitBox
markt-asf merged pull request #326: URL: https://github.com/apache/tomcat/pull/326 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-12 Thread Coty Sutherland
On Mon, Aug 10, 2020 at 11:46 AM Mark Thomas wrote: > Hi all, > > I'd like to propose removing all the functional spec pages from the > documentation web application. > > My reasoning for this proposal is, in short, that we aren't using or > maintaining these pages. > > I don't recall any discuss

[Bug 64427] --enable-preview no error in log

2020-08-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64427 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO

[Bug 64616] Change ETag format to Nginx like

2020-08-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64616 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 64619] Regression: Removal of scratchdir fallback affects existing code

2020-08-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64619 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[tomcat] branch master updated: When installing Maven artifacts, install the source as well

2020-08-12 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 46ee8f0 When installing Maven artifacts, instal

[Bug 64645] bin/service.bat doesn't handle wrongly configured JAVA_HOME

2020-08-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64645 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] 01/02: Further ETag fixes

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 21bb9a017a3c02bb55cd4cee73309e7365ab3692 Author: Mark Thomas AuthorDate: Wed Aug 12 12:46:00 2020 +0100 Further ETag

[tomcat] branch 7.0.x updated (6f96d40 -> c26cb86)

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 6f96d40 Fix indentation of versionLoggerListener.* new 21bb9a0 Further ETag fixes new c26cb86 Fix BZ 64645

[tomcat] 02/02: Fix BZ 64645 Use non-zero exit code if script fails

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c26cb86fcdd3d95c480ba6e2a4212c97f362aa5d Author: Mark Thomas AuthorDate: Wed Aug 12 16:12:04 2020 +0100 Fix BZ 64645

[tomcat] branch 8.5.x updated: Fix BZ 64645 Use non-zero exit code if script fails

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c493589 Fix BZ 64645 Use non-zero exit code if scr

[tomcat] branch 9.0.x updated: Fix BZ 64645 Use non-zero exit code if script fails

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new a5060b6 Fix BZ 64645 Use non-zero exit code if scr

[tomcat] branch master updated: Fix BZ 64645 Use non-zero exit code if script fails

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 75b284c Fix BZ 64645 Use non-zero exit code if s

[tomcat] branch 9.0.x updated: When installing Maven artifacts, install the source as well

2020-08-12 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 81baa13 When installing Maven artifacts, install

[GitHub] [tomcat] stokito opened a new pull request #338: Compare entity tag

2020-08-12 Thread GitBox
stokito opened a new pull request #338: URL: https://github.com/apache/tomcat/pull/338 Sorry for being annoying, this is just refactoring and performance optimization. Instead of parsing `If-Match` header to a HashSet we can make in-place comparison. Thus we can avoid of generation o

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-12 Thread Konstantin Kolinko
вт, 28 июл. 2020 г. в 16:55, Christopher Schultz : > > All, > > I was looking at this PR[1] and wondering why we have huge swaths of > CSS and HTML in a Java source file, instead of using e.g. JSP or some > other content-generation framework. I remember that I once read some praise for being able

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-12 Thread Keiichi Fujino
+1 2020年8月11日(火) 0:46 Mark Thomas : > Hi all, > > I'd like to propose removing all the functional spec pages from the > documentation web application. > > My reasoning for this proposal is, in short, that we aren't using or > maintaining these pages. > > I don't recall any discussion of these doc

[GitHub] [tomcat] stokito commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
stokito commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672871214 I reviewed and it looks fine and simpler. I just want to note here for history that according RFC 7232 sec 2.3.2 if resource's real etag is weak than strong comparison always faile

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 8/11/20 23:23, Igal Sapir wrote: > Chris, > > On Mon, Aug 10, 2020 at 12:20 PM Martin Grigorov > mailto:mgrigo...@apache.org>> wrote: > > > On Tue, Jul 28, 2020, 16:48 Christopher Schultz > > wrote: > >

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 8/11/20 15:04, Mark Thomas wrote: > On 11/08/2020 17:30, Michael Osipov wrote: >> Am 2020-08-10 um 17:46 schrieb Mark Thomas: >>> Hi all, >>> >>> I'd like to propose removing all the functional spec pages from >>> the documentation web appl

[GitHub] [tomcat] ChristopherSchultz commented on pull request #331: Remove White Spaces and extra lines from the JSP files

2020-08-12 Thread GitBox
ChristopherSchultz commented on pull request #331: URL: https://github.com/apache/tomcat/pull/331#issuecomment-672868967 Why tag me, specifically? This seems fragile. The `` tag-handling looks like it will only work if all the text is in the same text block. That's probably only goin

[GitHub] [tomcat] markt-asf closed pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
markt-asf closed pull request #337: URL: https://github.com/apache/tomcat/pull/337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] markt-asf commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672826428 After looking at b26ad77 I have reverted the addition of `useWeakComparisonWithIfMatch` and switched If-Match to strong comparison. I've also fixed the regression you identified.

[tomcat] branch 8.5.x updated: Further ETag fixes

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new bc379af Further ETag fixes bc379af is described be

[tomcat] branch 9.0.x updated: Further ETag fixes

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f380720 Further ETag fixes f380720 is described be

[tomcat] branch master updated: Further ETag fixes

2020-08-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c895def Further ETag fixes c895def is described

Re: [tomcat] branch master updated: Improve entity tag handling

2020-08-12 Thread Mark Thomas
On 11/08/2020 18:52, Mark Thomas wrote: > On 11/08/2020 18:06, Michael Osipov wrote: >> Am 2020-08-11 um 18:53 schrieb Mark Thomas: >>> On 11/08/2020 17:29, Michael Osipov wrote: Am 2020-08-11 um 16:52 schrieb ma...@apache.org: >>> >>> >>> > commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc

[GitHub] [tomcat] markt-asf commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672805585 Let me go an look at `b26ad77` in more detail. If the switch to weak comparison was introduced there then the case for fixing that and dropping `useWeakComparisonWithIfMatch` ent

[GitHub] [tomcat] stokito commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
stokito commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672785490 I added a commit that extracts common matching logic This is an automated message from the Apache Git Service. To

[Bug 64645] bin/service.bat doesn't handle wrongly configured JAVA_HOME

2020-08-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64645 --- Comment #4 from Jakub Moravec --- Hi Mark, changing the exit code is definitely the most important action here. That being said, my understanding is that at the moment, the validation doesn't recognize that JRE is referenced by JA

[GitHub] [tomcat] stokito commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
stokito commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672777683 yes, you are right and I wanted to discuss it latter. The PR fixes only one specific problem + small refactoring. The problem that I see is that the new `useWeakComparisonWithIfM

[GitHub] [tomcat] markt-asf commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672771845 In reviewing this PR I've noticed another issue. The ETag obtained from the resource is unconditionally made strong before the comparison but that conversion should depend on `us