buildbot failure in on tomcat-trunk

2020-08-25 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5377 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 7.0.x updated: Update Commons Codec to latest

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new df20351 Update Commons Codec to latest df20351 is

[tomcat] branch 8.5.x updated: Update Commons Codec to latest

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 34e7e21 Update Commons Codec to latest 34e7e21 is

[tomcat] branch 9.0.x updated: Update Commons Codec to latest

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new aa6bfae Update Commons Codec to latest aa6bfae is

[tomcat] branch master updated: Update Commons Codec to latest

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new edf149b Update Commons Codec to latest edf149b

Fwd: Security concern about Tomcat's default value for HSTS MaxAge

2020-08-25 Thread Dave Wichers
Per: https://tomcat.apache.org/tomcat-9.0-doc/config/filter.html#HTTP_Header_Security_Filter and https://tomcat.apache.org/tomcat-8.5-doc/config/filter.html#HTTP_Header_Security_Filter they both say: hstsMaxAgeSeconds - The max age value that should be used in the HSTS header. Negative values

[tomcat] branch 7.0.x updated: Update BCEL to 6.5.0 - code clean-up only

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 67eba90 Update BCEL to 6.5.0 - code clean-up only

[tomcat] branch 8.5.x updated: Update BCEL to 6.5.0 - code clean-up only

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4605360 Update BCEL to 6.5.0 - code clean-up only

[tomcat] branch 9.0.x updated: Update BCEL to 6.5.0 - code clean-up only

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1f2ce94 Update BCEL to 6.5.0 - code clean-up only

[tomcat] branch master updated: Update BCEL to 6.5.0 - code clean-up only

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f76278a Update BCEL to 6.5.0 - code clean-up

[GitHub] [tomcat] markt-asf commented on a change in pull request #344: Minor performance improvements

2020-08-25 Thread GitBox
markt-asf commented on a change in pull request #344: URL: https://github.com/apache/tomcat/pull/344#discussion_r476515349 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1144,6 +1144,12 @@ public static boolean normalize(MessageBytes uriMB, boolean

[Bug 63982] CombinedRealm makes assumptions about principal implementation

2020-08-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63982 --- Comment #9 from Michael Osipov --- (In reply to Ole Ostergaard from comment #8) > I'm hit by the upcoming removal of Realm#getRoles(). I was using the > Realm#getRoles() to get the Roles of a Principal. Is there an alternate way > to

[Bug 63982] CombinedRealm makes assumptions about principal implementation

2020-08-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63982 --- Comment #8 from Ole Ostergaard --- I'm hit by the upcoming removal of Realm#getRoles(). I was using the Realm#getRoles() to get the Roles of a Principal. Is there an alternate way to perform this action, in regard of the upcoming removal

[GitHub] [tomcat] martin-g commented on a change in pull request #332: Support sending the 100 continue response when the servlet reads the …

2020-08-25 Thread GitBox
martin-g commented on a change in pull request #332: URL: https://github.com/apache/tomcat/pull/332#discussion_r476411776 ## File path: test/org/apache/catalina/core/TestStandardContextValve.java ## @@ -182,4 +186,123 @@ public void requestDestroyed(ServletRequestEvent sre) {

[GitHub] [tomcat] martin-g opened a new pull request #344: Minor performance improvements

2020-08-25 Thread GitBox
martin-g opened a new pull request #344: URL: https://github.com/apache/tomcat/pull/344 I've noticed few small improvements to Tomcat code while profiling it with Java Flight Recorder and Yourkit. Each improvement is a separate commit with an explanation of the change. This PR is

Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-25 Thread Martin Grigorov
On Fri, Aug 21, 2020 at 9:22 PM Mark Thomas wrote: > Version 1.2.25 includes the following changes compared to 1.2.24 > > - Improvements to LibreSSL support > > - Improvements to HP_UX support > > Various other fixes and improvements. See the changelog for details. > > The proposed release

[tomcat] branch 9.0.x updated: Fix path validation when docBase="/"

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 29f259f Fix path validation when docBase="/"

[tomcat] branch 8.5.x updated: Fix path validation when docBase="/"

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 8b58ab5 Fix path validation when docBase="/"

[GitHub] [tomcat] rmannibucau commented on pull request #343: Ensure ExpressionFactory SPI registration is compatible with javax/jakarta API jar

2020-08-25 Thread GitBox
rmannibucau commented on pull request #343: URL: https://github.com/apache/tomcat/pull/343#issuecomment-679901115 @markt-asf can you point out the fixed release? seems https://mvnrepository.com/artifact/jakarta.el/jakarta.el-api/3.0.3 is affected by that so this is an issue ATM and as

[tomcat] branch master updated: Fix path validation when docBase="/"

2020-08-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 14cc26c Fix path validation when docBase="/"

[GitHub] [tomcat] markt-asf closed pull request #343: Ensure ExpressionFactory SPI registration is compatible with javax/jakarta API jar

2020-08-25 Thread GitBox
markt-asf closed pull request #343: URL: https://github.com/apache/tomcat/pull/343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #343: Ensure ExpressionFactory SPI registration is compatible with javax/jakarta API jar

2020-08-25 Thread GitBox
markt-asf commented on pull request #343: URL: https://github.com/apache/tomcat/pull/343#issuecomment-679875619 That version of the EL API is broken. It should be using ServiceLoader. This has been fixed in Jakarta EE. It is a general principle that the Tomcat project doesn't implement

[GitHub] [tomcat] rmannibucau opened a new pull request #343: Ensure ExpressionFactory SPI registration is compatible with javax/jakarta API jar

2020-08-25 Thread GitBox
rmannibucau opened a new pull request #343: URL: https://github.com/apache/tomcat/pull/343 https://github.com/javaee/el-spec/blob/master/api/src/main/java/javax/el/FactoryFinder.java#L151 only reads one line (jakarta el-api jar), tomcat license header breaks it and is not strictly