[GitHub] [tomcat] martin-g commented on pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-20 Thread GitBox
martin-g commented on pull request #395: URL: https://github.com/apache/tomcat/pull/395#issuecomment-748803155 @lanicc We agree that the code style should be consistent and that it should follow Java conventions. But we will do it only when editing such code for other functional changes.

[GitHub] [tomcat] martin-g closed pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-20 Thread GitBox
martin-g closed pull request #395: URL: https://github.com/apache/tomcat/pull/395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [tomcat] lanicc commented on pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-20 Thread GitBox
lanicc commented on pull request #395: URL: https://github.com/apache/tomcat/pull/395#issuecomment-748715252 I think code style should be unified,especially obvious ones like this This is an automated message from the Apa

Re: Replacement for Windows service wrapper (procrun)

2020-12-20 Thread Mladen Turk
On 19/12/2020 00:16, Christopher Schultz wrote: Mladen, On 12/18/20 15:10, Mladen Turk wrote: It can be used for various deployments. Apache Tomcat can use catalina.bat directly for running service ... more details at https://github.com/mturk/svcbatch/blob/master/docs/examples/apachetomcat.md