[GitHub] [tomcat] cklein05 commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
cklein05 commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852735518 For me, it's not about removing UserDatabaseRealm's live role querying feature. It's just that I need a way to deal with the UserDatabasePrincipal in my enhancement. Removing

[GitHub] [tomcat] markt-asf commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
markt-asf commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852405246 I'm fairly sure extending Generic Principal would work. Tx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[tomcat] branch main updated: Fix IDE nag - can use <> here

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3af4901 Fix IDE nag - can use <> here 3af4901 is

Re: [VOTE] Release Apache Tomcat Native 1.2.30

2021-06-01 Thread Igal Sapir
On Tue, Jun 1, 2021 at 2:53 AM Mark Thomas wrote: > Resending with correct subject line... > > Version 1.2.30 includes the following changes compared to 1.2.28 > > - Fix an issue where some Windows systems in some configurations would >only listen on IPv6 addresses on dual stack systems even

[GitHub] [tomcat] rmaucher commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
rmaucher commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852392506 Well, actually the MemoryUserDatabase will auto reload. I caught up to the thread on the user mailing list, which I didn't really pay attention to last week (I was away for

[tomcat] branch 8.5.x updated: Fix some indentation issues

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 73f7a18 Fix some indentation issues 73f7a18 is

[tomcat] branch 9.0.x updated: Fix some indentation issues

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 85710e5 Fix some indentation issues 85710e5 is

[tomcat] branch 10.0.x updated: Fix some indentation issues

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 8997577 Fix some indentation issues 8997577 is

[tomcat] branch main updated: Fix some indentation issues

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new ce8b5ae Fix some indentation issues ce8b5ae is

[GitHub] [tomcat] cklein05 commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
cklein05 commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852202676 Yes, it's static, but most other realms behave the same. You'll need to re-login in order to have role and group changes in effect. So, me and Mark were thinking removal of the

[tomcat] branch main updated: Ignore duplicate roles

2021-06-01 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1df0f91 Ignore duplicate roles 1df0f91 is described

[GitHub] [tomcat] rmaucher commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
rmaucher commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852194203 I reverted to examine things a bit more. I think groups should still work since the complete role list is constructed with their content in getPrincipal, however it also

[tomcat] branch main updated (b142e36 -> ebdbb96)

2021-06-01 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from b142e36 Fix BZ 65342. Correct regression in fix for BZ 65262. add ebdbb96 Revert changes for now No new

[GitHub] [tomcat] rmaucher commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
rmaucher commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852172392 Ah ok, I did that, since getPassword was a problem that needed fixing. However, I think this does not work and I'll have to revert this: I don't see how groups are still handled,

[tomcat] branch 8.5.x updated: Fix BZ 65342. Correct regression in fix for BZ 65262.

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c39dd74 Fix BZ 65342. Correct regression in fix

[tomcat] branch 9.0.x updated: Fix BZ 65342. Correct regression in fix for BZ 65262.

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b0570e2 Fix BZ 65342. Correct regression in fix

[tomcat] branch 10.0.x updated: Fix BZ 65342. Correct regression in fix for BZ 65262.

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 48cbc0f Fix BZ 65342. Correct regression in fix

[tomcat] branch main updated: Fix BZ 65342. Correct regression in fix for BZ 65262.

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b142e36 Fix BZ 65342. Correct regression in fix for

[GitHub] [tomcat] cklein05 edited a comment on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
cklein05 edited a comment on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852011219 Rémy, thanks for pushing this. Primarily, I like to get rid of class `UserDatabaseRealm.UserDatabasePrincipal`, which was introduced as a replacement for

[GitHub] [tomcat] cklein05 commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
cklein05 commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852011219 Rémy, thanks for pushing this. Primarily, I like to get rid of class `UserDatabaseRealm.UserDatabasePrincipal`, which was introduced as a replacement for

[GitHub] [tomcat] rmaucher commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
rmaucher commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-852001319 I pushed this in the main branch, but there the backport question since it clearly changes the behavior and it could hurt someone actually using the live updating capability.

[tomcat] branch main updated: Simplify roles handling in user database realm

2021-06-01 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new bfca3f8 Simplify roles handling in user database

[VOTE] Release Apache Tomcat Native 1.2.30

2021-06-01 Thread Mark Thomas
Resending with correct subject line... Version 1.2.30 includes the following changes compared to 1.2.28 - Fix an issue where some Windows systems in some configurations would only listen on IPv6 addresses on dual stack systems even though configured to listen on both IPv6 and IPv4

svn commit: r48032 - in /dev/tomcat/tomcat-connectors/native/1.2.30: ./ binaries/ source/

2021-06-01 Thread markt
Author: markt Date: Tue Jun 1 09:48:53 2021 New Revision: 48032 Log: Upload Tomcat Native 1.2.30 for voting Added: dev/tomcat/tomcat-connectors/native/1.2.30/ dev/tomcat/tomcat-connectors/native/1.2.30/binaries/

buildbot success in on tomcat-9.0.x

2021-06-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/4 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r48031 - /dev/tomcat/tomcat-connectors/native/1.2.29/

2021-06-01 Thread markt
Author: markt Date: Tue Jun 1 09:40:24 2021 New Revision: 48031 Log: Tomcat Native 1.2.29 release cancelled Removed: dev/tomcat/tomcat-connectors/native/1.2.29/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[tomcat-native] 01/01: Tag 1.2.30

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 1.2.30 in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 8b1baaa1af07c07a9f44f9adb31b7dbdabd6ff39 Author: Mark Thomas AuthorDate: Tue Jun 1 10:37:48 2021 +0100 Tag

[tomcat-native] tag 1.2.30 created (now 8b1baaa)

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 1.2.30 in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. at 8b1baaa (commit) This tag includes the following new commits: new 8b1baaa Tag 1.2.30 The 1 revisions

[tomcat-native] branch main updated: Add best guess for 1.2.30 release date

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/main by this push: new 7aba956 Add best guess for 1.2.30 release

[GitHub] [tomcat] rmaucher commented on pull request #420: UserDatabaseRealm does not rely on cached roles only

2021-06-01 Thread GitBox
rmaucher commented on pull request #420: URL: https://github.com/apache/tomcat/pull/420#issuecomment-851974510 I'm quite sure this was done on purpose [want to be able to lock away someone instantly] but this probably does not make much sense as the behavior cannot become consistent.

[Bug 65329] Incorrect handling for WINVER in NMAKEmakefile

2021-06-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65329 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat-native] branch main updated: Fix BZ 65329. Correct handling of WINVER constants. Add newer OSs.

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/main by this push: new b3b2ccf Fix BZ 65329. Correct handling of

[tomcat] branch 8.5.x updated: LocalString_xx.properties are UTF-8 when filtered

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 75f3301 LocalString_xx.properties are UTF-8 when

[tomcat] branch 9.0.x updated: LocalString_xx.properties are UTF-8 when filtered

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new daf3b8a LocalString_xx.properties are UTF-8 when

[tomcat] branch 10.0.x updated: LocalString_xx.properties are UTF-8 when filtered

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new d6220c2 LocalString_xx.properties are UTF-8

[tomcat] branch main updated: LocalString_xx.properties are UTF-8 when filtered

2021-06-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f386297 LocalString_xx.properties are UTF-8 when