[GitHub] [tomcat] aooohan closed pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header

2022-08-24 Thread GitBox
aooohan closed pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header URL: https://github.com/apache/tomcat/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] aooohan commented on pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header

2022-08-24 Thread GitBox
aooohan commented on PR #531: URL: https://github.com/apache/tomcat/pull/531#issuecomment-1226801420 The implementation is a bit ugly, continue to optimize later, close first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-24 Thread GitBox
aooohan commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r954498342 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat] aooohan commented on pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-24 Thread GitBox
aooohan commented on PR #542: URL: https://github.com/apache/tomcat/pull/542#issuecomment-1226672348 If there are no problems, I will merge it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Patch for mod_jk bug 65901 - request for comment

2022-08-24 Thread Stefan Mayr
Hi, some time ago I reported a mod_jk bug for HEAD requests (#65901). This week we found another application thats runs into exactly the same issue for a different response code. So I repeated some tests and updated my patch/pull request to match the current main branch. Since I did not get any

[Bug 65901] HTTP 401 response for a HEAD request violates HTTP spec by including a body

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65901 --- Comment #4 from Stefan Mayr --- Github pull request was also updated: https://github.com/apache/tomcat-connectors/pull/5 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 65901] HTTP 401 response for a HEAD request violates HTTP spec by including a body

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65901 --- Comment #3 from Stefan Mayr --- Created attachment 38376 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38376=edit Attempt to fix bug 65901 against 1.2.49 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 65901] HTTP 401 response for a HEAD request violates HTTP spec by including a body

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65901 --- Comment #2 from Stefan Mayr --- This week we found this issue is also present for other status codes like 403, 404, 405 etc. Test wird custom JSPs like <% response.sendError(401, "Authenticate"); %> -- You are receiving this mail

[tomcat] branch 9.0.x updated: Fix typo

2022-08-24 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 816b1f295b Fix typo 816b1f295b is described below

[tomcat] branch 8.5.x updated: Fix typo

2022-08-24 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 481e70daed Fix typo 481e70daed is described below

Re: jakarta.el, useless getResource?

2022-08-24 Thread Romain Manni-Bucau
Hi Went ahead and created https://github.com/apache/tomcat/pull/547 (if it helps) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

[tomcat] branch 10.0.x updated: Fix typo

2022-08-24 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 6167517453 Fix typo 6167517453 is described

[tomcat] branch main updated: Remove deprecated code.

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 378bb27c4f Remove deprecated code. 378bb27c4f is

[GitHub] [tomcat] markt-asf closed pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

2022-08-24 Thread GitBox
markt-asf closed pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names URL: https://github.com/apache/tomcat/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] markt-asf commented on pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

2022-08-24 Thread GitBox
markt-asf commented on PR #535: URL: https://github.com/apache/tomcat/pull/535#issuecomment-1225720989 AS per previous comment, merged manually. Thanks very much for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[tomcat] branch 8.5.x updated: Manually merge #535 - improve error message for duplicate fragments

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9a5056d402 Manually merge #535 - improve error

[tomcat] branch 9.0.x updated: Manually merge #535 - improve error message for duplicate fragments

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7e2a5b2028 Manually merge #535 - improve error

[tomcat] branch 10.0.x updated: Manually merge #535 - improve error message for duplicate fragments

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 1fac2707f3 Manually merge #535 - improve error

[tomcat] branch main updated: Manually merge #535 - improve error message for duplicate fragments

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 0e323eb32b Manually merge #535 - improve error

[Bug 66236] New: maxSavePostSize=-1 crashes ssl renegotiation

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66236 Bug ID: 66236 Summary: maxSavePostSize=-1 crashes ssl renegotiation Product: Tomcat 10 Version: 10.0.22 Hardware: All OS: Linux Status: NEW Severity:

[GitHub] [tomcat] markt-asf commented on pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

2022-08-24 Thread GitBox
markt-asf commented on PR #535: URL: https://github.com/apache/tomcat/pull/535#issuecomment-1225666701 Thanks for the PR. I like it. I'm probably being over cautious but I'd like to retain backwards compatibility for the existing methods on WebXml - at least up to 10.0.x anyway. Therefore,

[Bug 66235] Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode)

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66235 --- Comment #5 from Remy Maucherat --- Thanks for the additional tweaks. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[tomcat] branch 9.0.x updated: Additional tweaks for 66235

2022-08-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 650d3ccee1 Additional tweaks for 66235 650d3ccee1

[tomcat] branch 10.0.x updated: Additional tweaks for 66235

2022-08-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 6b7157529f Additional tweaks for 66235 6b7157529f

[tomcat] branch main updated: Additional tweaks for 66235

2022-08-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 14c0dbbc79 Additional tweaks for 66235 14c0dbbc79 is

svn commit: r1903660 - /tomcat/site/trunk/docs/whoweare.html

2022-08-24 Thread lihan
Author: lihan Date: Wed Aug 24 11:50:33 2022 New Revision: 1903660 URL: http://svn.apache.org/viewvc?rev=1903660=rev Log: build whoweare.html docs Modified: tomcat/site/trunk/docs/whoweare.html Modified: tomcat/site/trunk/docs/whoweare.html URL:

[Bug 66235] Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode)

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66235 --- Comment #4 from matthias.hil...@mgm-tp.com --- Thanks for this quick fix. When looking at the commit I have 2 remarks. I think there are still some small differences, that might result in different behavior: BeanELResolver: "is" is only

[tomcat] branch 8.5.x updated: Optimize comment

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ec43c90d92 Optimize comment ec43c90d92 is

[tomcat] branch 9.0.x updated: Optimize comment

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6feca44d10 Optimize comment 6feca44d10 is

[tomcat] branch 10.0.x updated: Optimize comment

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new dec782b578 Optimize comment dec782b578 is

[GitHub] [tomcat] markt-asf commented on pull request #543: Optimize comment

2022-08-24 Thread GitBox
markt-asf commented on PR #543: URL: https://github.com/apache/tomcat/pull/543#issuecomment-122992 Thanks. I'll back-port this to earlier Tomcat versions as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[tomcat] branch main updated: Optimize comment

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new aef9666ed6 Optimize comment aef9666ed6 is described

[GitHub] [tomcat] markt-asf merged pull request #543: Optimize comment

2022-08-24 Thread GitBox
markt-asf merged PR #543: URL: https://github.com/apache/tomcat/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf closed pull request #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount

2022-08-24 Thread GitBox
markt-asf closed pull request #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount URL: https://github.com/apache/tomcat/pull/546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] markt-asf commented on pull request #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount

2022-08-24 Thread GitBox
markt-asf commented on PR #546: URL: https://github.com/apache/tomcat/pull/546#issuecomment-122269 Sorry - didn't see this PR. I've just applied the same fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[Bug 66233] when set maxCookieCount 1, request has 5 cookies, the response message is "null"

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66233 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 8.5.x updated: Fix 66233 - include error message with 400 response for too many cookies

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d50929c327 Fix 66233 - include error message with

[tomcat] branch 9.0.x updated: Fix 66233 - include error message with 400 response for too many cookies

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0461717fc0 Fix 66233 - include error message with

[tomcat] branch 10.0.x updated: Fix 66233 - include error message with 400 response for too many cookies

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 5c7a6dfac2 Fix 66233 - include error message

[tomcat] branch main updated: Fix 66233 - include error message with 400 response for too many cookies

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4f9dc7f4a0 Fix 66233 - include error message with

svn commit: r1903658 - /tomcat/site/trunk/xdocs/whoweare.xml

2022-08-24 Thread lihan
Author: lihan Date: Wed Aug 24 10:25:26 2022 New Revision: 1903658 URL: http://svn.apache.org/viewvc?rev=1903658=rev Log: add new committer - Han Li Modified: tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/xdocs/whoweare.xml URL:

[tomcat] branch 9.0.x updated: Silence IDE warnings

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c617e92c01 Silence IDE warnings c617e92c01 is

[tomcat] branch 10.0.x updated: Silence IDE warnings

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 082c8d2bf2 Silence IDE warnings 082c8d2bf2 is

[tomcat] branch main updated: Silence IDE warnings

2022-08-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 141c4b9dab Silence IDE warnings 141c4b9dab is

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #10 from Mark Thomas --- Thanks for the offer of a patch. Please go ahead. -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 66235] Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode)

2022-08-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66235 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [DISCUSS] MessageBytes refactoring

2022-08-24 Thread Han Li
> 2022年8月24日 16:16,Mark Thomas 写道: > > On 24/08/2022 09:08, Rémy Maucherat wrote: >> On Tue, Aug 23, 2022 at 10:43 PM Mark Thomas wrote: >>> >>> Hi all, >>> >>> I've been looking at a fix for bug 66196. My ideas so far have revolved >>> around MessageBytes but the solutions are being made

Re: [DISCUSS] MessageBytes refactoring

2022-08-24 Thread Mark Thomas
On 24/08/2022 09:08, Rémy Maucherat wrote: On Tue, Aug 23, 2022 at 10:43 PM Mark Thomas wrote: Hi all, I've been looking at a fix for bug 66196. My ideas so far have revolved around MessageBytes but the solutions are being made more complex by the current behaviour of MessageBytes in some

Re: [DISCUSS] MessageBytes refactoring

2022-08-24 Thread Rémy Maucherat
On Tue, Aug 23, 2022 at 10:43 PM Mark Thomas wrote: > > Hi all, > > I've been looking at a fix for bug 66196. My ideas so far have revolved > around MessageBytes but the solutions are being made more complex by the > current behaviour of MessageBytes in some cases. > > For example (I'm using

[tomcat] branch 9.0.x updated: Fix various issues with the bean resolver used for Graal

2022-08-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ce2ba5edab Fix various issues with the bean

[tomcat] branch 10.0.x updated: Fix various issues with the bean resolver used for Graal

2022-08-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 1394276a4b Fix various issues with the bean

[tomcat] branch main updated: Fix various issues with the bean resolver used for Graal

2022-08-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 93594a5136 Fix various issues with the bean resolver