svn commit: r1905391 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

2022-11-18 Thread huxing
Author: huxing Date: Sat Nov 19 06:03:22 2022 New Revision: 1905391 URL: http://svn.apache.org/viewvc?rev=1905391&view=rev Log: Add ApacheCon Asia 2022 slides Modified: tomcat/site/trunk/docs/presentations.html tomcat/site/trunk/xdocs/presentations.xml Modified: tomcat/site/trunk/docs/pr

[GitHub] [tomcat-maven-plugin] JLLeitschuh opened a new pull request, #39: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2022-11-18 Thread GitBox
JLLeitschuh opened a new pull request, #39: URL: https://github.com/apache/tomcat-maven-plugin/pull/39 # Security Vulnerability Fix This pull request fixes a Temporary File Information Disclosure Vulnerability, which existed in this project. ## Preamble The system te

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread Christopher Schultz
Mark, On 11/18/22 10:38, Mark Thomas wrote: I've just found the comment I missed the first time. This has already been implemented. You need to set the following: Connector   bindOnInit="false" Service   gracefulStopAwaitMillis="2" This assumes you are using the default keep-alive tim

Re: [VOTE] Release Apache Tomcat 8.5.84

2022-11-18 Thread Christopher Schultz
Han, On 11/17/22 05:28, Han Li wrote: 2022年11月17日 17:52,Mark Thomas 写道: On 17/11/2022 08:23, Han Li wrote: 2022年11月17日 16:08,Mark Thomas 写道: On 17/11/2022 04:04, Han Li wrote: I think that I encounter a problem, shown below: org.apache.jasper.JasperException: Unable to compile class for

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread M. Thiim
Hi Mark, ahh missed that - I just tried, you are right, it seems to give exactly what we want... closing connections on next incoming request when possible and otherwise waiting for the shutdown to complete. Thanks a lot and have a nice weekend. - M Den fre. 18. nov. 2022 kl. 18.49 skrev Mark

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread Mark Thomas
On 18/11/2022 17:40, M. Thiim wrote: Hi Mark, sorry I'm not sure what you mean by "read the rest of the thread"... My "I just tried this..." was in response to your suggestion of using the bindOnInit and gracefulStopAwaitMillis parameters. Thx! The behaviour you describe is consistent with bind

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread M. Thiim
Hi Mark, sorry I'm not sure what you mean by "read the rest of the thread"... My "I just tried this..." was in response to your suggestion of using the bindOnInit and gracefulStopAwaitMillis parameters. Thx! Den fre. 18. nov. 2022 kl. 18.35 skrev Mark Thomas : > Please read the rest of the thre

Plans for Tomcat 11 milestone releases

2022-11-18 Thread Mark Thomas
Hi all, It is still very in the Jakarta EE 11 development process but we already have some changes in the main branch. Therefore I intend to start producing milestone releases from the December release round. Mark - To unsub

[tomcat] branch main updated: Update ErrorData for new error dispatch attribute

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 41258a7455 Update ErrorData for new error dispatch at

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread Mark Thomas
Please read the rest of the thread. On 18/11/2022 17:24, M. Thiim wrote: Hi Mark, thanks, I just tried this. It does cause the server to insert a 20 second delay on shutdown and I get this message in the log: 18-Nov-2022 18:16:29.777 INFO [main] org.apache.coyote.AbstractProtocol.awaitConnecti

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread M. Thiim
Hi Mark, thanks, I just tried this. It does cause the server to insert a 20 second delay on shutdown and I get this message in the log: 18-Nov-2022 18:16:29.777 INFO [main] org.apache.coyote.AbstractProtocol.awaitConnectionsClose Waiting [20,000] milliseconds for existing connections to ["http-ni

[tomcat] branch main updated: Additional change required to support new error dispatch attribute

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 511d7256e5 Additional change required to support new

[tomcat] branch 8.5.x updated: Formatting, no functional change.

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1f5898c840 Formatting, no functional change. 1f5898

[tomcat] branch 9.0.x updated: Formatting, no functional change.

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3720b3d6cc Formatting, no functional change. 3720b3

[tomcat] branch 10.1.x updated: Formatting, no functional change.

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 0fb8c17e43 Formatting, no functional change. 0fb8

[tomcat] branch main updated (f8bf4920ba -> c3e7054284)

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from f8bf4920ba Revert accidental commit new 570c2e6aea Next iteration of the Servlet spec currently planned to be 6.1

[tomcat] 03/03: Add support for jakarta.servlet.error.query_string on error dispatches

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c3e7054284aafd054e86f9ceccb19c9dd7aac69a Author: Mark Thomas AuthorDate: Fri Nov 18 16:15:11 2022 + Add support fo

[tomcat] 02/03: Formatting, no functional change.

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 76ec06a960884034267f6af625c7c29b840d8485 Author: Mark Thomas AuthorDate: Fri Nov 18 16:10:58 2022 + Formatting, no

[tomcat] 01/03: Next iteration of the Servlet spec currently planned to be 6.1

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 570c2e6aea3d2cb150a543111c7527c1b5be800c Author: Mark Thomas AuthorDate: Fri Nov 18 16:09:02 2022 + Next iteration

[tomcat] branch 8.5.x updated: Improve the docs for bindOnInit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3e2142e0b7 Improve the docs for bindOnInit 3e2142e0

[tomcat] branch 9.0.x updated: Revert accidental commit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 93d678369e Revert accidental commit 93d678369e is d

[tomcat] branch 10.1.x updated: Revert accidental commit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 32752096ae Revert accidental commit 32752096ae is

[tomcat] branch main updated: Revert accidental commit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f8bf4920ba Revert accidental commit f8bf4920ba is des

[tomcat] branch 9.0.x updated: Improve the docs for bindOnInit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2908b4931a Improve the docs for bindOnInit 2908b493

[tomcat] branch 10.1.x updated: Improve the docs for bindOnInit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 841cb9b0d4 Improve the docs for bindOnInit 841cb9

[tomcat] branch main updated: Improve the docs for bindOnInit

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c955e1238a Improve the docs for bindOnInit c955e1238a

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread Mark Thomas
I've just found the comment I missed the first time. This has already been implemented. You need to set the following: Connector bindOnInit="false" Service gracefulStopAwaitMillis="2" This assumes you are using the default keep-alive timeout of 20s. If not, adjust gracefulStopAwaitMi

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread Mark Thomas
PRs are always welcome. From the description provided, I think more use of the existing graceful shutdown could be made. I am also looking at whether a slightly broader refactoring is called for as there looks to be scope for better alignment between pause, stop and graceful stop. Mark On

Re: [VOTE] Release Apache Tomcat 8.5.84

2022-11-18 Thread Mark Thomas
On 16/11/2022 16:03, Christopher Schultz wrote: The proposed 8.5.84 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.84 (stable) Unit tests pass on Linux, MacOS and Windows. Mark - To unsubscr

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread M. Thiim
Hi Mark Great! I've actually made an experimental patch that fixes it, but it's perhaps not completely clean. To get the behavior the waiting needs to happen after the server has stopped accepting new connections, this seems to be the pause-phase. But the Http11Processoer rejects incoming requests

Re: [VOTE] Release Apache Tomcat 8.5.84

2022-11-18 Thread Rémy Maucherat
On Thu, Nov 17, 2022 at 10:52 AM Mark Thomas wrote: > > On 17/11/2022 08:23, Han Li wrote: > > > > > >> 2022年11月17日 16:08,Mark Thomas 写道: > >> > >> On 17/11/2022 04:04, Han Li wrote: > >>> I think that I encounter a problem, shown below: > >>> org.apache.jasper.JasperException: Unable to compile

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 --- Comment #6 from Norimasa Yamamoto --- Thank you for supporting. I‘ve copied this issue to ASF Jira (Commons Daemon proj.). https://issues.apache.org/jira/browse/DAEMON-450 -- You are receiving this mail because: You are the assignee for

[tomcat] branch main updated: Refactor context around implicit session

2022-11-18 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 8cff3d4a24 Refactor context around implicit session 8c

Re: Tomcat doesn't gracefully close keep-alive connections

2022-11-18 Thread Mark Thomas
On 17/11/2022 19:39, M. Thiim wrote: Hi, We have observed that Tomcat doesn't gracefully close keep-alive connections. Tomcat waits for already started requests to complete, but once those are done, Tomcat will close all connections immediately, irrespective of any configured keepAliveTimeout. T

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 --- Comment #5 from Mark Thomas --- (In reply to Norimasa Yamamoto from comment #4) > (In reply to Mark Thomas from comment #3) > > I'll set you up with an account. > > Can I use you email as user name or do you prefer something else? > > Than

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 --- Comment #4 from Norimasa Yamamoto --- (In reply to Mark Thomas from comment #3) > I'll set you up with an account. > Can I use you email as user name or do you prefer something else? Thank you! Please use my email as user name. -- You ar

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 --- Comment #3 from Mark Thomas --- (In reply to Norimasa Yamamoto from comment #2) > Yes I know, but... how to signup to ASF Jira? > > > Note that public signup for this Jira instance is disabled. > > You must contact private@PROJECT_ID.apach

[tomcat] branch 8.5.x updated: Fix bug with HTTP/2 stream reset and active connection count

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 75995d581e Fix bug with HTTP/2 stream reset and act

[tomcat] branch 9.0.x updated: Fix bug with HTTP/2 stream reset and active connection count

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 97bfdd74aa Fix bug with HTTP/2 stream reset and act

[tomcat] branch 10.1.x updated: Fix bug with HTTP/2 stream reset and active connection count

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 700d7d96d3 Fix bug with HTTP/2 stream reset and a

[tomcat] branch main updated: Fix bug with HTTP/2 stream reset and active connection count

2022-11-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 2362172583 Fix bug with HTTP/2 stream reset and activ

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 --- Comment #2 from Norimasa Yamamoto --- Yes I know, but... how to signup to ASF Jira? > Note that public signup for this Jira instance is disabled. > You must contact private@PROJECT_ID.apache.org mailing list > and provide your preferred us

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 Mark Thomas changed: What|Removed |Added OS||All Resolution|---

[Bug 66354] Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 Norimasa Yamamoto changed: What|Removed |Added OS||Windows 7 -- You are receiving th

[Bug 66354] New: Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs

2022-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66354 Bug ID: 66354 Summary: Invoked "bin\tomcat9 //US/Tomcat9", logs directory will be inserted two unwanted two ACLs Product: Tomcat 9 Version: 9.0.69 Hardware: PC