Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Rainer Jung
Am 10.02.23 um 22:04 schrieb Christopher Schultz: Rainer, On 2/10/23 15:08, Rainer Jung wrote: Am 10.02.23 um 17:05 schrieb Christopher Schultz: Mark, I'm having trouble building on MacOS Ventura. I downloaded the source tarball file from https://dist.apache.org/repos/dist/dev/tomcat/tomcat

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Christopher Schultz
Rainer, On 2/10/23 15:08, Rainer Jung wrote: Am 10.02.23 um 17:05 schrieb Christopher Schultz: Mark, I'm having trouble building on MacOS Ventura. I downloaded the source tarball file from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.3/source/tomcat-native-2.0.3

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Christopher Schultz
Rainer, On 2/10/23 15:08, Rainer Jung wrote: Am 10.02.23 um 17:05 schrieb Christopher Schultz: Mark, I'm having trouble building on MacOS Ventura. I downloaded the source tarball file from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.3/source/tomcat-native-2.0.3

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Rainer Jung
Am 10.02.23 um 17:05 schrieb Christopher Schultz: Mark, I'm having trouble building on MacOS Ventura. I downloaded the source tarball file from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.3/source/tomcat-native-2.0.3-src.tar.gz, untarred it, and then ran the foll

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Christopher Schultz
Mark, On 2/10/23 14:30, Mark Thomas wrote: On 10/02/2023 16:05, Christopher Schultz wrote: Mark, I'm having trouble building on MacOS Ventura. I've just tested building on Ventura and don't see that issue on Intel or M1. Everything is up to date (OS, Xcode, APR (homebrew) and OpenSSL (home

[GitHub] [tomcat] tbw777 commented on pull request #590: Closing ExecutorService with try-with-resources and other

2023-02-10 Thread via GitHub
tbw777 commented on PR #590: URL: https://github.com/apache/tomcat/pull/590#issuecomment-1426250991 @aooohan ``` ExecutorService ... Since: 19 ... default void close() { ``` -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Mark Thomas
On 10/02/2023 16:05, Christopher Schultz wrote: Mark, I'm having trouble building on MacOS Ventura. I've just tested building on Ventura and don't see that issue on Intel or M1. Everything is up to date (OS, Xcode, APR (homebrew) and OpenSSL (homebrew). I can only guess some sort of local

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Christopher Schultz
Mark, I'm having trouble building on MacOS Ventura. I downloaded the source tarball file from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.3/source/tomcat-native-2.0.3-src.tar.gz, untarred it, and then ran the following commands: $ ./configure --with-apr=/usr/lo

Re: [VOTE] Release Apache Tomcat Native 1.2.36

2023-02-10 Thread Vasileios Mourikis
[X] Stable, go ahead and release +1 Fedora 35 On Fri, Feb 10, 2023 at 4:26 PM Rémy Maucherat wrote: > On Wed, Feb 8, 2023 at 5:43 PM Mark Thomas wrote: > > > > Version 1.2.36 includes the following changes compared to 1.2.35 > > > > - The windows binaries in this release have been built with

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Rémy Maucherat
On Wed, Feb 8, 2023 at 4:46 PM Mark Thomas wrote: > > The key differences of version 2.0.3 compared to 2.0.2 are: > > - The windows binaries in this release have been built with OpenSSL >3.0.8 and APR 1.7.2 > > The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but > can be used

Re: [VOTE] Release Apache Tomcat Native 1.2.36

2023-02-10 Thread Rémy Maucherat
On Wed, Feb 8, 2023 at 5:43 PM Mark Thomas wrote: > > Version 1.2.36 includes the following changes compared to 1.2.35 > > - The windows binaries in this release have been built with OpenSSL >1.1.1t and APR 1.7.2 > > The proposed release artefacts can be found at [1], > and the build was done

Re: [VOTE] Release Apache Tomcat Native 1.2.36

2023-02-10 Thread Dimitris Soumis
[X] Stable, go ahead and release +1 for stable release All unit tests pass on Fedora 36. Builds with deprecation warnings. gcc version 12.2.1 apr version 1.7.2 openssl version 3.0.8 On Wed, Feb 8, 2023 at 6:50 PM Mark Thomas wrote: > Version 1.2.36 includes the following changes compared to 1

[tomcat-native] branch 1.2.x updated: Calculate year rather than manually updating

2023-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 1.2.x in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/1.2.x by this push: new 416be6364 Calculate year rather than manuall

[tomcat-native] branch main updated: Calculate year rather than manually updating

2023-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/main by this push: new 967644f18 Calculate year rather than manually

[GitHub] [tomcat-native] markt-asf commented on pull request #16: Update build.xml with new year

2023-02-10 Thread via GitHub
markt-asf commented on PR #16: URL: https://github.com/apache/tomcat-native/pull/16#issuecomment-1425572722 Thanks for spotting this. Better to automate this as I'll just forget to update it again next year. I'll copy the config to do this from the Tomcat 11.0.x build. -- This is an au

[GitHub] [tomcat-native] markt-asf closed pull request #16: Update build.xml with new year

2023-02-10 Thread via GitHub
markt-asf closed pull request #16: Update build.xml with new year URL: https://github.com/apache/tomcat-native/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [tomcat-native] dsoumis opened a new pull request, #16: Update build.xml with new year

2023-02-10 Thread via GitHub
dsoumis opened a new pull request, #16: URL: https://github.com/apache/tomcat-native/pull/16 Update build.xml with new year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [tomcat] branch 10.1.x updated: Revert TestAsyncContextImpl.

2023-02-10 Thread Han Li
> On Feb 10, 2023, at 17:24, li...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > lihan pushed a commit to branch 10.1.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/10.1.x

[tomcat] branch main updated: Revert TestAsyncContextImpl.

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1b90313d4c Revert TestAsyncContextImpl. 1b90313d4c is

[tomcat] branch 10.1.x updated: Revert TestAsyncContextImpl.

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5bff34bfec Revert TestAsyncContextImpl. 5bff34bfe

[tomcat] branch 9.0.x updated: Revert TestAsyncContextImpl.

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 17e7c48348 Revert TestAsyncContextImpl. 17e7c48348

[tomcat] branch 9.0.x updated: Replace manually invoke close method with try-with-resources. (#590)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 90e6b33286 Replace manually invoke close method wit

[tomcat] branch 10.1.x updated: Replace manually invoke close method with try-with-resources. (#590)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new a890a8f8eb Replace manually invoke close method w

[tomcat] branch main updated: Replace manually invoke close method with try-with-resources. (#590)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 03ae0436fa Replace manually invoke close method with

[GitHub] [tomcat] aooohan merged pull request #590: Closing ExecutorService with try-with-resources and other

2023-02-10 Thread via GitHub
aooohan merged PR #590: URL: https://github.com/apache/tomcat/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] [tomcat] aooohan commented on a diff in pull request #590: Closing ExecutorService with try-with-resources and other

2023-02-10 Thread via GitHub
aooohan commented on code in PR #590: URL: https://github.com/apache/tomcat/pull/590#discussion_r1102455984 ## java/org/apache/tomcat/util/http/fileupload/util/Streams.java: ## @@ -106,12 +106,12 @@ public static long copy(final InputStream inputStream, }

[tomcat] branch 8.5.x updated: Improve: Reuse the instance of StringBuilder to avoid duplicate object creation (#588)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9a56b27279 Improve: Reuse the instance of StringBui

[tomcat] branch 9.0.x updated: Improve: Reuse the instance of StringBuilder to avoid duplicate object creation (#588)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7ba2e5c8b8 Improve: Reuse the instance of StringBui

[tomcat] branch 10.1.x updated: Improve: Reuse the instance of StringBuilder to avoid duplicate object creation (#588)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new cd06594f7f Improve: Reuse the instance of StringB

[tomcat] branch main updated: Improve: Reuse the instance of StringBuilder to avoid duplicate object creation (#588)

2023-02-10 Thread lihan
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 87e1cbf767 Improve: Reuse the instance of StringBuild

[GitHub] [tomcat] aooohan merged pull request #588: Removed object creation

2023-02-10 Thread via GitHub
aooohan merged PR #588: URL: https://github.com/apache/tomcat/pull/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] [tomcat] aooohan closed pull request #587: Removed unused assignments

2023-02-10 Thread via GitHub
aooohan closed pull request #587: Removed unused assignments URL: https://github.com/apache/tomcat/pull/587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [tomcat] aooohan commented on pull request #587: Removed unused assignments

2023-02-10 Thread via GitHub
aooohan commented on PR #587: URL: https://github.com/apache/tomcat/pull/587#issuecomment-1425410871 -1 I don't think this change makes sense to do that, the current code is a bit more intuitive. As a reminder, when you propose a PR, we hope you will add some description to avoid wast