[tomcat-jakartaee-migration] branch main updated: Migrate SPI files in directories by renaming them to the jakartaee prefix (#45)

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/main by this push: new 040b951 Migrate SPI files in di

[GitHub] [tomcat-jakartaee-migration] ebourg merged pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

ebourg merged PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[Bug 66543] Misleading error log in fireRequestDestroyEvent

https://bz.apache.org/bugzilla/show_bug.cgi?id=66543 --- Comment #1 from Felix Schumacher --- I have created a PR (https://github.com/apache/tomcat/pull/604) and will merge it, if no comments on the PR suggest otherwise. -- You are receiving this mail because: You are the assignee for the bug.

[GitHub] [tomcat-jakartaee-migration] FSchumacher commented on a diff in pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

FSchumacher commented on code in PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148360532 ## src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java: ## @@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception {

[GitHub] [tomcat] FSchumacher opened a new pull request, #604: Fix Bug 66543 - Wrong log message used in StandardContext#fireRequestDestroyEvent

FSchumacher opened a new pull request, #604: URL: https://github.com/apache/tomcat/pull/604 Give it its own log message instead of re-using the one from fireRequestInitEvent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [tomcat-jakartaee-migration] ebourg commented on a diff in pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

ebourg commented on code in PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148359876 ## src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java: ## @@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception { S

[GitHub] [tomcat-jakartaee-migration] ebourg commented on a diff in pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

ebourg commented on code in PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148359861 ## src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java: ## @@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception { S

[Bug 66544] java.lang.ArrayIndexOutOfBoundsException @ rg.apache.coyote.http11.Http11Processor.service Error processing request

https://bz.apache.org/bugzilla/show_bug.cgi?id=66544 Felix Schumacher changed: What|Removed |Added OS||All Status|NEW

[GitHub] [tomcat-jakartaee-migration] codecov-commenter commented on pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

codecov-commenter commented on PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#issuecomment-1483795564 ## [Codecov](https://codecov.io/gh/apache/tomcat-jakartaee-migration/pull/45?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [tomcat-jakartaee-migration] FSchumacher opened a new pull request, #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

FSchumacher opened a new pull request, #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45 …efix We already rename files in JAR files, so directory handling should follow here. A more correct way to handle this, would probably be to restrict the renaming to files,