[GitHub] [tomcat] VirtualTim opened a new pull request, #609: Unify Windows/Linux package filesets

VirtualTim opened a new pull request, #609: URL: https://github.com/apache/tomcat/pull/609 This looks like a bigger change than it is, simply because I sorted the list. **Changes**: * Sorted the Windows/Linux include/exclude lists, to make it easy to compare the two *

[GitHub] [tomcat] VirtualTim commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.

VirtualTim commented on PR #600: URL: https://github.com/apache/tomcat/pull/600#issuecomment-1504514693 Oh cool. I was planning on getting around to it, but didn't get time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: BZ 66508 and tagging progress update

On 11/04/2023 18:14, Christopher Schultz wrote: Mark, On 4/11/23 11:49, Mark Thomas wrote: On 06/04/2023 09:18, Mark Thomas wrote: OK, that isn't going to work. It is going to have to be the back-port of the switch to ReentrantLock. Those back-ports have been completed along with the final

Re: [tomcat] branch main updated: Improve messages if JAVA_HOME / JRE_HOME not set correctly

Mark, On 4/11/23 13:18, Mark Thomas wrote: On 11/04/2023 18:12, Christopher Schultz wrote: Mark, On 4/11/23 06:42, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository

[tomcat] branch main updated: Make test more robust

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 28493058c3 Make test more robust 28493058c3 is

Buildbot success in on tomcat-11.0.x

Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/303 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] c3511b1baf7defc57923fce7e12b5e6b392c68c5 Steps:

Re: [tomcat] branch main updated: Improve messages if JAVA_HOME / JRE_HOME not set correctly

On 11/04/2023 18:12, Christopher Schultz wrote: Mark, On 4/11/23 06:42, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were

Re: BZ 66508 and tagging progress update

Mark, On 4/11/23 11:49, Mark Thomas wrote: On 06/04/2023 09:18, Mark Thomas wrote: OK, that isn't going to work. It is going to have to be the back-port of the switch to ReentrantLock. Those back-ports have been completed along with the final bits and pieces I had on my TODO list. I need

Re: [tomcat] branch main updated: Improve messages if JAVA_HOME / JRE_HOME not set correctly

Mark, On 4/11/23 06:42, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

[tomcat] branch 8.5.x updated: Intermittent failure locally. Increase wait time.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new df61a5ccd4 Intermittent failure locally. Increase

[tomcat] branch 9.0.x updated: Intermittent failure locally. Increase wait time.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 79e654a869 Intermittent failure locally. Increase

[tomcat] branch 10.1.x updated: Intermittent failure locally. Increase wait time.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5336f33466 Intermittent failure locally.

[tomcat] branch main updated: Intermittent failure locally. Increase wait time.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c3511b1baf Intermittent failure locally. Increase

Buildbot failure in on tomcat-11.0.x

Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/302 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main]

Re: BZ 66508 and tagging progress update

On 06/04/2023 09:18, Mark Thomas wrote: OK, that isn't going to work. It is going to have to be the back-port of the switch to ReentrantLock. Those back-ports have been completed along with the final bits and pieces I had on my TODO list. I need to run the tests ob various platforms but

[tomcat] 02/03: Code clean-up. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f00b3b95a0fbb343a3dce17986f4866c6b485570 Author: Mark Thomas AuthorDate: Tue Apr 11 16:47:10 2023 +0100 Code

[tomcat] 03/03: Fix parameter counting logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 5badf94e79e5de206fc0ef3054fd536b1bb787cd Author: Mark Thomas AuthorDate: Tue Apr 11 16:41:44 2023 +0100 Fix

[tomcat] 01/03: Prep for clean-up

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3e7a97bb60f6a10a1df79588dd05e525591b6247 Author: Mark Thomas AuthorDate: Tue Apr 11 16:31:18 2023 +0100 Prep for

[tomcat] branch 8.5.x updated (a92db2f0b4 -> 5badf94e79)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from a92db2f0b4 Improve messages for invalid JRE_HOME/JAVA_HOME new 3e7a97bb60 Prep for clean-up new f00b3b95a0

[tomcat] 02/03: Code clean-up. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 98016a0e5f46e582b3ffce78914ae7928cc12832 Author: Mark Thomas AuthorDate: Tue Apr 11 16:46:11 2023 +0100 Code

[tomcat] 03/03: Fix parameter counting logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fbd81421629afe8b8a3922d59020cde81caea861 Author: Mark Thomas AuthorDate: Tue Apr 11 16:41:44 2023 +0100 Fix

[tomcat] 01/03: Prep for clean-up

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fa18633dec56053aff7deb82624fc9801842888a Author: Mark Thomas AuthorDate: Tue Apr 11 16:31:18 2023 +0100 Prep for

[tomcat] branch 9.0.x updated (f3698ed9e6 -> fbd8142162)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from f3698ed9e6 Improve messages for invalid JRE_HOME/JAVA_HOME new fa18633dec Prep for clean-up new 98016a0e5f

[tomcat] 03/03: Fix parameter counting logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ba848da71c523d94950d3c53c19ea155189df9dc Author: Mark Thomas AuthorDate: Tue Apr 11 16:41:44 2023 +0100 Fix

[tomcat] 01/03: Prep for clean-up

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d39db0c10b78878617e3dd3f502eedbe10388c40 Author: Mark Thomas AuthorDate: Tue Apr 11 16:31:18 2023 +0100 Prep for

[tomcat] 02/03: Code clean-up. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 969c239e093dea6ce89d86d033704c9726eb00f7 Author: Mark Thomas AuthorDate: Tue Apr 11 16:43:20 2023 +0100 Code

[tomcat] branch 10.1.x updated (b1709064e3 -> ba848da71c)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from b1709064e3 Improve messages for invalid JRE_HOME/JAVA_HOME new d39db0c10b Prep for clean-up new 969c239e09

[tomcat] 02/03: Clean-up. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4a5766fc05960dfd1edbb4855eb6e92c0fd67cf0 Author: Mark Thomas AuthorDate: Tue Apr 11 16:36:27 2023 +0100 Clean-up. No

[tomcat] 03/03: Fix parameter counting logic

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d53d8e7f77042cc32a3b98f589496a1ef5088e38 Author: Mark Thomas AuthorDate: Tue Apr 11 16:41:44 2023 +0100 Fix parameter

[tomcat] branch main updated (85287b7648 -> d53d8e7f77)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 85287b7648 Add change log entry new 554cea6b6c Prep for clean-up new 4a5766fc05 Clean-up. No functional

[tomcat] 01/03: Prep for clean-up

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 554cea6b6c05d548b10ffe9d14494839c9cb38c0 Author: Mark Thomas AuthorDate: Tue Apr 11 16:31:18 2023 +0100 Prep for

[tomcat] branch main updated: Add change log entry

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 85287b7648 Add change log entry 85287b7648 is

[tomcat] branch main updated: Remove usages of classes in the deprecated-for-removal package javax.security.cert.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 58c3b5da1d Remove usages of classes in the

[GitHub] [tomcat] markt-asf merged pull request #608: Remove uses of deprecated classes in javax.security.cert

markt-asf merged PR #608: URL: https://github.com/apache/tomcat/pull/608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf commented on pull request #608: Remove uses of deprecated classes in javax.security.cert

markt-asf commented on PR #608: URL: https://github.com/apache/tomcat/pull/608#issuecomment-1503257308 Thanks for the PR. Note for reviewers: There is a default method in Java 17 (but not Java 11) so this change is safe in Tomcat 11 but can't be back-ported to earlier versions. --

[tomcat] branch 8.5.x updated: Improve messages for invalid JRE_HOME/JAVA_HOME

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a92db2f0b4 Improve messages for invalid

[tomcat] branch 9.0.x updated: Improve messages for invalid JRE_HOME/JAVA_HOME

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f3698ed9e6 Improve messages for invalid

[GitHub] [tomcat] eirbjo opened a new pull request, #608: Remove uses of classes in deprecated package javax.security.cert

eirbjo opened a new pull request, #608: URL: https://github.com/apache/tomcat/pull/608 Efforts are underway in the OpenJDK project to remove the long deprecated-for-removal classes in the package `javax.security.cert`. These classes were introduced for backwards compatibility concerns with

[tomcat] branch 10.1.x updated: Improve messages for invalid JRE_HOME/JAVA_HOME

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new b1709064e3 Improve messages for invalid

[tomcat] branch main updated: Improve messages if JAVA_HOME / JRE_HOME not set correctly

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a788852f6b Improve messages if JAVA_HOME / JRE_HOME

[GitHub] [tomcat] markt-asf closed pull request #600: echo the value of %JAVA_HOME% when it is invalid.

markt-asf closed pull request #600: echo the value of %JAVA_HOME% when it is invalid. URL: https://github.com/apache/tomcat/pull/600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.

markt-asf commented on PR #600: URL: https://github.com/apache/tomcat/pull/600#issuecomment-1503021102 If neither `JRE_HOME` nor `JAVA_HOME` is defined, a message is already shown. I have undertaken a wider review of setclasspath.bat and service.bat and added additional messages when

[tomcat] 02/02: Align JRE_HOME/JAVA_HOME handling with setclasspath.bat

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0ccae46c22013e7b5ba7377334ac2315f88b12b7 Author: Mark Thomas AuthorDate: Tue Apr 11 10:51:48 2023 +0100 Align

[tomcat] branch main updated (4de1e9e216 -> 0ccae46c22)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 4de1e9e216 Expose utility executor to webapps new eb981f73ee Improve messages for invalid JRE_HOME/JAVA_HOME

[tomcat] 01/02: Improve messages for invalid JRE_HOME/JAVA_HOME

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit eb981f73ee70b799dcd9dcd6694c9084d36169c7 Author: Mark Thomas AuthorDate: Tue Apr 11 10:50:04 2023 +0100 Improve

[tomcat] branch 9.0.x updated: Expose utility executor to webapps

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4e3972d33d Expose utility executor to webapps

[tomcat] branch 10.1.x updated: Expose utility executor to webapps

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new fe797d1417 Expose utility executor to webapps

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1162439073 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1162435391 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[tomcat] branch main updated (57ca5301a9 -> 4de1e9e216)

This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 57ca5301a9 Fix BZ 66548 - Add validation of Sec-Websocket-Key header add 4de1e9e216 Expose utility executor to

[Bug 66548] Tomcat does not validate value of Sec-Websocket-Key header

https://bz.apache.org/bugzilla/show_bug.cgi?id=66548 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Mark

[tomcat] branch 10.1.x updated: Fix BZ 66548 - Add validation of Sec-Websocket-Key header

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 791295e74f Fix BZ 66548 - Add validation of

[Bug 66548] Tomcat does not validate value of Sec-Websocket-Key header

https://bz.apache.org/bugzilla/show_bug.cgi?id=66548 --- Comment #7 from Mark Thomas --- Fixed in: - 11.0.x for 11.0.0-M5 onwards - 10.1.x for 10.1.8 onwards As per schultz's suggestion, I am going to wait at least one release cycle before back-porting this to 9.0.x and 8.5.x in case there are

[tomcat] branch main updated: Fix BZ 66548 - Add validation of Sec-Websocket-Key header

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 57ca5301a9 Fix BZ 66548 - Add validation of