Buildbot success in on tomcat-9.0.x

2023-07-12 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/622 Blamelist: Christopher Schultz , perceptron8 , remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x]

[GitHub] [tomcat] rmannibucau commented on pull request #576: Enable to disable request/error counters and cache stats

2023-07-12 Thread via GitHub
rmannibucau commented on PR #576: URL: https://github.com/apache/tomcat/pull/576#issuecomment-1633222963 @ChristopherSchultz mainly reduce the associated overhead (cpu - cas - and mem - in no luck case multiple cells are allocated per context) since most of the time these counters are

[GitHub] [tomcat] ChristopherSchultz commented on pull request #576: Enable to disable request/error counters and cache stats

2023-07-12 Thread via GitHub
ChristopherSchultz commented on PR #576: URL: https://github.com/apache/tomcat/pull/576#issuecomment-1633181300 This seems like a lot of code to avoid two addition operations. What's the use-case, here? -- This is an automated message from the Apache Git Service. To respond to the

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 --- Comment #10 from Christopher Schultz --- Apologies for not including this in my last comment: Will be in: Tomcat 10.1.12 Tomcat 9.0.79 Tomcat 8.5.92 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 Christopher Schultz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 --- Comment #8 from msobkiewicz --- Then you would have to check by yourself, which branches need to be fixed (which was most time consuming). As you can see, between 9.0.x and 10.1.x there is 10.0.x, which is unaffected, so it's not simply a

[tomcat] branch 8.5.x updated: Sync Configuration Reference with Connector's source code (8.5.x) (#635)

2023-07-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d7abf9f748 Sync Configuration Reference with

[GitHub] [tomcat] ChristopherSchultz merged pull request #635: Sync Configuration Reference with Connector's source code (8.5.x)

2023-07-12 Thread via GitHub
ChristopherSchultz merged PR #635: URL: https://github.com/apache/tomcat/pull/635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat] branch 8.5.x updated: Increment version number in changelog for next release.

2023-07-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 16bf1cd675 Increment version number in changelog

[tomcat] branch 9.0.x updated (1086dc53f2 -> b723f92002)

2023-07-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 1086dc53f2 Fix failure trying to persist configuration new c79bf2dfe5 Sync Configuration Reference with

[GitHub] [tomcat] ChristopherSchultz merged pull request #636: Sync Configuration Reference with Connector's source code (9.0.x)

2023-07-12 Thread via GitHub
ChristopherSchultz merged PR #636: URL: https://github.com/apache/tomcat/pull/636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat] branch 10.1.x updated: Sync Configuration Reference with Connector's source code (10.1.x) (#637)

2023-07-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new c647e9bc81 Sync Configuration Reference with

[GitHub] [tomcat] ChristopherSchultz merged pull request #637: Sync Configuration Reference with Connector's source code (10.1.x)

2023-07-12 Thread via GitHub
ChristopherSchultz merged PR #637: URL: https://github.com/apache/tomcat/pull/637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat] branch 10.1.x updated: Prepare changelog for next release cycle.

2023-07-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new cd318f2fa6 Prepare changelog for next release

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 --- Comment #7 from Christopher Schultz --- Thanks for all the PRs, but I would normally have just accepted one for main (or the highest-version branch where the problem exists) and done the back-porting myself. -- You are receiving this

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 --- Comment #6 from msobkiewicz --- It's 3 instead of 2, but here they are: - https://github.com/apache/tomcat/pull/635 (8.5.x) - https://github.com/apache/tomcat/pull/636 (9.0.x) - https://github.com/apache/tomcat/pull/637 (10.1.x) "10.0.x"

[GitHub] [tomcat] perceptron8 opened a new pull request, #637: Sync Configuration Reference with Connector's source code

2023-07-12 Thread via GitHub
perceptron8 opened a new pull request, #637: URL: https://github.com/apache/tomcat/pull/637 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] perceptron8 opened a new pull request, #636: Sync Configuration Reference with Connector's source code

2023-07-12 Thread via GitHub
perceptron8 opened a new pull request, #636: URL: https://github.com/apache/tomcat/pull/636 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] perceptron8 opened a new pull request, #635: Sync Configuration Reference with Connector's source code

2023-07-12 Thread via GitHub
perceptron8 opened a new pull request, #635: URL: https://github.com/apache/tomcat/pull/635 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[Bug 66681] .getBasicRemote().flushBatch() causes NPE with PerMessageDeflate

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66681 Alex Panchenko changed: What|Removed |Added Hardware|PC |All OS|Mac OS X 10.1

Re: multipart streaming as fileupload native usage?

2023-07-12 Thread Romain Manni-Bucau
Le mer. 12 juil. 2023 à 17:53, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 7/11/23 08:57, Romain Manni-Bucau wrote: > > on commons fileupload list there was the need to have streaming for > Parts. > > > > As of today Servlet API enables to only get a list and

Buildbot failure in on tomcat-9.0.x

2023-07-12 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/621 Blamelist: remm Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 1086dc53f2994637fd6a441f0c554a7e419c5f27

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 --- Comment #5 from msobkiewicz --- Sure! I guess I'll have to create 2 PRs (one for 8.5.x, one for 9.x). Give me some time, please. -- You are receiving this mail because: You are the assignee for the bug.

Re: multipart streaming as fileupload native usage?

2023-07-12 Thread Christopher Schultz
Romain, On 7/11/23 08:57, Romain Manni-Bucau wrote: on commons fileupload list there was the need to have streaming for Parts. As of today Servlet API enables to only get a list and not an iterator - even if it uses it under the hood. :/ It's a Collection, though, and not a List, so there

[Bug 66686] Default value of maxParameterCount

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 --- Comment #4 from Christopher Schultz --- Would you care to prepare a documentation patch/PR? -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 66684] SSL HandShake failed when crlFile linked to an empty file

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66684 --- Comment #6 from Christopher Schultz --- Hmm. Is an empty (zero-byte) CRL file even valid? I forgot that the whole file is the CRL; it's not just a list of PEM-formatted certs that you no longer trust. Even an "empty" CRL should not be

[Bug 66684] SSL HandShake failed when crlFile linked to an empty file

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66684 --- Comment #5 from Christopher Schultz --- Blank-file with enforce-revocation=true should be considered a case of "I do want to enforce revocation but I don't (yet?) have any revoked certificates", and therefore all connections should be

Buildbot success in on tomcat-11.0.x

2023-07-12 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/480 Blamelist: Mark Thomas , remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 7e76d04f7d1dc7574a8dd7d79d297a1aeca62c24 Steps:

[tomcat] branch 8.5.x updated: Fix failure trying to persist configuration

2023-07-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 5c0b36964b Fix failure trying to persist

[tomcat] branch 9.0.x updated: Fix failure trying to persist configuration

2023-07-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1086dc53f2 Fix failure trying to persist

[tomcat] branch 10.1.x updated: Fix failure trying to persist configuration

2023-07-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 739c47ba6b Fix failure trying to persist

[tomcat] branch main updated (52ed442408 -> 7e76d04f7d)

2023-07-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 52ed442408 Add release date for 11.0.0-M9 add 7e76d04f7d Fix failure trying to persist configuration No new

[Bug 66685] Tomcat URL not picking correct certificate

2023-07-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66685 Michael Osipov changed: What|Removed |Added OS||All Status|NEW

Re: Hide jakarta.annotations from tomcat-catalina?

2023-07-12 Thread Romain Manni-Bucau
Le mer. 12 juil. 2023 à 10:47, Mark Thomas a écrit : > On 07/07/2023 09:33, Romain Manni-Bucau wrote: > > Hi, > > > > Do you think we can make jakarta.annotations optional from > tomcat-catalina? > > Would ease IDE completion when this is not supported and tomcat is > wrapped > > in another web

Re: Hide jakarta.annotations from tomcat-catalina?

2023-07-12 Thread Mark Thomas
On 07/07/2023 09:33, Romain Manni-Bucau wrote: Hi, Do you think we can make jakarta.annotations optional from tomcat-catalina? Would ease IDE completion when this is not supported and tomcat is wrapped in another web api. I don't think so. @PostConstruct and @PreDestory support is a mandatory