[GitHub] [tomcat] markt-asf closed pull request #647: Replaced synchronized with StampedLock

2023-08-22 Thread via GitHub
markt-asf closed pull request #647: Replaced synchronized with StampedLock URL: https://github.com/apache/tomcat/pull/647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf commented on pull request #647: Replaced synchronized with StampedLock

2023-08-22 Thread via GitHub
markt-asf commented on PR #647: URL: https://github.com/apache/tomcat/pull/647#issuecomment-1689066140 Synchronized blocks only need to be replaced if they contain blocking operations. This one clearly doesn't. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tomcat] sergmain commented on pull request #647: Replaced synchronized with StampedLock

2023-08-22 Thread via GitHub
sergmain commented on PR #647: URL: https://github.com/apache/tomcat/pull/647#issuecomment-1689065406 From my point of view there are 2 approaches - analyze every synchronized or remove every synchronized without analyzing. My pull-request is with second approach. -- This is an

Buildbot success in on tomcat-11.0.x

2023-08-22 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/546 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 93e59bda914e03ddf3ccaf1f57dab47dbda650b9 Steps:

[tomcat] branch 8.5.x updated: Avoid protocol relative redirects

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4998ad745b Avoid protocol relative redirects

[tomcat] branch 9.0.x updated: Avoid protocol relative redirects

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 77c0ce2d16 Avoid protocol relative redirects

[tomcat] branch 10.1.x updated: Avoid protocol relative redirects

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new bb4624a9f3 Avoid protocol relative redirects

[tomcat] branch cve-2023-41080 deleted (was 93e59bda91)

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch cve-2023-41080 in repository https://gitbox.apache.org/repos/asf/tomcat.git was 93e59bda91 Additional classes for rename The revisions that were on this branch are still contained in other

[tomcat] branch main updated (32b48cadc3 -> 93e59bda91)

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 32b48cadc3 Review getParameterXXX() - invalid parameters + debug should not fail add e3703c9abb Avoid protocol

[tomcat] branch cve-2023-41080 updated: Additional classes for rename

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch cve-2023-41080 in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/cve-2023-41080 by this push: new 93e59bda91 Additional classes

[tomcat] branch cve-2023-41080 created (now d8ebecffb5)

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch cve-2023-41080 in repository https://gitbox.apache.org/repos/asf/tomcat.git at d8ebecffb5 Rename base test so it is not treated as a class with actual tests This branch includes the

[tomcat] 02/02: Rename base test so it is not treated as a class with actual tests

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch cve-2023-41080 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d8ebecffb5c0a39977a7c47d1a4b8a8bee84476e Author: Mark Thomas AuthorDate: Tue Aug 22 12:21:59 2023 -0700

[tomcat] 01/02: Avoid protocol relative redirects

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch cve-2023-41080 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e3703c9abb8fe0d5602f6ba8a8f11d4b6940815a Author: Mark Thomas AuthorDate: Tue Aug 22 11:31:23 2023 -0700

Buildbot failure in on tomcat-11.0.x

2023-08-22 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/545 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main]

[tomcat] 07/08: Handle exception triggered by invalid parameters during access logging

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d6f56761693b06632f4bdd27d7c3010e3665bfbc Author: Mark Thomas AuthorDate: Sun Aug 20 13:05:07 2023 +0100 Handle

[tomcat] 04/08: Remove Parameters.FailReason and associated plumbing

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d701009958e1c2f16f10226f15a13268ae314a32 Author: Mark Thomas AuthorDate: Wed Aug 16 08:50:56 2023 +0100 Remove

[tomcat] 05/08: Add a changelog entry

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0befa0eb1b7feb9752d344902fe787489ef369c1 Author: Mark Thomas AuthorDate: Fri Aug 18 14:32:55 2023 +0100 Add a

[tomcat] 01/08: With the changes to parameter error handling all parsing is explicit

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3f8a229be8cbdd99e718b1b72b5f9c0ea1421c23 Author: Mark Thomas AuthorDate: Tue Aug 15 19:54:02 2023 +0100 With the

[tomcat] 03/08: Remove unused strings

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7c4e89fc00cd4d377133430f68c16bea11bc16bd Author: Mark Thomas AuthorDate: Wed Aug 16 08:42:36 2023 +0100 Remove unused

[tomcat] 06/08: Add tests for changes in parameter handling

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b19862c87b3a3c163cda60ff839f59297d438983 Author: Mark Thomas AuthorDate: Fri Aug 18 15:58:44 2023 +0100 Add tests for

[tomcat] 08/08: Review getParameterXXX() - invalid parameters + debug should not fail

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 32b48cadc3a51b1770d76902901b3541a987ae41 Author: Mark Thomas AuthorDate: Sun Aug 20 16:37:20 2023 -0700 Review

[tomcat] 02/08: Implement parameter error handling changes

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6f181e1062a472bc5f0234980f66cbde42c1041b Author: Mark Thomas AuthorDate: Tue Aug 15 20:32:15 2023 +0100 Implement

[tomcat] branch main updated (b55774b615 -> 32b48cadc3)

2023-08-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from b55774b615 Fix formatting. There should be a space between number and unit. new 3f8a229be8 With the changes to

[GitHub] [tomcat] markt-asf merged pull request #646: Parameter error handling

2023-08-22 Thread via GitHub
markt-asf merged PR #646: URL: https://github.com/apache/tomcat/pull/646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf commented on pull request #647: Replaced synchronized with StampedLock

2023-08-22 Thread via GitHub
markt-asf commented on PR #647: URL: https://github.com/apache/tomcat/pull/647#issuecomment-1688571304 What is the justification for this change? Synchronization is not automatically an issue for virtual threads. I'm not seeing anything in this code that would be unfriendly to virtual

JDK 21 Release Candidates & JVM Language Summit

2023-08-22 Thread David Delabassee
Greetings! JDK 21 is now in the Release Candidate Phase so everything is on track for the Java 21 GA release on September 19th! If you haven't done so, please start testing your project(s) using JDK 22 Early-Access builds and let us know the results. In other news, the JVM Language Summit

[GitHub] [tomcat] michael-o commented on a diff in pull request #646: Parameter error handling

2023-08-22 Thread via GitHub
michael-o commented on code in PR #646: URL: https://github.com/apache/tomcat/pull/646#discussion_r1301062237 ## java/org/apache/tomcat/util/http/InvalidParameterException.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *