[GitHub] [tomcat] xxeol2 opened a new pull request, #649: Eliminating duplicate execution of checkFacade logic

2023-09-04 Thread via GitHub
xxeol2 opened a new pull request, #649: URL: https://github.com/apache/tomcat/pull/649 In the current implementation of the getSession method in the RequestFacade class, the checkFacade logic was redundantly executed twice. I improved this by eliminating the redundancy. -- This is an

[GitHub] [tomcat] xxeol2 commented on a diff in pull request #648: Refactor 'getSession' Method in 'Request' Class to Eliminate Code Redundancy

2023-09-04 Thread via GitHub
xxeol2 commented on code in PR #648: URL: https://github.com/apache/tomcat/pull/648#discussion_r1315352368 ## java/org/apache/catalina/connector/Request.java: ## @@ -2288,12 +2288,7 @@ public String getServletPath() { */ @Override public HttpSession getSession()

[GitHub] [tomcat] aooohan commented on a diff in pull request #648: Refactor 'getSession' Method in 'Request' Class to Eliminate Code Redundancy

2023-09-04 Thread via GitHub
aooohan commented on code in PR #648: URL: https://github.com/apache/tomcat/pull/648#discussion_r1315332131 ## java/org/apache/catalina/connector/Request.java: ## @@ -2288,12 +2288,7 @@ public String getServletPath() { */ @Override public HttpSession

[GitHub] [tomcat] xxeol2 opened a new pull request, #648: Refactor 'getSession' Method in 'Request' Class to Eliminate Code Redundancy

2023-09-04 Thread via GitHub
xxeol2 opened a new pull request, #648: URL: https://github.com/apache/tomcat/pull/648 This Pull Request aims to reduce code duplication in the `getSession` method of the `Request` class. The refactoring has been inspired by the format used in the `reset` method of

[Bug 66005] Apache crashes, if there is a tomcat server, which can not be resolved

2023-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005 --- Comment #28 from Mark Thomas --- Rainer, do you have a timescale in mind for applying the proposed patch or a variation? I'm planning on a mod_jk tag and release soon - hopefully this week. -- You are receiving this mail because: You are

[Bug 66005] Apache crashes, if there is a tomcat server, which can not be resolved

2023-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005 Mark Thomas changed: What|Removed |Added Attachment #38503|0 |1 is obsolete|

[Bug 65901] HTTP 401 response for a HEAD request violates HTTP spec by including a body

2023-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65901 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat-connectors] branch main updated (21f5a92e5 -> f96af6255)

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git from 21f5a92e5 Merge pull request #6 from thesamesam/clang-16-implicit-int new 2bc02d3c7 Align with Tomcat 11

[tomcat-connectors] 03/03: Fix BZ 65901 - don't generate response bodies for HEAD requests

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit f96af6255aa1d2c861796d01268a182a7b8f79d3 Author: Mark Thomas AuthorDate: Mon Sep 4 23:02:47 2023 +0100 Fix

[tomcat-connectors] 02/03: Add change log entry.

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit 19cbc37a6a2816ea029fd36247177ded725a0ca1 Author: Mark Thomas AuthorDate: Mon Sep 4 22:59:21 2023 +0100 Add

[tomcat-connectors] 01/03: Align with Tomcat 11 stylesheet

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit 2bc02d3c72775a26d780fcde4fae49fbbfd92a9a Author: Mark Thomas AuthorDate: Mon Sep 4 22:57:50 2023 +0100

[GitHub] [tomcat-connectors] markt-asf closed pull request #5: Fix bug #65901 to correct HTTP 401 response for HEAD request

2023-09-04 Thread via GitHub
markt-asf closed pull request #5: Fix bug #65901 to correct HTTP 401 response for HEAD request URL: https://github.com/apache/tomcat-connectors/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomcat-connectors] markt-asf commented on pull request #5: Fix bug #65901 to correct HTTP 401 response for HEAD request

2023-09-04 Thread via GitHub
markt-asf commented on PR #5: URL: https://github.com/apache/tomcat-connectors/pull/5#issuecomment-1705720654 The proposed patch does not address the root cause of the bug which can be found at https://github.com/apache/tomcat-connectors/blob/main/native/apache-2.0/mod_jk.c#L3016 I

Re: [tomcat] branch main updated: Avoid deprecated OpenSSL APIs

2023-09-04 Thread Rémy Maucherat
On Fri, Sep 1, 2023 at 12:46 PM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch main > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/main by this push: >

[Bug 67198] AuthType not set if tomcatAuthentication is set to true or left empty

2023-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67198 --- Comment #1 from Robert Rodewald --- The if condition should probably be: protocol.getTomcatAuthentication() && !protocol.getTomcatAuthorization() -- You are receiving this mail because: You are the assignee for the bug.

[Bug 67198] New: AuthType not set if tomcatAuthentication is set to true or left empty

2023-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67198 Bug ID: 67198 Summary: AuthType not set if tomcatAuthentication is set to true or left empty Product: Tomcat 9 Version: 9.0.79 Hardware: PC OS: Linux

[tomcat-connectors] branch main updated (2030005a6 -> 21f5a92e5)

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git from 2030005a6 Fix typo new 3ac168e0a Fix -Wimplicit-int new a276afb53 Fix

[GitHub] [tomcat-connectors] markt-asf merged pull request #6: Fix Clang 15/16 compatibility

2023-09-04 Thread via GitHub
markt-asf merged PR #6: URL: https://github.com/apache/tomcat-connectors/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tomcat-connectors] branch main updated: Fix typo

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new 2030005a6 Fix typo 2030005a6 is described

[tomcat-connectors] branch main updated: Additional ignore for those working in Eclipse

2023-09-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new 4d1e8c63c Additional ignore for those

[tomcat] branch main updated: Add missing deprecation

2023-09-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6ed0eef542 Add missing deprecation 6ed0eef542 is