wonyongChoi05 commented on code in PR #662:
URL: https://github.com/apache/tomcat/pull/662#discussion_r1317009172
##
java/org/apache/coyote/Request.java:
##
@@ -853,24 +846,22 @@ public boolean isProcessing() {
* @param contentType a content type header
*/
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/36/builds/615
Blamelist: remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 8.5.x] 2940133ff8bc1ba0de82e3b28a571849e1580e24
Steps:
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #17 from Christopher Schultz ---
Fair enough, but if we are going to try to squeeze as much performance out of
this, then the correct process is with delegated dispatch:
enum Scope {
applicationScope(0) {
public Object
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #16 from Anurag Dubey ---
(In reply to Christopher Schultz from comment #14)
> The fromLookupAndSwitch technique seems to be implemented in an awkward way.
> Why bother converting from String -> Enum and then using a switch on the
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #15 from Christopher Schultz ---
... also what about Scope.valueOf(scopeName) and then you don't have to
implement your own map? It's possible that a manually-constructed Map would be
faster than the default mapping provided by
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #14 from Christopher Schultz ---
The fromLookupAndSwitch technique seems to be implemented in an awkward way.
Why bother converting from String -> Enum and then using a switch on the enum,
instead of just (a) implementing a
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #13 from Anurag Dubey ---
(In reply to Mark Thomas from comment #11)
> (In reply to Mark Thomas from comment #8)
> > The alternative approach is not faster. The test that showed it was was not
> > a fair test. I will be applying a
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #12 from Anurag Dubey ---
Created attachment 39051
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39051=edit
Alternative enum lookup approach JMH
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #11 from Mark Thomas ---
(In reply to Mark Thomas from comment #8)
> The alternative approach is not faster. The test that showed it was was not
> a fair test. I will be applying a variation of the original patch.
To be clear the
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 2940133ff8 Throw on bad scope error
2940133ff8 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new f4fb5a923d Throw on bad scope error
f4fb5a923d is
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #10 from Christopher Schultz ---
This test seems to show that there is indeed a speed improvement by using a
switch statement instead of a binary search, somewhere in the 30% range, and it
seems consistent. I didn't get the kind of
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #9 from Christopher Schultz ---
Created attachment 39050
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39050=edit
JMH test to compare binarySearch to switch(scope)
# JMH version: 1.37
# VM version: JDK 21, OpenJDK 64-Bit
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new a3a1acafbc Remove useless override
a3a1acafbc is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 5e4901891f Throw on bad scope error
5e4901891f is
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #8 from Mark Thomas ---
The alternative approach is not faster. The test that showed it was was not a
fair test. I will be applying a variation of the original patch.
--
You are receiving this mail because:
You are the assignee
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 1a7505a2bb Throw on bad scope error
1a7505a2bb is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new ee732b4e45 Fix build
ee732b4e45 is described below
markt-asf commented on PR #666:
URL: https://github.com/apache/tomcat/pull/666#issuecomment-1727979952
The test is not a fair test since the Enum approach doesn't include the cost
of the switch. If that is included, the original optimisation is better. I will
be applying a version of the
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 2236738fb2 Remove useless override
2236738fb2 is
markt-asf closed pull request #666: Performance improvements for
ImplicitObjectELResolver
URL: https://github.com/apache/tomcat/pull/666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 70e302f9c2 Remove useless override
70e302f9c2 is
https://bz.apache.org/bugzilla/show_bug.cgi?id=66841
Mark Thomas changed:
What|Removed |Added
CC||nils.ko...@gmail.com
--- Comment #4
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 4044ac78f9 Remove useless override
4044ac78f9 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new cf5858c819 Fix some error reporting
cf5858c819 is
https://bz.apache.org/bugzilla/show_bug.cgi?id=66875
Mark Thomas changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 426eb12991 Fix some error reporting
426eb12991 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 4f117a021b Avoid unlikely NPE
4f117a021b is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 56ffda277d Avoid unlikely NPE
56ffda277d is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 4650fa0953 Fix unsafe map access
4650fa0953 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 4694c9af41 Fix unsafe map access
4694c9af41 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new ddea3e7d58 Avoid unlikely NPE
ddea3e7d58 is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new d3787ec31c Avoid unlikely NPE
d3787ec31c is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new d4905f9979 Fix some error reporting
d4905f9979 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new c63aa4de09 Fix some error reporting
c63aa4de09 is
https://bz.apache.org/bugzilla/show_bug.cgi?id=67472
Christopher Schultz changed:
What|Removed |Added
OS||All
Status|NEW
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 7d9bd48f75 Fix unsafe map access
7d9bd48f75 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new aed045d5b3 Fix unsafe map access
aed045d5b3 is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 6a70bc98ca Avoid unlikely NPE
6a70bc98ca is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new dff67ffe08 Avoid unlikely NPE
dff67ffe08 is
anuragdy commented on PR #666:
URL: https://github.com/apache/tomcat/pull/666#issuecomment-1727332333
Okk, Thanks for letting me know. I will check with the Bug Reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 3e87f4980c Avoid unlikely NPE
3e87f4980c is
https://bz.apache.org/bugzilla/show_bug.cgi?id=67080
--- Comment #7 from Anurag Dubey ---
Hey Christopher Schultz, can you help out with the Pull Request i raised.
--
You are receiving this mail because:
You are the assignee for the bug.
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new b7283659fa Avoid possible NPE
b7283659fa is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 622a52f388 Avoid possible NPE
622a52f388 is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 75b485c0fa Avoid possible NPE
75b485c0fa is
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 6f3d95418d Avoid unlikely NPE
6f3d95418d is described
Build status: BUILD FAILED: compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/36/builds/614
Blamelist: remm
Build Text: compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 8.5.x] dff67ffe0841196416f9ed20f2232d519cfbaf53
Steps:
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new c6421cd875 Missed two more instances of the same
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 439206dec2 Missed two more instances of the same
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 7f3fdfa6b3 Missed two more instances of the same
51 matches
Mail list logo
