Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437906912 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase { private

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437905241 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437903976 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437901624 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437900565 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437899157 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898144 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898048 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437897171 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437896682 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response,

(tomcat) branch 8.5.x updated: Remove reference to user comments which was removed some time ago

2023-12-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 491654219d Remove reference to user comments which

(tomcat) branch 9.0.x updated: Remove reference to user comments which was removed some time ago

2023-12-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e7318f73f8 Remove reference to user comments which

(tomcat) branch 10.1.x updated: Remove reference to user comments which was removed some time ago

2023-12-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new ef32467aa8 Remove reference to user comments

(tomcat) branch main updated: Remove reference to user comments which was removed some time ago

2023-12-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 62d5547b6d Remove reference to user comments which

svn commit: r1914965 [3/3] - in /tomcat/site/trunk: docs/ xdocs/

2023-12-28 Thread markt
Modified: tomcat/site/trunk/docs/tools.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tools.html?rev=1914965=1914964=1914965=diff == --- tomcat/site/trunk/docs/tools.html (original) +++

svn commit: r1914965 [2/3] - in /tomcat/site/trunk: docs/ xdocs/

2023-12-28 Thread markt
Modified: tomcat/site/trunk/docs/security-4.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-4.html?rev=1914965=1914964=1914965=diff == --- tomcat/site/trunk/docs/security-4.html (original) +++

svn commit: r1914965 [1/3] - in /tomcat/site/trunk: docs/ xdocs/

2023-12-28 Thread markt
Author: markt Date: Thu Dec 28 11:15:41 2023 New Revision: 1914965 URL: http://svn.apache.org/viewvc?rev=1914965=rev Log: Add some more ® symbols to pages that don't have them for the first reference in the text Modified: tomcat/site/trunk/docs/bugreport.html