[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 s/edge/age/ --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 There is also nothing that says not to do it. The question is which behavior is better. IMO returning the actual value that is in use is much better than `null

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 The new question is "Should Tomcat call `#setName("JSESSIONID")` during start of an application (just after creation of `SessionCookieConfig`) ?" With the current behavi

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100054233 --- Diff: java/org/apache/tomcat/websocket/WsFrameBase.java --- @@ -687,6 +691,29 @@ protected Transformation getTransformation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924344 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -150,10 +162,11 @@ public void completed(Integer result, Void attachment

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924840 --- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java --- @@ -56,21 +61,27 @@ public void onDataAvailable() throws IOException

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924904 --- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java --- @@ -124,4 +135,56 @@ protected void sendMessageBinary(ByteBuffer msg, boolean last

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99923774 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -58,31 +59,44 @@ void startInputProcessing() { private void

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99928093 --- Diff: test/org/apache/tomcat/websocket/TestWsSessionSuspendResume.java --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924267 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -116,12 +129,11 @@ protected Log getLog() { return log

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99922783 --- Diff: java/org/apache/tomcat/websocket/SuspendableMessageReceiver.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924137 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -58,31 +59,44 @@ void startInputProcessing() { private void

[GitHub] tomcat pull request: now json is fashion

2015-01-13 Thread martin-g
Github user martin-g commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69742518 I'm pretty sure Jersey does something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] tomcat pull request: now json is fashion

2015-01-12 Thread martin-g
Github user martin-g commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69703890 When you POST JSON data you should use http://docs.oracle.com/javaee/6/api/javax/servlet/ServletRequest.html#getReader() to consume the body and parse it as you find