dsoumis merged PR #887:
URL: https://github.com/apache/tomcat/pull/887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
markt-asf commented on PR #887:
URL: https://github.com/apache/tomcat/pull/887#issuecomment-3244923496
LGTM. One minor nit is that continuation lines should be indented 8 spaces
rather than 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
dsoumis commented on PR #887:
URL: https://github.com/apache/tomcat/pull/887#issuecomment-3242207667
I have split the tests in two, one testing xml validation and the other
STRICT_SERVLET_COMPLIANCE sets all the attributes as expected. Test will be
skipped now, if the constants have already
rmaucher commented on PR #887:
URL: https://github.com/apache/tomcat/pull/887#issuecomment-3241596670
Yes, this kind of use of a system property has been shown to cause testsuite
unreliability issues in the past. This was indeed mostly a "fail if XML
validation is enabled" test.
I th
markt-asf commented on PR #887:
URL: https://github.com/apache/tomcat/pull/887#issuecomment-3241474521
Big +1 to expanding the coverage of the unit tests.
I was concerned about setting the system property impacting other tests but
that is not an issue for tests run via Ant as each test cl
rmaucher commented on PR #887:
URL: https://github.com/apache/tomcat/pull/887#issuecomment-3241281232
Testing the log contents is not as stable as checking some other things, so
it should be avoided if possible. However, sometimes it is useful so adding the
capability to the testsuite seems
dsoumis opened a new pull request, #887:
URL: https://github.com/apache/tomcat/pull/887
1) Adds TomcatBaseTest.WebappLogCapture to capture logs emitted under the
webapp classloader during context start.
2) Add TestStrictComplianceDeployment for STRICT_SERVLET_COMPLIANCE web.xml
parsing.
markt-asf commented on PR #886:
URL: https://github.com/apache/tomcat/pull/886#issuecomment-3227742554
The issue identified is valid but:
- this PR does not implement the proposed solution
- the proposed solution is not the best solution
- this PR introduces a number of unacceptable
markt-asf closed pull request #886: fix(session): Remove unreachable file
existence check in FileStore#load
URL: https://github.com/apache/tomcat/pull/886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
trashz403 opened a new pull request, #886:
URL: https://github.com/apache/tomcat/pull/886
fix(session): Remove unreachable code in FileStore#load
The `if (!file.exists())` check within the try-with-resources block in the
`load()` method is unreachable.
The `new FileInputStream(
markt-asf closed pull request #885: Update logging.properties
URL: https://github.com/apache/tomcat/pull/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
markt-asf commented on PR #885:
URL: https://github.com/apache/tomcat/pull/885#issuecomment-3227586630
The default logging configuration is only ever going to be a starting point.
We can't possibly expect to provide a default logging configuration that is
suitable to the huge range of uses
trashz403 opened a new pull request, #885:
URL: https://github.com/apache/tomcat/pull/885
Log levels set to INFO or WARNING to balance detail and noise in production.
Logs retained for 30 days to balance disk space usage and audit needs.
All logs use UTF-8 encoding, supporting i
markt-asf commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3227498871
Closing this PR as it doesn't fully address the concurrency issues. I have a
fix based on this PR that does address them that I will apply and then
back-port shortly.
--
This is an auto
markt-asf closed pull request #882: BZ 69781 - improve FileStore thread safety
URL: https://github.com/apache/tomcat/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3223479334
The test case has found an issue with this implementation. The issue is that
usage increments/
decrements and the lock/unlock actions are not atomic. I'm going to look at
the solution a
rmaucher merged PR #82:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
rmaucher merged PR #83:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
dependabot[bot] opened a new pull request, #83:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/83
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
Release notes
Sourced from https://github.com/actions/checkout/releases";>actions/checkout's
dependabot[bot] opened a new pull request, #82:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/82
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to
5.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup
aaron-belenky closed pull request #884: Test2
URL: https://github.com/apache/tomcat/pull/884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubsc
aaron-belenky opened a new pull request, #884:
URL: https://github.com/apache/tomcat/pull/884
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
rmaucher commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3216306915
> I took a look at the patch and it looks OK. I think there is some were
similar locking code in web resources but we can look at refactoring once this
patch is committed.
>
> I also
markt-asf commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3214966675
I took a look at the patch and it looks OK. I think there is some were
similar locking code in web resources but we can look at refactoring once this
patch is committed.
I also look
rmaucher commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3214385538
Since there's an issue, the main question is if the extra code belongs to
the store. The main problem is that there are two entry points to the store:
the PersistentManagerBase but also the
markt-asf commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3213433551
I've added a test case for this to main (12.0.x). I haven't looked at the
proposed solution yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
markt-asf commented on PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#issuecomment-3199707123
I'll just note that that patch uses `|` and not `||` so there is no
short-circuiting of the logic if `convertedArchive` is `true`.
I haven't reviewed the rest of the p
marcosemiao commented on PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#issuecomment-3198776133
@ChristopherSchultz I have the feeling you're not convinced by this fix? Do
you want a test ready for you to run?
--
This is an automated message from the Apache Git
ChristopherSchultz commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2283179949
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -217,16 +233,21 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
@
aogburn commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282853608
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -217,16 +233,21 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
@Override
n828cl commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282741701
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -217,16 +233,21 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
@Override
aogburn commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282736787
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -243,9 +264,14 @@ public void save(Session session) throws IOException {
.trace(sm.getString
aogburn commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282695727
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -217,16 +233,21 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
@Override
aogburn commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282714274
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -196,19 +205,26 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
ClassL
aogburn commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282702181
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -217,16 +233,21 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
@Override
aogburn commented on code in PR #882:
URL: https://github.com/apache/tomcat/pull/882#discussion_r2282695727
##
java/org/apache/catalina/session/FileStore.java:
##
@@ -217,16 +233,21 @@ public Session load(String id) throws
ClassNotFoundException, IOException {
@Override
ChristopherSchultz commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3197053936
I'm not sure I see a change. In `remove()`, `File.exists` is still called
before obtaining the lock. I think you should obtain the lock first. If you
disagree, that's fine, but pl
aogburn commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3192741258
Thanks for the feedback @ChristopherSchultz. That primarily happened as I
was trying to ensure that `load` obtained and kept its lock from the time it
confirmed the file exists through to t
isapir commented on PR #883:
URL: https://github.com/apache/tomcat/pull/883#issuecomment-3192561754
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
isapir merged PR #883:
URL: https://github.com/apache/tomcat/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
ljtyson opened a new pull request, #883:
URL: https://github.com/apache/tomcat/pull/883
## Description
Fixed a typo in the Tomcat documentation where `CATALIA_HOME` was missing
the letter 'N' and should be `CATALINA_HOME`.
## Changes Made
- Changed `CATALIA_HOME` to `CATALINA_HO
ChristopherSchultz commented on PR #882:
URL: https://github.com/apache/tomcat/pull/882#issuecomment-3192102092
There is slight disagreement between `load`, `save`, and `remove` as to when
the locks are acquired. In some cases, the lock is acquired first and then file
operations are perform
rmaucher commented on PR #473:
URL: https://github.com/apache/tomcat/pull/473#issuecomment-3190649996
> That would break some stuff. I'd the gain worth the pain?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
michael-o commented on PR #473:
URL: https://github.com/apache/tomcat/pull/473#issuecomment-3189874167
> I kinda think this is out of scope for the container. There are _loads_ of
wonderful things we could add to `GenericPrincipal` and eventually Tomcat
becomes an application framework.
ChristopherSchultz commented on PR #473:
URL: https://github.com/apache/tomcat/pull/473#issuecomment-3189865478
I kinda think this is out of scope for the container. There are *loads* of
wonderful things we could add to `GenericPrincipal` and eventually Tomcat
becomes an application framewo
ChristopherSchultz commented on PR #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-3189827998
I suppose separate filters could be written for "filter/remove" versus
"throw an error". Making this into a Filter will prevent Tomcat from shooting
itself in the foot if it has t
ChristopherSchultz commented on PR #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-3189821921
Could we just do something like this?
```
package com.chadis.web.servlet;
import java.io.IOException;
import java.util.HashSet;
import java.util.stream.Collec
ChristopherSchultz commented on PR #877:
URL: https://github.com/apache/tomcat/pull/877#issuecomment-3189749185
I see no reason to change `RUNNING.txt` at all. Anyone wanting to set
CATALINA_OPTS should know what they are doing and don't need any further
examples. There are dozens of JVM op
ChristopherSchultz closed pull request #877: Update RUNNING.txt
URL: https://github.com/apache/tomcat/pull/877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
isapir commented on PR #877:
URL: https://github.com/apache/tomcat/pull/877#issuecomment-3189130840
Modern JVMs do a pretty good job at setting the memory values in the
examples according to the specific system. I personally find the `-Xms` flag
to not be useful in modern JVMs, and the upp
aogburn opened a new pull request, #882:
URL: https://github.com/apache/tomcat/pull/882
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rmaucher merged PR #81:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
dependabot[bot] opened a new pull request, #81:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/81
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.3 to 4.2.4.
Release notes
Sourced from https://github.com/actions/cache/releases";>actions/cache's
rele
rmaucher commented on PR #881:
URL: https://github.com/apache/tomcat/pull/881#issuecomment-3168308789
I had introduced it for seemingly no reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf merged PR #881:
URL: https://github.com/apache/tomcat/pull/881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #881:
URL: https://github.com/apache/tomcat/pull/881#issuecomment-3168291142
Thanks for spotting and fixing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
asuka1975 opened a new pull request, #881:
URL: https://github.com/apache/tomcat/pull/881
Hello, thanks for this useful software!
## Overview
This is a simple refactoring.
In eaff01e9d14884a520691ee4b1af2fe330cb46a2 's commit, a process that
double-checked the log level
markt-asf commented on PR #880:
URL: https://github.com/apache/tomcat/pull/880#issuecomment-3150012688
Thanks for spotting that. I'll back-port it to the other branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
markt-asf merged PR #880:
URL: https://github.com/apache/tomcat/pull/880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
rmaucher merged PR #80:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
dependabot[bot] opened a new pull request, #80:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/80
Bumps
[org.apache.commons:commons-compress](https://github.com/apache/commons-compress)
from 1.27.1 to 1.28.0.
Changelog
Sourced from https://github.com/apache/commons
Chenjp opened a new pull request, #880:
URL: https://github.com/apache/tomcat/pull/880
consider the possibility of integer overflow before result add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ChristopherSchultz commented on PR #877:
URL: https://github.com/apache/tomcat/pull/877#issuecomment-3140741065
Is there evidence that downstream users don't know how to set their JVM
settings, or that heap settings are particularly worthy of documentation?
--
This is an automated message
markt-asf merged PR #878:
URL: https://github.com/apache/tomcat/pull/878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #878:
URL: https://github.com/apache/tomcat/pull/878#issuecomment-3139377605
Thanks for this PR. I'll merge into 9.0.x, double check a few things and
then forward port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dmap closed pull request #879: Add option to XML encode the results of EL
expressions if outputting
URL: https://github.com/apache/tomcat/pull/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dmap opened a new pull request, #879:
URL: https://github.com/apache/tomcat/pull/879
The behaviour is controlled by a new page/tag directive attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
xsimo opened a new pull request, #878:
URL: https://github.com/apache/tomcat/pull/878
as per Konstantin Kolinko suggestions [1], this pull request aims to correct
and improve the previous #876.
1. Constants is re-used by the Host Manager web application, but the ico
file had not been
Petsku01 opened a new pull request, #877:
URL: https://github.com/apache/tomcat/pull/877
Description:
This PR adds a new subsection (3.5) to `RUNNING.txt` under "(3.4) Using the
setenv script" to provide platform-specific examples for configuring JVM memory
options using `CATALINA_OPTS`.
markt-asf commented on PR #876:
URL: https://github.com/apache/tomcat/pull/876#issuecomment-3126935367
Also forward-ported to 10.1.x, 11.0.x and 12.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
markt-asf merged PR #876:
URL: https://github.com/apache/tomcat/pull/876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
xsimo opened a new pull request, #876:
URL: https://github.com/apache/tomcat/pull/876
1. Tomcat Manager is sometimes run on server on which there is no ROOT
context, therefore no default favicon is not found. This commits adds the
tomcat favicon to the manager webapp directory and reference
rmaucher merged PR #79:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
dependabot[bot] opened a new pull request, #79:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/79
[
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
ChristopherSchultz merged PR #874:
URL: https://github.com/apache/tomcat/pull/874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
dgriffith-lx opened a new pull request, #874:
URL: https://github.com/apache/tomcat/pull/874
Update package for OneLineFormatter to match
[logging.properties](https://github.com/apache/tomcat/blob/9.0.x/conf/logging.properties)
--
This is an automated message from the Apache Git Service.
Chenjp closed pull request #873: Filter to limit target file size of ranged put
request
URL: https://github.com/apache/tomcat/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
skempken closed pull request #16: Fixes MTCOMCAT-294: Add URL decoding to fix
file lookup for paths containing spaces
URL: https://github.com/apache/tomcat-maven-plugin/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
marcosemiao commented on code in PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#discussion_r2184804118
##
src/main/java/org/apache/tomcat/jakartaee/Migration.java:
##
@@ -322,7 +325,7 @@ private void migrateArchiveStreaming(InputStream src,
OutputStr
ChristopherSchultz commented on code in PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#discussion_r2183806056
##
src/main/java/org/apache/tomcat/jakartaee/Migration.java:
##
@@ -322,7 +325,7 @@ private void migrateArchiveStreaming(InputStream src,
Ou
marcosemiao opened a new pull request, #78:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/78
For example use directory with non-writable files, example git repository :
java -jar jakartaee-migration-1.0.8-shaded.jar C:\work\
jakartaee-migration read and write al
Chenjp commented on PR #871:
URL: https://github.com/apache/tomcat/pull/871#issuecomment-3021435704
@markt-asf servlet project contains a testcase (CanonicalUriPathTest.java),
is it a part of servlet TCK?
--
This is an automated message from the Apache Git Service.
To respond to the messa
rmannibucau commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2997222319
@markt-asf hmm, you're right, wonder if it can be a timing issue so it would
be helpful to set the "original status" in notes (or internal attributes) and
check it in access log to not r
markt-asf commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2996647475
The check you've added is a duplicate of the first check that happens when
the method in the `if` block is called.
--
This is an automated message from the Apache Git Service.
To respond
rmannibucau commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2996544211
@markt-asf hmm, can you detail how it is unecessary since it happens in
async exchanges? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the mess
markt-asf commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2996468008
Fixed in 4dc1a0f9 and back-ported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
markt-asf closed pull request #868: recycle RequestInfo when Request is reused
in pool
URL: https://github.com/apache/tomcat/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
markt-asf commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2996428405
This is unnecessary. See
https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/connector/Response.java#L1220
--
This is an automated message from the Apache Git Service.
To
markt-asf closed pull request #870: Avoid to change the status of the response
in StandardHostValve.java …
URL: https://github.com/apache/tomcat/pull/870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ChristopherSchultz closed pull request #869: Discard unsupported part header
field while handling multipart fileupload request
URL: https://github.com/apache/tomcat/pull/869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ChristopherSchultz commented on PR #869:
URL: https://github.com/apache/tomcat/pull/869#issuecomment-2988597530
I've got bad news: this code is a packaged-renamed copy of Apache
commons-fileupload, so this PR actually should be re-worked and filed against
that project instead. We are downst
rmannibucau opened a new pull request, #870:
URL: https://github.com/apache/tomcat/pull/870
…if response is committed
main issue: you get a 500 in the access log whereas it was a 200 (for
example)
--
This is an automated message from the Apache Git Service.
To respond to the messag
Chenjp opened a new pull request, #869:
URL: https://github.com/apache/tomcat/pull/869
comply rfc7578 section
[4.8](https://datatracker.ietf.org/doc/html/rfc7578#section-4.8)
```
4.8. Other "Content-" Header Fields
The multipart/form-data media type does not support any MIME hea
jfclere merged PR #29:
URL: https://github.com/apache/tomcat-native/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apach
qingdaoheze commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2978822957
> HTTP/2 is handled differently because of the multiplexing. We probably do
need a `recycle()` method on `RequestInfo`. It looks like it should be called
around line 440 (current 9.0.x c
jfclere opened a new pull request, #29:
URL: https://github.com/apache/tomcat-native/pull/29
Sorry I forgot to remove it in my previous PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
1 - 100 of 1869 matches
Mail list logo
