tbw777 commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1444501056
https://gist.github.com/tbw777/cd394ec67a01f9e7e8fe4d0c66d74637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ChristopherSchultz commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1443631640
I'm curious about performance data when the `\w` has other things added to
it, which is the case for all examples in Tomcat. This microbenchmark only
compares `[A-Za-z0-9_]` as
markt-asf commented on code in PR #592:
URL: https://github.com/apache/tomcat/pull/592#discussion_r1116803461
##
java/jakarta/servlet/jsp/resources/jspxml.xsd:
##
@@ -25,7 +25,7 @@
-
+
Review Comment:
The Tomcat project is unable to change these schema. We have to use
rmaucher closed pull request #591: Implement more special maps for rewrite valve
URL: https://github.com/apache/tomcat/pull/591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmaucher commented on PR #591:
URL: https://github.com/apache/tomcat/pull/591#issuecomment-1440111376
I merged it with a lot of changes and cleanups. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markt-asf commented on PR #593:
URL: https://github.com/apache/tomcat/pull/593#issuecomment-1437964475
That spelling is correct for US English.
Given the range of contributors to Tomcat, there is a mix of UK and US
English used in the Tomcat docs.
--
This is an automated message from
markt-asf closed pull request #593: Update CONTRIBUTING.md
URL: https://github.com/apache/tomcat/pull/593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
zengwei2000 opened a new pull request, #593:
URL: https://github.com/apache/tomcat/pull/593
fix typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tbw777 opened a new pull request, #592:
URL: https://github.com/apache/tomcat/pull/592
https://gist.github.com/tbw777/8ce56d2cc3a0216012362d18b7262eb2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tbw777 closed pull request #583: Replaced old time API
URL: https://github.com/apache/tomcat/pull/583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsoumis opened a new pull request, #591:
URL: https://github.com/apache/tomcat/pull/591
Implemented more special maps from
https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html as implied by the
FIXME tag.
Added relevant tests and added ServletMapping to test int: MapType.
--
markt-asf closed pull request #582: Enabled headless build configuration
URL: https://github.com/apache/tomcat/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1430228290
I don't see any benefit to adding these extra settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ChristopherSchultz commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1430168053
It does not guarantee that no AWT components are used. It only guarantees
that anything which requires an actual screen will fail (such as trying to open
a Frame, etc.). AWT is
markt-asf closed pull request #578: Remove redundant modifiers for interface
members
URL: https://github.com/apache/tomcat/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf commented on PR #578:
URL: https://github.com/apache/tomcat/pull/578#issuecomment-1430113794
I've applied this change via a combination of IDE tools and manual review as
the CheckStyle test for redundant modifiers covers more than just interface
methods.
I was initially in
tbw777 commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429800793
Also this is guarantee that no awt components used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ChristopherSchultz commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429782733
If no code requests anything AWT-related, then the headless config of the
JVM makes no difference. I see no improvement here at all, just added lines to
an already complex build
tbw777 commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429719724
no problem, just selecting less jvm api to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429706205
What problem is this PR trying to solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf commented on code in PR #583:
URL: https://github.com/apache/tomcat/pull/583#discussion_r110573
##
java/org/apache/catalina/filters/RequestDumperFilter.java:
##
@@ -56,12 +59,13 @@ public class RequestDumperFilter extends GenericFilter {
private static final
markt-asf closed pull request #586: Fixed closing serverSocket in
doCloseServerSocket()
URL: https://github.com/apache/tomcat/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf commented on PR #586:
URL: https://github.com/apache/tomcat/pull/586#issuecomment-1429675397
Thanks for the report. Fixed slightly differently (effectively the same
code) to align with the existing NIO2 code.
--
This is an automated message from the Apache Git Service.
To
tbw777 commented on PR #589:
URL: https://github.com/apache/tomcat/pull/589#issuecomment-1427636757
@aooohan ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan closed pull request #589: XSD patterns normalization
URL: https://github.com/apache/tomcat/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
aooohan commented on PR #589:
URL: https://github.com/apache/tomcat/pull/589#issuecomment-1427559632
We are not able to modify these files, maybe you should report this to
[Jakarta project](https://github.com/jakartaee).
--
This is an automated message from the Apache Git Service.
To
tbw777 commented on PR #590:
URL: https://github.com/apache/tomcat/pull/590#issuecomment-1426250991
@aooohan
```
ExecutorService
...
Since:
19
...
default void close() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message,
markt-asf commented on PR #16:
URL: https://github.com/apache/tomcat-native/pull/16#issuecomment-1425572722
Thanks for spotting this.
Better to automate this as I'll just forget to update it again next year.
I'll copy the config to do this from the Tomcat 11.0.x build.
--
This is an
markt-asf closed pull request #16: Update build.xml with new year
URL: https://github.com/apache/tomcat-native/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dsoumis opened a new pull request, #16:
URL: https://github.com/apache/tomcat-native/pull/16
Update build.xml with new year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
aooohan merged PR #590:
URL: https://github.com/apache/tomcat/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on code in PR #590:
URL: https://github.com/apache/tomcat/pull/590#discussion_r1102455984
##
java/org/apache/tomcat/util/http/fileupload/util/Streams.java:
##
@@ -106,12 +106,12 @@ public static long copy(final InputStream inputStream,
}
aooohan merged PR #588:
URL: https://github.com/apache/tomcat/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan closed pull request #587: Removed unused assignments
URL: https://github.com/apache/tomcat/pull/587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
aooohan commented on PR #587:
URL: https://github.com/apache/tomcat/pull/587#issuecomment-1425410871
-1
I don't think this change makes sense to do that, the current code is a bit
more intuitive.
As a reminder, when you propose a PR, we hope you will add some description
to avoid
aooohan closed pull request #585: Update README.md
URL: https://github.com/apache/tomcat/pull/585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Madfarm opened a new pull request, #585:
URL: https://github.com/apache/tomcat/pull/585
You can deny this; I had to create a pull request for a school project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rmaucher closed pull request #506: Adding Redirect and Proxy Error Reporting
Valves
URL: https://github.com/apache/tomcat/pull/506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rmaucher commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1424311002
I had a look at it and ended up merging the feature as
https://github.com/apache/tomcat/commit/2c2a1bd248b1ee200a0898c30e355802f0a6f7a6
We'll see what the final feedback on it is ...
aooohan commented on PR #584:
URL: https://github.com/apache/tomcat/pull/584#issuecomment-1423869152
Thanks, I've cherry-picked this commit to other branch and make some minor
modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
aooohan merged PR #584:
URL: https://github.com/apache/tomcat/pull/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1420408534
No need for an apology. This has been a useful discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tbw777 opened a new pull request, #583:
URL: https://github.com/apache/tomcat/pull/583
SimpleDateFormatter isnt thread safe and deprecated with new jvm8 time API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gksxodnd007 closed pull request #579: Add activateDropConnection config to
choose drop connection by http status code
URL: https://github.com/apache/tomcat/pull/579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416100562
@markt-asf
I'm sorry, but I'll follow your opinion. and I learn about the request
smuggling risks while communication with you. thank you very much :)
--
This is an automated
markt-asf commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416093124
My suggestion at this point would be to use custom 4xx and 5xx status codes
in the application rather than re-using known codes.
--
This is an automated message from the Apache Git
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416087598
@rmaucher
thank you for your explanation :) I understand. is there any better way that
reuses the connection for utilizing computing resources?
--
This is an automated message
ChristopherSchultz commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416024123
Apologies: my comments are rubbish after Java 9. Please forgive the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ChristopherSchultz commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416017516
I think this "performance improvement" is not an improvement and doesn't
affect performance in any meaningful way.
--
This is an automated message from the Apache Git Service.
ChristopherSchultz commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416015385
There isn't much of a difference between `String.replace` and
`String.replaceAll`. They both use regular expressions under the hood. Java's
`Pattern` class has a special case for
markt-asf merged PR #581:
URL: https://github.com/apache/tomcat/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1095639347
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result =
rmaucher commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1415375850
Of course, some instances of these status codes would be "ok" to recover
from, but Mark is actually right: it is not going to be deterministic.
Also it is not possible to add "defensive"
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1414693058
@markt-asf
I see the reactor netty code to check how they close the connection when the
current request was not fully read.
they also close the connection even though that is
tbw777 commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1414189316
@markt-asf
Branch was updated and
https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b also
Check please.
--
This is an automated message from the Apache Git Service.
To
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094893763
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result =
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094884701
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result =
tbw777 commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094863229
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result =
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094835289
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result =
hojongs commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413855117
@markt-asf
I get what you mean. But some people (including me) usually use the status
codes with additional cases. For example, the status code 400 doesn't occur
only in the badly
markt-asf commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413798605
- 400 Always unsafe to continue since if you have a badly formatted request
you can't tell where that request ends and the next one starts.
- 408 Always unsafe to continue since the
dongseokk commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413769699
> -1. veto. I have security concerns. The connection is dropped in error
conditions to avoid request smuggling risks. Of the status codes lists, the
only one we might be able to handle
tbw777 opened a new pull request, #581:
URL: https://github.com/apache/tomcat/pull/581
replaceAll("ABC", "") is non Pattern method and therefore must be replaced
to simple fast replace()
A proofs of changes:
https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b
--
This is
tbw777 closed pull request #580: Speedup by removing non pattern replaceAll
with constant arg
URL: https://github.com/apache/tomcat/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tbw777 opened a new pull request, #580:
URL: https://github.com/apache/tomcat/pull/580
replaceAll("ABC", "") is non Pattern method and therefore must be replaced
to simple fast replace()
A proofs of changes:
https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b
--
This is
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413675074
@markt-asf
thank you for your good opinion. but I think, it is no need to force drop
connections. also, the default action is not changing by setting false the
value. and some
markt-asf commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413624082
-1. veto.
I have security concerns. The connection is dropped in error conditions to
avoid request smuggling risks. Of the status codes lists, the only one we might
be able to handle
rmaucher commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413524460
Ok why not, but "activateDropConnection" does not sound very good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gksxodnd007 opened a new pull request, #579:
URL: https://github.com/apache/tomcat/pull/579
when response http status code is `400, 408, 411, 413, 414, 500, 501, 503`,
the connecton is closed by tomcat even though that is keep-alive. undertow and
jetty and netty don't close keep-alive
dsoumis opened a new pull request, #578:
URL: https://github.com/apache/tomcat/pull/578
I have parsed the whole project and removed redundant modifiers for
interface members resulting in vanishing of ~2000 warnings.
Although it's a big commit, I strongly believe that it should be
csutherl commented on PR #577:
URL: https://github.com/apache/tomcat/pull/577#issuecomment-1410322341
Thank you for your contribution and congrats on your first commit to the
Apache Tomcat project @TochigiV! :tada:
--
This is an automated message from the Apache Git Service.
To respond
aooohan commented on PR #577:
URL: https://github.com/apache/tomcat/pull/577#issuecomment-1409706494
Thanks ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan merged PR #577:
URL: https://github.com/apache/tomcat/pull/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on code in PR #577:
URL: https://github.com/apache/tomcat/pull/577#discussion_r1091406147
##
res/ide-support/netbeans/project.xml:
##
@@ -189,7 +189,7 @@
test
-
TochigiV opened a new pull request, #577:
URL: https://github.com/apache/tomcat/pull/577
There seems to be a difference in the dependency versions in the
build.properties file and the IDE config files, which I have corrected.
--
This is an automated message from the Apache Git Service.
aooohan closed pull request #575: bug 66419
URL: https://github.com/apache/tomcat/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on PR #575:
URL: https://github.com/apache/tomcat/pull/575#issuecomment-1407541029
8c6f2972beb5f4c7809dddf5633b696e3f069b4a has fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ifurnadjiev opened a new pull request, #42:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/42
If javax.servlet.* packages are imported with version constraints in the
MANIFEST.MF, the conversion should fix this range to the one corresponding to
jakarta.servlet.* spec
markt-asf commented on issue #39:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/39#issuecomment-1403469350
I'm a little uncomfortable with the idea of ignoring an explicit version
range but if the user opts to use the migration tool that is an implicit choice
to ignore
ifurnadjiev commented on issue #39:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/39#issuecomment-1403436225
Any comment on the issue? Do you have plans to address it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1101 - 1180 of 1180 matches
Mail list logo
