[GitHub] [tomcat] jfclere merged pull request #644: Warn when non default ciphers are removed because the engine rejects them.

jfclere merged PR #644: URL: https://github.com/apache/tomcat/pull/644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] babyblue94520 opened a new pull request, #645: feat(Http11Processor): Add max value in keepalive.

babyblue94520 opened a new pull request, #645: URL: https://github.com/apache/tomcat/pull/645 __HttpClient__ judges how many connections are cached by the __keepalive__ header max value, but __Http11Processor__ doesn't provide it, so __HttpClient__ __keepAliveConnections__ is always __5__.

[GitHub] [tomcat] markt-asf commented on pull request #644: Warn when non default ciphers are removed because the engine rejects them.

markt-asf commented on PR #644: URL: https://github.com/apache/tomcat/pull/644#issuecomment-1669965294 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] markt-asf commented on a diff in pull request #644: Warn when non default ciphers are removed because the engine rejects them.

markt-asf commented on code in PR #644: URL: https://github.com/apache/tomcat/pull/644#discussion_r1287317502 ## java/org/apache/tomcat/util/net/SSLUtilBase.java: ## @@ -122,6 +122,10 @@ protected SSLUtilBase(SSLHostConfigCertificate certificate, boolean warnTls13) {

[GitHub] [tomcat] jfclere opened a new pull request, #644: Warn when non default ciphers are removed because the engine rejects them.

jfclere opened a new pull request, #644: URL: https://github.com/apache/tomcat/pull/644 When using nmap --script ssl-enum-ciphers -p port host the ciphers proposed are often a small subset of the expect ones. A warning helps to see what is rejected. -- This is an automated message

[GitHub] [tomcat] michael-o commented on pull request #640: Catch NamingException instead of specialized sub-classes

michael-o commented on PR #640: URL: https://github.com/apache/tomcat/pull/640#issuecomment-1669294674 FTR: This is my workaround approach to this:

[GitHub] [tomcat] markt-asf commented on a diff in pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

markt-asf commented on code in PR #641: URL: https://github.com/apache/tomcat/pull/641#discussion_r1285192745 ## java/org/apache/catalina/startup/HostConfig.java: ## @@ -154,6 +154,16 @@ public class HostConfig implements LifecycleListener { */ protected final Set

[GitHub] [tomcat] aooohan merged pull request #241: Increment ReleaseIdle Counter when testAllIdle releases them

aooohan merged PR #241: URL: https://github.com/apache/tomcat/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] aooohan commented on pull request #241: Increment ReleaseIdle Counter when testAllIdle releases them

aooohan commented on PR #241: URL: https://github.com/apache/tomcat/pull/241#issuecomment-1665089645 Ok, you are right. It does seem to have been overlooked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] rmaucher commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

rmaucher commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1663624324 > Just deleted on the file system or removed via the Manager app? > > It looks like there are sorts of race possibilities between `Host` and `HostConfig`. How far do we want to go to

[GitHub] [tomcat] aooohan commented on a diff in pull request #597: Use a deep copy of query stats whose values won't change during sorting.

aooohan commented on code in PR #597: URL: https://github.com/apache/tomcat/pull/597#discussion_r1282608560 ## modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java: ## @@ -222,19 +222,55 @@ protected QueryStats getQueryStats(String sql) {

[GitHub] [tomcat] aooohan closed pull request #643: Fix ConnectionState when exception

aooohan closed pull request #643: Fix ConnectionState when exception URL: https://github.com/apache/tomcat/pull/643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] aooohan commented on pull request #643: Fix ConnectionState when exception

aooohan commented on PR #643: URL: https://github.com/apache/tomcat/pull/643#issuecomment-1663197316 Thanks for the PR. I have merged manually with adding a unit test and changelog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tomcat] wenjunxiao opened a new pull request, #643: Fix ConnectionState when exception

wenjunxiao opened a new pull request, #643: URL: https://github.com/apache/tomcat/pull/643 When an exception occurs while writing, the ConnectionState state will be inconsistent with the actual state on the connection, therefore, the state needs to be cleaned up on exception. Example code

[GitHub] [tomcat] aooohan closed pull request #642: clean up code - formating

aooohan closed pull request #642: clean up code - formating URL: https://github.com/apache/tomcat/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] aooohan commented on pull request #642: clean up code - formating

aooohan commented on PR #642: URL: https://github.com/apache/tomcat/pull/642#issuecomment-1657826941 Those files were generated by [JavaCC](https://github.com/javacc/javacc), so this change is meaningless. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] jfclere commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1655115303 According to a bunch of test I also have: +++ SEVERE [main] org.apache.catalina.core.ContainerBase.removeChild Error destroying child org.apache.catalina.LifecycleException:

[GitHub] [tomcat] jfclere commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1653258265 OK the lot of times is because of the Thread.sleep(500); in checkResources() in HostConfig. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] FSchumacher merged pull request #640: Catch NamingException instead of specialized sub-classes

FSchumacher merged PR #640: URL: https://github.com/apache/tomcat/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] FSchumacher commented on pull request #640: Catch NamingException instead of specialized sub-classes

FSchumacher commented on PR #640: URL: https://github.com/apache/tomcat/pull/640#issuecomment-1651850085 > @FSchumacher, do you intend to backport it to 8.5 and 9.0? Yes, I will do that. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] jfclere commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1651668981 @markt-asf there is something weird while removing the war file and letting Tomcat undeploying the webapp, randomly Tomcat seems to reject the connection of the shutdown port:

[GitHub] [tomcat-maven-plugin] dependabot[bot] opened a new pull request, #40: Bump org.codehaus.plexus:plexus-archiver from 2.1.1 to 4.8.0

dependabot[bot] opened a new pull request, #40: URL: https://github.com/apache/tomcat-maven-plugin/pull/40 Bumps [org.codehaus.plexus:plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 2.1.1 to 4.8.0. Release notes Sourced from

[GitHub] [tomcat-maven-plugin] dependabot[bot] closed pull request #34: Bump plexus-archiver from 2.1.1 to 3.6.0

dependabot[bot] closed pull request #34: Bump plexus-archiver from 2.1.1 to 3.6.0 URL: https://github.com/apache/tomcat-maven-plugin/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat-maven-plugin] dependabot[bot] commented on pull request #34: Bump plexus-archiver from 2.1.1 to 3.6.0

dependabot[bot] commented on PR #34: URL: https://github.com/apache/tomcat-maven-plugin/pull/34#issuecomment-1650235866 Superseded by #40. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] aaronsatae opened a new pull request, #642: clean up code - formating

aaronsatae opened a new pull request, #642: URL: https://github.com/apache/tomcat/pull/642 reformat json util codes with [style-guide](https://github.com/apache/tomcat/blob/main/CONTRIBUTING.md#style-guide) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tomcat] jfclere commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1648253450 I need to find a way to reproduce to investigate more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] jfclere commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1648251042 Just deleted on the file system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

markt-asf commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1648200548 Just deleted on the file system or removed via the Manager app? It looks like there are sorts of race possibilities between `Host` and `HostConfig`. How far do we want to go to

[GitHub] [tomcat] markt-asf commented on pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

markt-asf commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1648116169 This doesn't seem quite right to me. If a container has been destroyed, it is not valid to call stop(). I think we need to understand how this is happening before we start looking at

[GitHub] [tomcat] jfclere opened a new pull request, #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

jfclere opened a new pull request, #641: URL: https://github.com/apache/tomcat/pull/641 I have seen: 04-Apr-2023 06:12:45.499 SEVERE [main] org.apache.catalina.core.ContainerBase.stopInternal A child container failed during stop java.util.concurrent.ExecutionException:

[GitHub] [tomcat] markt-asf merged pull request #638: Catalina [StandardSession] bug id=66680 (misleading warn about non-serializable principal)

markt-asf merged PR #638: URL: https://github.com/apache/tomcat/pull/638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat-taglibs-rdc] dependabot[bot] opened a new pull request, #2: Bump commons-beanutils:commons-beanutils from 1.8.0 to 1.9.4

dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/tomcat-taglibs-rdc/pull/2 Bumps commons-beanutils:commons-beanutils from 1.8.0 to 1.9.4. [![Dependabot compatibility

[GitHub] [tomcat] rmaucher commented on pull request #640: Catch NamingException instead of specialized sub-classes

rmaucher commented on PR #640: URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646648446 Ok, so that was a useful bug report then :) Perfect (although no backport unfortunately). -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] michael-o commented on pull request #640: Catch NamingException instead of specialized sub-classes

michael-o commented on PR #640: URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646537415 > > You should add the JBS ID. AFAIR, I have reported that back then. > > What is a JBS ID? Where did you report it when? The only two IDs I can think of are the old report in our

[GitHub] [tomcat] FSchumacher commented on pull request #640: Catch NamingException instead of specialized sub-classes

FSchumacher commented on PR #640: URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646534435 > You should add the JBS ID. AFAIR, I have reported that back then. What is a JBS ID? Where did you report it when? The only two IDs I can think of are the old report in our

[GitHub] [tomcat] rmaucher commented on pull request #640: Catch NamingException instead of specialized sub-classes

rmaucher commented on PR #640: URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646185214 +1 for the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] FSchumacher opened a new pull request, #640: Catch NamingException instead of specialized sub-classes

FSchumacher opened a new pull request, #640: URL: https://github.com/apache/tomcat/pull/640 In Java 8 and up to 17 a closed connection is signaled with a NamingException and not a CommunicationException ora ServiceUnavailableException. Such a condition should lead to re-opening the LDAP

[GitHub] [tomcat] fmarco76 commented on pull request #639: Custom ssl engine parameters

fmarco76 commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1643630772 > but it would be an incompatible API change Yes, the API would be slightly different between version 9 and 11. -- This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] rmaucher commented on pull request #639: Custom ssl engine parameters

rmaucher commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1643614685 > @rmaucher thanks for the merge. I have tested cherry-picking to tomcat 9 and it required a couple of minor fixes to work. Is there something I can do to facilitate the backport?

[GitHub] [tomcat] fmarco76 commented on pull request #639: Custom ssl engine parameters

fmarco76 commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1643609571 @rmaucher thanks for the merge. I have tested cherry-picking to tomcat 9 and it required a couple of minor fixes to work. Is there something I can do to facilitate the backport? --

[GitHub] [tomcat] rmaucher closed pull request #639: Custom ssl engine parameters

rmaucher closed pull request #639: Custom ssl engine parameters URL: https://github.com/apache/tomcat/pull/639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] rmaucher commented on pull request #639: Custom ssl engine parameters

rmaucher commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1643588616 I merged this change to Tomcat main branch (11). Backporting is not straightforward however as this is an API change stacked on top of a previous API change for Tomcat 11, so the code that

[GitHub] [tomcat] rmaucher commented on pull request #639: Custom ssl engine parameters

rmaucher commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1643431249 This proposed change looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] fmarco76 commented on pull request #639: Cusotm ssl engine parameters

fmarco76 commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1639759214 > The only thing that caught my eye was that the signature of `AbstractNetworkChannelEndpoint.createChannel` has changed by widening the return value from `NetworkChannel` to `Channel`.

[GitHub] [tomcat] ChristopherSchultz commented on pull request #639: Cusotm ssl engine parameters

ChristopherSchultz commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1638643485 This looks good to me, but I'd appreciate someone with more in-depth knowledge of the protocol handlers to weigh-in. The only thing that caught my eye was that the

[GitHub] [tomcat] fmarco76 opened a new pull request, #639: Cusotm ssl engine parameters

fmarco76 opened a new pull request, #639: URL: https://github.com/apache/tomcat/pull/639 Deploying tomcat with a custom ssl engine could require to perform some extra configuration before its usage. As an example, [tomcatjss](https://github.com/dogtagpki/tomcatjss/) project needs to

[GitHub] [tomcat] tsryo opened a new pull request, #638: Catalina [StandardSession] bug id=66680 (misleading warn about non-serializable principal)

tsryo opened a new pull request, #638: URL: https://github.com/apache/tomcat/pull/638 Misleading warning message is logged in the following scenario: - When persistAuthentication="true". When a user is logged-out of the system and redirected to the login page, they are given a session

[GitHub] [tomcat] rmannibucau commented on pull request #576: Enable to disable request/error counters and cache stats

rmannibucau commented on PR #576: URL: https://github.com/apache/tomcat/pull/576#issuecomment-1633222963 @ChristopherSchultz mainly reduce the associated overhead (cpu - cas - and mem - in no luck case multiple cells are allocated per context) since most of the time these counters are

[GitHub] [tomcat] ChristopherSchultz commented on pull request #576: Enable to disable request/error counters and cache stats

ChristopherSchultz commented on PR #576: URL: https://github.com/apache/tomcat/pull/576#issuecomment-1633181300 This seems like a lot of code to avoid two addition operations. What's the use-case, here? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] ChristopherSchultz merged pull request #635: Sync Configuration Reference with Connector's source code (8.5.x)

ChristopherSchultz merged PR #635: URL: https://github.com/apache/tomcat/pull/635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] ChristopherSchultz merged pull request #636: Sync Configuration Reference with Connector's source code (9.0.x)

ChristopherSchultz merged PR #636: URL: https://github.com/apache/tomcat/pull/636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] ChristopherSchultz merged pull request #637: Sync Configuration Reference with Connector's source code (10.1.x)

ChristopherSchultz merged PR #637: URL: https://github.com/apache/tomcat/pull/637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] perceptron8 opened a new pull request, #637: Sync Configuration Reference with Connector's source code

perceptron8 opened a new pull request, #637: URL: https://github.com/apache/tomcat/pull/637 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] perceptron8 opened a new pull request, #636: Sync Configuration Reference with Connector's source code

perceptron8 opened a new pull request, #636: URL: https://github.com/apache/tomcat/pull/636 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] perceptron8 opened a new pull request, #635: Sync Configuration Reference with Connector's source code

perceptron8 opened a new pull request, #635: URL: https://github.com/apache/tomcat/pull/635 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] DigitalFatCat opened a new pull request, #634: Bug 66684: set the revocationEnabled as FALSE when crl file is empty

DigitalFatCat opened a new pull request, #634: URL: https://github.com/apache/tomcat/pull/634 https://bz.apache.org/bugzilla/show_bug.cgi?id=66684 Recently, we tested the use of the crLFile configuration （in server.xml） in the scenario where two-way certificate authentication is

[GitHub] [tomcat] dependabot[bot] opened a new pull request, #633: Bump h2 from 2.1.210 to 2.2.220 in /modules/jdbc-pool

dependabot[bot] opened a new pull request, #633: URL: https://github.com/apache/tomcat/pull/633 Bumps [h2](https://github.com/h2database/h2database) from 2.1.210 to 2.2.220. Release notes Sourced from https://github.com/h2database/h2database/releases;>h2's releases. Version

[GitHub] [tomcat] rainerjung commented on pull request #632: Add support for CIDR notation in `RemoteIpFilter`

rainerjung commented on PR #632: URL: https://github.com/apache/tomcat/pull/632#issuecomment-1620837870 Ah, sorry I just realized what you plan. Please ignore my reference to RemoteCIDRFilter. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] rainerjung commented on pull request #632: Add support for CIDR notation in `RemoteIpFilter`

rainerjung commented on PR #632: URL: https://github.com/apache/tomcat/pull/632#issuecomment-1620836585 I have not looked at your implementation suggestion, but did you notice there is: https://tomcat.apache.org/tomcat-9.0-doc/config/filter.html#Remote_CIDR_Filter -- This is an

[GitHub] [tomcat] fabien-chebel opened a new pull request, #632: Add support for CIDR notation in `RemoteIpFilter`

fabien-chebel opened a new pull request, #632: URL: https://github.com/apache/tomcat/pull/632 # Context Tomcat's `RemoteIpFilter` currently allows configuring trusted/internal proxies using regexp. When integrating with reverse proxies with a large number of IP addresses,

[GitHub] [tomcat] michael-o closed pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o closed pull request #631: Bug 5: Provide option to supply role mapping from a properties file URL: https://github.com/apache/tomcat/pull/631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] michael-o commented on pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on PR #631: URL: https://github.com/apache/tomcat/pull/631#issuecomment-1612776954 Merged manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat-native] asfgit merged pull request #19: Bug 66666: Remove non-reachable functions from ssl.c

asfgit merged PR #19: URL: https://github.com/apache/tomcat-native/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1246201219 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] rmaucher commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

rmaucher commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1245704486 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1245695672 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] rmaucher commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

rmaucher commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1245631182 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1245197279 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] rmaucher commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

rmaucher commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1245185858 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on PR #631: URL: https://github.com/apache/tomcat/pull/631#issuecomment-1611149722 @rmaucher @markt-asf Incorporated your comments. Please have a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244995761 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] rmaucher commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

rmaucher commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244989146 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244917856 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244917856 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244891581 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244891581 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244890559 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on PR #631: URL: https://github.com/apache/tomcat/pull/631#issuecomment-1611007682 > I like the idea of exposing this feature. I'm somewhat surprised that it isn't part of the specification but, unless I am reading the XSDs incorrectly, the spec only defines

[GitHub] [tomcat] rmaucher commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

rmaucher commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244881448 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] markt-asf commented on a diff in pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

markt-asf commented on code in PR #631: URL: https://github.com/apache/tomcat/pull/631#discussion_r1244833991 ## java/org/apache/catalina/core/PropertiesRoleMappingListener.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [tomcat] michael-o commented on pull request #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o commented on PR #631: URL: https://github.com/apache/tomcat/pull/631#issuecomment-1610892466 If there are no objections, I will merge this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] michael-o opened a new pull request, #631: Bug 66665: Provide option to supply role mapping from a properties file

michael-o opened a new pull request, #631: URL: https://github.com/apache/tomcat/pull/631 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] rmannibucau opened a new pull request, #630: [WIP] initial implementation of webresource based on path API

rmannibucau opened a new pull request, #630: URL: https://github.com/apache/tomcat/pull/630 Still needs a lot of work to make it usable and easily extendable but sharing for illustration (list). -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat-native] michael-o opened a new pull request, #19: Bug 66666: Remove non-reachable functions from ssl.c

michael-o opened a new pull request, #19: URL: https://github.com/apache/tomcat-native/pull/19 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] markt-asf commented on a diff in pull request #628: Change style

markt-asf commented on code in PR #628: URL: https://github.com/apache/tomcat/pull/628#discussion_r1238933690 ## webapps/host-manager/css/manager.css: ## @@ -125,6 +132,16 @@ TD { vertical-align: middle; font-family : sans-serif, Tahoma, Arial; color :

[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style

sheikhoo commented on PR #628: URL: https://github.com/apache/tomcat/pull/628#issuecomment-1601089024 > Please provide an updated screenshot showing the results of all your changes as there have been additional changes since the PR was opened. This is screenshot of last change

[GitHub] [tomcat] markt-asf commented on pull request #629: Documentation change for Digest Authenticator Valve - spell corrected for attribute algorithm

markt-asf commented on PR #629: URL: https://github.com/apache/tomcat/pull/629#issuecomment-1600907946 Many thanks. I'll do the back-port now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] markt-asf merged pull request #629: Documentation change for Digest Authenticator Valve - spell corrected for attribute algorithm

markt-asf merged PR #629: URL: https://github.com/apache/tomcat/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] gohilmca opened a new pull request, #629: Documentation change for Digest Authenticator Valve - spell corrected for attribute algorithm

gohilmca opened a new pull request, #629: URL: https://github.com/apache/tomcat/pull/629 this change is with respect to issue #2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf commented on pull request #628: Change style

markt-asf commented on PR #628: URL: https://github.com/apache/tomcat/pull/628#issuecomment-1597337218 Please provide an updated screenshot showing the results of all your changes as there have been additional changes since the PR was opened. -- This is an automated message from the

[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style

sheikhoo commented on PR #628: URL: https://github.com/apache/tomcat/pull/628#issuecomment-1592794504 > Thanks for addressing the feedback. The remaining question is "What is the reason for these changes?" The reason behind these modifications is to enhance the visual appeal of the

[GitHub] [tomcat] markt-asf closed pull request #609: Unify Windows/Linux package filesets

markt-asf closed pull request #609: Unify Windows/Linux package filesets URL: https://github.com/apache/tomcat/pull/609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf commented on pull request #609: Unify Windows/Linux package filesets

markt-asf commented on PR #609: URL: https://github.com/apache/tomcat/pull/609#issuecomment-1592718529 The Windows specific distributions will be available in Maven Central from the July releases. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] markt-asf commented on pull request #628: Change style

markt-asf commented on PR #628: URL: https://github.com/apache/tomcat/pull/628#issuecomment-1592582873 Thanks for addressing the feedback. The remaining question is "What is the reason for these changes?" -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style

sheikhoo commented on PR #628: URL: https://github.com/apache/tomcat/pull/628#issuecomment-1590358538 I removed any unnecessary spaces and utilized 4 spaces instead of 1 tab. Additionally, I updated the style of the buttons. -- This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] markt-asf commented on pull request #625: Remove transport.bio from catalina-tribes.jar.tmp.bnd

markt-asf commented on PR #625: URL: https://github.com/apache/tomcat/pull/625#issuecomment-1589667642 Back-ported to 10.1.x as the package was removed in 10.1.x. Not back-ported further as the package is still present in 9.0.x and earlier. -- This is an automated message from the Apache

[GitHub] [tomcat] markt-asf merged pull request #625: Remove transport.bio from catalina-tribes.jar.tmp.bnd

markt-asf merged PR #625: URL: https://github.com/apache/tomcat/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf commented on pull request #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd

markt-asf commented on PR #627: URL: https://github.com/apache/tomcat/pull/627#issuecomment-1589658475 Redundant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf closed pull request #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd

markt-asf closed pull request #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd URL: https://github.com/apache/tomcat/pull/627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf closed pull request #626: Remove transport.bio from catalina-tribes.jar.tmp.bnd

markt-asf closed pull request #626: Remove transport.bio from catalina-tribes.jar.tmp.bnd URL: https://github.com/apache/tomcat/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    3   4   5   6   7   8   9   10   11   12   >