[Bug 56582] Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 --- Comment #1 from Konstantin Kolinko --- Done for Tomcat 8 (r1599385 r1599393 r1599395), will be in 8.0.9. I plan to backport this change to Tomcat 7, as I think switch() behaves better for performance. One possible error spotted thanks

[Bug 56582] Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)

2014-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 --- Comment #2 from Konstantin Kolinko --- Done for Tomcat 7 (r1599505 r1599711) and will be in 7.0.55. I am ready to close this issue, but DISPATCH_EXECUTE + AJP question for Tomcat 8 from Comment 1 is pending. -- You are receiving thi

[Bug 56582] Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)

2014-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

[Bug 56582] Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)

2014-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 --- Comment #4 from Christopher Schultz --- (In reply to Konstantin Kolinko from comment #1) > I plan to backport this change to Tomcat 7, as I think switch() behaves > better for performance. +1 A tableswitch will be faster than a series