https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #1 from Christopher Schultz ---
Sounds like a perfect opportunity for you to supply a patch (attached here) or
a pull-request via GitHub. I would support its inclusion into Tomcat.
--
You are receiving this mail because:
You are t
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #2 from ekkelenk...@gmail.com ---
Just created a pull request: https://github.com/apache/tomcat/pull/432
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #3 from Konstantin Kolinko ---
(In reply to ekkelenkamp from comment #2)
> Just created a pull request: https://github.com/apache/tomcat/pull/432
I am -0.
Wouldn't it be better to provide configuration methods for those settings (
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #4 from ekkelenk...@gmail.com ---
Indeed I would prefer if there is a configuration method available for those
settings. I just assumed the state was immutable.
The setAllowedOrigins would have to set the anyOriginAllowed variable as
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #5 from Mark Thomas ---
The initial implementation was clearly on the basis that the state was set
during init() and then never changed but if you have a requirement to change it
then I don't see a good reason not to refactor the co
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #6 from ekkelenk...@gmail.com ---
Thanks for the feedback.
The requirement is indeed to be able to configure the allowed origins at
runtime.
Should I provide a pull request for this enhancement or is this kind of
refactoring done
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #7 from ekkelenk...@gmail.com ---
Just to let you know, I found a convenient way to get the job done without
changing the code.
Simply extending the getInitParameter method, does the job. As a reference,
this is the pseudo setup of m
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #8 from Christopher Schultz ---
This violates the servlet spec, but hey if you want to do that in your code,
it's fine.
Honestly, I was hoping you'd end up writing a proper patch because I think this
is a good idea to have in the b
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #10 from ekkelenk...@gmail.com ---
Thanks for providing the change. I'll use it in my code once available in the
new releases.
--
You are receiving this mail because:
You are the assignee for the bug.
--
10 matches
Mail list logo
