[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #11 from John Engebretson --- These changes reached prod and eliminated the respective profiles. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 John Engebretson changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #9 from John Engebretson --- Regarding #1: apologies, I was able to track down an invokeinterface that confused our primary tool. Specifically, a class calling HttpServletRequest.getMethod() on an instance of

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Mark

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 John Engebretson changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from John

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #6 from John Engebretson --- Thank you for the quick turnaround! Additional data: Referring to #1: > getMethod() is already effectively cached due to use of > MessageBytes.toStringType() Our data is clear that this is

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from Mark

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #4 from Mark Thomas --- A quick update: 1. getMethod() is already effectively cached due to use of MessageBytes.toStringType() getQueryString() could be cached but there is a potential performance issue. If applications parse the

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #3 from Mark Thomas --- Thanks for the additional info. I'll try and address each part in turn. 1. Caching the key fields is low cost as it is just a reference to an existing String. I think that is a better solution that trying

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #2 from John Engebretson --- > Are you sure about the request parameters being parsed multiple times? They > should only be parsed once per request. Yes - this appears to be triggered when an extra param is added by a JSP include,

[Bug 68558] Redundant calls to ByteChunk.toString()

https://bz.apache.org/bugzilla/show_bug.cgi?id=68558 --- Comment #1 from Mark Thomas --- Are you sure about the request parameters being parsed multiple times? They should only be parsed once per request. Is org.apache.tomcat.util.buf.StringCache not caching the Strings or is just that local