[GitHub] [tomcat] ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

2019-04-10 Thread GitBox
ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850875 > I think that it'd be cleaner/more readable if `invocationSuccess` is initialized with `false` value and only set to `true

[GitHub] [tomcat] ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

2019-04-10 Thread GitBox
ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850427 The low-quality of the existing code and/or documentation is not an excuse for maintaining that level of quality.

[GitHub] [tomcat] ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

2019-04-10 Thread GitBox
ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481847793 But an explanation should be included with all PRs. What if BZ is deleted? (It shouldn't be, but there's no reason to make

[GitHub] [tomcat] ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

2019-04-10 Thread GitBox
ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481848050 Code comments would be helpful, here, too. This is an auto

[GitHub] [tomcat] ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

2019-04-10 Thread GitBox
ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481842267 No explanation? -1 This is an automated message fro