ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466235515
> Punt the session update operation to a callback or interface, have one or
two sensible defaults (like for the major databases and specific table
configuration) and have a way
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466230691
> I would love to see an interface that goes a step further and allows for
NoSQL implementations as well. For example, Redis is an excellent option for a
data store IMO.
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466223964
> I have a question that why we don't add a real **primary
key**(auto-increment) to solve the problem that primary key constraint
violation when insert data to database
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1464952161
I've been thinking about this more and I think it could cause problems for
people not using appId+sessionId (or just sessionId) as the primary key for the
DB table storing the
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1463902816
The problem is that there is a window of opportunity between the existing
`DELETE` and `INSERT` where the `session_id` column (which is `UNIQUE` or
equivalent) can be `INSERT`ed
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1462052065
> @ChristopherSchultz Is there a list of supported database systems with
which the DataSourceStore is compatible? Are you sure that they all support
"SELECT FOR UPDATE"? I tried
