[GitHub] [tomcat] markt-asf commented on pull request #612: Don't allow idle threads to live forever

2023-05-02 Thread via GitHub
markt-asf commented on PR #612: URL: https://github.com/apache/tomcat/pull/612#issuecomment-1531277972 The default `AsynchronousChannelGroup` has adopted a keep-alive of 60s at some point but since the task never exits, it makes no difference in this case. We could make the similar

[GitHub] [tomcat] markt-asf commented on pull request #612: Don't allow idle threads to live forever

2023-05-02 Thread via GitHub
markt-asf commented on PR #612: URL: https://github.com/apache/tomcat/pull/612#issuecomment-1531137327 The thread dump confirms the earlier analysis. The `sun.nio.ch.KQueuePort$EventHandlerTask` never exits so the proposed change will not have the impact desired. It would be worth

[GitHub] [tomcat] markt-asf commented on pull request #612: Don't allow idle threads to live forever

2023-04-27 Thread via GitHub
markt-asf commented on PR #612: URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525916279 A thread dump would be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] markt-asf commented on pull request #612: Don't allow idle threads to live forever

2023-04-27 Thread via GitHub
markt-asf commented on PR #612: URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525904959 My reading of the code is that the AsynchronousChannelProvider submits tasks that never end to the executor so this patch has no effect. The purpose of the Executor is to replace any