[GitHub] [tomcat] markt-asf commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1708278473 Tx for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [tomcat] markt-asf commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-05 Thread via GitHub
markt-asf commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1707256734 Saving a single function call is unlikely to make any difference. I'd expect the compiler to optimise that. Changes that reduce duplication and/or improve the readability of the code