[GitHub] [tomcat] michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

2019-08-12 Thread GitBox
michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186#issuecomment-520472525 All tests pass on Tomcat 9.0.x. This is an

[GitHub] [tomcat] michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

2019-08-12 Thread GitBox
michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186#issuecomment-520436938 @markt-asf I have now added proper tests. Please have a look. If they are as expected, I'll rebase, squash,

[GitHub] [tomcat] michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

2019-08-07 Thread GitBox
michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186#issuecomment-518968325 Tests for master and 8.5.x pass. Ready to merge. Will then backport to 7.0.x if possible.