[GitHub] [tomcat] michael-o commented on pull request #624: Add ContextNamingInfoListener

2023-06-13 Thread via GitHub
michael-o commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1588662647 > No problem. I don't really mind the default value, it could go either way. Great, if there aren't any objections I will happily merge later this day. -- This is an automated

[GitHub] [tomcat] michael-o commented on pull request #624: Add ContextNamingInfoListener

2023-06-12 Thread via GitHub
michael-o commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1587322206 @rmaucher I have now applied the default context behavior. Please have a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tomcat] michael-o commented on pull request #624: Add ContextNamingInfoListener

2023-06-09 Thread via GitHub
michael-o commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1584626395 > I think I saw this feature before in the past. No problem, although emptyOnRoot may not be very useful, so I'm not sure why this is a good idea to change things from the actual values