rmaucher commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1663624324
> Just deleted on the file system or removed via the Manager app? > > It looks like there are sorts of race possibilities between `Host` and `HostConfig`. How far do we want to go to address these? Since `HostConfig` is a `LifecycleListener` for `Host` I think all the hooks we might need are in place. > > Would it be sufficient to make `HostConfig.check()` (and `check(String)`) a NO-OP unless the associated `Host` is in state `STARTED`? There is no periodic event unless the container is available so this is "done" already to some extent. However without a sync it is not fully enforced. I think the PR at this point enforces it "more". Maybe adding synchronized to ContainerBase.backgroundProcess as general "sane behavior" ? Also HostConfig.check() and HostConfig.check(String name) should sync on the host an recheck getState().isAvailable() to cover when the call comes through the manager ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
