[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005142148 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004090783 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004090783 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004088967 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,