[GitHub] [tomcat-jakartaee-migration] ppkarwasz commented on pull request #16: Modifies TOMCAT profile

2021-03-24 Thread GitBox
ppkarwasz commented on pull request #16: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/16#issuecomment-806219210 Sorry, I didn't explain the context of this PR. I am testing the deployment of our Java EE 8 applications on Tomcat 10 using the `WebAppClassLoader` changes in

[GitHub] [tomcat-jakartaee-migration] ppkarwasz commented on pull request #16: Modifies TOMCAT profile

2021-03-25 Thread GitBox
ppkarwasz commented on pull request #16: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/16#issuecomment-806549378 @rmaucher: I fail to understand how changing the `TOMCAT` profile will cause problems for others, because I don't understand the purpose of this profile. When

[GitHub] [tomcat-jakartaee-migration] ppkarwasz commented on pull request #16: Modifies TOMCAT profile

2021-03-25 Thread GitBox
ppkarwasz commented on pull request #16: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/16#issuecomment-806658340 > I still don't understand the setup. > Since both Tomcat and the app do not provide the extra API jars how this application works/worked on Tomcat 9.x ?

[GitHub] [tomcat-jakartaee-migration] ppkarwasz commented on pull request #16: Modifies TOMCAT profile

2021-03-25 Thread GitBox
ppkarwasz commented on pull request #16: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/16#issuecomment-806715595 > > ``` > > 3\. The classloader fails to load the `jakarta.persistence.*` classes. > > ``` > > Fails how ? What is the exception ? One of the

[GitHub] [tomcat-jakartaee-migration] ppkarwasz commented on pull request #16: Modifies TOMCAT profile

2021-03-25 Thread GitBox
ppkarwasz commented on pull request #16: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/16#issuecomment-807166268 @martin-g: I am not running the migration tool and deploying the **jakartified** version. The migration tool works just fine in relocating the class files from