Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-02 Thread via GitHub
markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1790213186 No, this PR will not be applied. Applications should not be setting the Transfer-Encoding header. Or the Connection header for that matter. If you want to strongly suggest to the con

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
w1ida commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1789983590 > The description for the PR confuses request and response. It appears from the code that this PR relates to the response. > > This PR will not be applied. Whether or not to chunk the re

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1788896749 The description for the PR confuses request and response. It appears from the code that this PR relates to the response. This PR will not be applied. Whether or not to chunk the resp

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
markt-asf closed pull request #676: Fix explicit chunked encoding specification URL: https://github.com/apache/tomcat/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
w1ida opened a new pull request, #676: URL: https://github.com/apache/tomcat/pull/676 Summary: This commit fixes a bug in the code related to handling chunked transfer encoding. The original code only handled chunked transfer encoding when http11 was true, entityBody was true, and connec