Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898765701 No evidence provided to support claim of a leak. No leak observed when testing with profiler. No obvious reason that proposed patch would impact `UpgradeProcessor` instances (or anyth

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

markt-asf closed pull request #683: Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

imario42 commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898787616 @markt-asf : He described his findings in that tomcat-user post [https://lists.apache.org/thread/vyog0dyxwq3hlpjgt2vb1wkrxw6x2h1k](url) However, I do not know if his patch works.

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898853883 Thanks. The reference to the description on the users list helps. I'll look at this again. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-189414 The description of the problem and the analysis of the root cause (the BZ 66508 fix) is correct but the proposed fix is not. It will probably work the majority of the time but there is a t

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

markt-asf closed pull request #683: Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899074074 Fixed and back-ported. Will be in the February releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

imario42 commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899854047 Thanks a lot @markt-asf for tackling and fixing it and @lbliangbin for the analysis. 👍😎 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

chenbiaoit commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1923029828 > Fixed and back-ported. Will be in the February releases. Hi @markt-asf,What channel can I use to know that this problem has been fixed? Thank you very much. -- This is an

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

ChristopherSchultz commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1924044806 > > Fixed and back-ported. Will be in the February releases. > > Hi @markt-asf,What channel can I use to know that this problem has been fixed? Thank you very much. A