ChristopherSchultz commented on PR #707:
URL: https://github.com/apache/tomcat/pull/707#issuecomment-2003805644
> Ok, so add back the protected static methods in 10.1, just in case.
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message,
rmaucher commented on PR #707:
URL: https://github.com/apache/tomcat/pull/707#issuecomment-2002509259
Ok, so add back the protected static methods in 10.1, just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ChristopherSchultz commented on PR #707:
URL: https://github.com/apache/tomcat/pull/707#issuecomment-2002496427
Hmm... I've merged this PR but it occurs to me that maybe I should have
deprecated all those methods instead of removing them.
Thoughts?
--
This is an automated message
ChristopherSchultz merged PR #707:
URL: https://github.com/apache/tomcat/pull/707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ChristopherSchultz commented on code in PR #707:
URL: https://github.com/apache/tomcat/pull/707#discussion_r1527524948
##
java/org/apache/catalina/realm/JNDIRealm.java:
##
@@ -966,7 +967,7 @@ private String[] getCipherSuitesArray() {
Mark,
On 3/15/24 13:27, markt-asf (via GitHub) wrote:
markt-asf commented on code in PR #707:
URL: https://github.com/apache/tomcat/pull/707#discussion_r1526610303
##
java/org/apache/catalina/realm/JNDIRealm.java:
##
@@ -966,7 +967,7 @@ private String[] getCipherSuitesArray()
markt-asf commented on code in PR #707:
URL: https://github.com/apache/tomcat/pull/707#discussion_r1526610303
##
java/org/apache/catalina/realm/JNDIRealm.java:
##
@@ -966,7 +967,7 @@ private String[] getCipherSuitesArray() {
ChristopherSchultz opened a new pull request, #707:
URL: https://github.com/apache/tomcat/pull/707
There was repeated code in various places in the source tree to spit simple
comma-separated strings using the regular expression pattern `\s*,\s*`. This PR
gathers those together into a
