Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-07 Thread Felix Schumacher
Am 07.05.2015 um 16:32 schrieb Rémy Maucherat: 2015-05-03 12:32 GMT+02:00 Felix Schumacher < felix.schumac...@internetallee.de>: The rest of the patch will not influence the jmeter test. Ping to get feedback on the fix, if possible. Tested again on trunk and found no delays. Felix Rémy

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-07 Thread Rémy Maucherat
2015-05-03 12:32 GMT+02:00 Felix Schumacher < felix.schumac...@internetallee.de>: > The rest of the patch will not influence the jmeter test. > > Ping to get feedback on the fix, if possible. Rémy

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-05 Thread Mark Thomas
The following votes were cast: +1 (binding) : remm, markt, schultz, violetagg -1 (non-binding) : Ognjen Blagojevic The -1 vote was due to the regression of the NIO2 connector with TLS. Given the votes above, we have enough votes for the release. I intend to go ahead with the release and inc

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-05 Thread Rémy Maucherat
2015-05-05 2:32 GMT+02:00 Christopher Schultz : > Hmm... I thought that NIO2 was listed as "experimental" in Tomcat 8.0.x, > but the configuration guide doesn't say anything to that effect. > > How much *more* broken in 8.0.22 is it than 8.0.21? I would say that > failing spectacularly is better

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-05 Thread Rémy Maucherat
2015-05-04 21:58 GMT+02:00 Mark Thomas : > They are both broken, it is just more obvious with 8.0.22. I'll make my > mind up finally tomorrow but I am leaning towards releasing 8.0.22 > making it clear that there is a known issue with NIO2 + TLS and then > looking at 8.0.23 almost immediately (I w

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-04 Thread Christopher Schultz
Mark, On 5/4/15 3:58 PM, Mark Thomas wrote: > On 04/05/2015 19:49, Ognjen Blagojevic wrote: >> On 3.5.2015 19:36, Rémy Maucherat wrote: >>> 2015-05-03 18:28 GMT+02:00 Felix Schumacher < >>> felix.schumac...@internetallee.de>: >>> In my test case position() will be either 0 or 341 (complete re

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-04 Thread Mark Thomas
On 04/05/2015 19:49, Ognjen Blagojevic wrote: > On 3.5.2015 19:36, Rémy Maucherat wrote: >> 2015-05-03 18:28 GMT+02:00 Felix Schumacher < >> felix.schumac...@internetallee.de>: >> >>> In my test case position() will be either 0 or 341 (complete request). >>> They seem to happen at about the same ra

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-04 Thread Ognjen Blagojevic
On 3.5.2015 19:36, Rémy Maucherat wrote: 2015-05-03 18:28 GMT+02:00 Felix Schumacher < felix.schumac...@internetallee.de>: In my test case position() will be either 0 or 341 (complete request). They seem to happen at about the same rate. r1672626 fixed a loop issue, but oversimplified. So I am

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-04 Thread Violeta Georgieva
Hi, 2015-04-29 19:41 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 8.0.22 release is now available for voting. > > The main changes since 8.0.21 are: > - Change the format of the Tomcat specific URLs for resources inside > JARs that are in turn packed in a WAR. The ^/ sequence has been

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 Thread Rémy Maucherat
2015-05-03 18:28 GMT+02:00 Felix Schumacher < felix.schumac...@internetallee.de>: > In my test case position() will be either 0 or 341 (complete request). > They seem to happen at about the same rate. > > r1672626 fixed a loop issue, but oversimplified. So I am going back to the previous code, wit

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 Thread Felix Schumacher
Am 3. Mai 2015 16:53:55 MESZ, schrieb "Rémy Maucherat" : >2015-05-03 12:32 GMT+02:00 Felix Schumacher < >felix.schumac...@internetallee.de>: > >> The problem apears to be caused by this part of the patch: >> >> diff --git a/java/org/apache/tomcat/util/net/SecureNio2Channel.java >> b/java/org/apac

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 Thread Rémy Maucherat
2015-05-03 12:32 GMT+02:00 Felix Schumacher < felix.schumac...@internetallee.de>: > The problem apears to be caused by this part of the patch: > > diff --git a/java/org/apache/tomcat/util/net/SecureNio2Channel.java > b/java/org/apache/tomcat/util/net/SecureNio2Channel.java > index ba16492..bbc18b0

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 Thread Felix Schumacher
Am 01.05.2015 um 15:19 schrieb Mark Thomas: On 01/05/2015 14:07, Felix Schumacher wrote: Am 01.05.2015 um 14:53 schrieb Mark Thomas: On 01/05/2015 13:07, Felix Schumacher wrote: * NIO2 seems to run OK at first, but after a while (last test the "while" ended after 17900 requests) jmeters thr

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-02 Thread Christopher Schultz
Mark, On 4/29/15 12:41 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.22 release is now available for voting. > > The main changes since 8.0.21 are: > - Change the format of the Tomcat specific URLs for resources inside > JARs that are in turn packed in a WAR. The ^/ sequence has been

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-01 Thread Felix Schumacher
Am 1. Mai 2015 15:19:44 MESZ, schrieb Mark Thomas : >On 01/05/2015 14:07, Felix Schumacher wrote: >> Am 01.05.2015 um 14:53 schrieb Mark Thomas: >>> On 01/05/2015 13:07, Felix Schumacher wrote: > > > * NIO2 seems to run OK at first, but after a while (last test the "while" ended after 1

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-01 Thread Mark Thomas
On 01/05/2015 14:07, Felix Schumacher wrote: > Am 01.05.2015 um 14:53 schrieb Mark Thomas: >> On 01/05/2015 13:07, Felix Schumacher wrote: >>> * NIO2 seems to run OK at first, but after a while (last test the >>> "while" ended after 17900 requests) jmeters threads will not get a >>> response fro

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-01 Thread Felix Schumacher
Am 01.05.2015 um 14:53 schrieb Mark Thomas: On 01/05/2015 13:07, Felix Schumacher wrote: Am 01.05.2015 um 01:47 schrieb Ognjen Blagojevic: On 29.4.2015 18:41, Mark Thomas wrote: The proposed 8.0.22 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.0.22 Tested .zip

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-01 Thread Mark Thomas
On 01/05/2015 13:07, Felix Schumacher wrote: > Am 01.05.2015 um 01:47 schrieb Ognjen Blagojevic: >> On 29.4.2015 18:41, Mark Thomas wrote: >>> The proposed 8.0.22 release is: >>> [X] Broken - do not release >>> [ ] Stable - go ahead and release as 8.0.22 >> >> Tested .zip distribution on Windows 7

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-01 Thread Felix Schumacher
Am 01.05.2015 um 01:47 schrieb Ognjen Blagojevic: On 29.4.2015 18:41, Mark Thomas wrote: The proposed 8.0.22 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.0.22 Tested .zip distribution on Windows 7 64-bit, Oracle JDK 1.8.0_45 and APR/native 1.1.33: - Crawled

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-04-30 Thread Ognjen Blagojevic
On 29.4.2015 18:41, Mark Thomas wrote: The proposed 8.0.22 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.0.22 Tested .zip distribution on Windows 7 64-bit, Oracle JDK 1.8.0_45 and APR/native 1.1.33: - Crawled all links (except /manager, /host-manager and /ex

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-04-30 Thread Mark Thomas
On 29/04/2015 17:41, Mark Thomas wrote: > The proposed 8.0.22 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.0.22 Unit tests all pass for NIO, NIO2 and APR/native on OSX, Linux and Windows (all 64-bit) with latest Java 1.7 JDK. Mark --

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-04-30 Thread Rémy Maucherat
2015-04-29 18:41 GMT+02:00 Mark Thomas : > The proposed Apache Tomcat 8.0.22 release is now available for voting. > > The proposed 8.0.22 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.0.22 > > Rémy

[VOTE] Release Apache Tomcat 8.0.22

2015-04-29 Thread Mark Thomas
The proposed Apache Tomcat 8.0.22 release is now available for voting. The main changes since 8.0.21 are: - Change the format of the Tomcat specific URLs for resources inside JARs that are in turn packed in a WAR. The ^/ sequence has been replaced by */ so that the resulting URLs are compliant