Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-10 Thread Rémy Maucherat
On Tue, Oct 10, 2023 at 12:02 AM Christopher Schultz wrote: > > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat Native to 1.2.39 to pick up

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Mark Thomas
On 09/10/2023 19:01, Christopher Schultz wrote: The proposed 8.5.94 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.94 (stable) Build is reproducible. Unit tests pass on M1 MacOS, Linux and Windows. Mark

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Han Li
Christopher Schultz 于2023年10月10日周二 06:02写道： > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat Native to 1.2.39 to pick up Windows binaries

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Igal Sapir
On Mon, Oct 9, 2023 at 3:02 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > On 10/9/23 17:55, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.94 release is now available for voting. > > > > The notable changes compared to 8.5.93 are: > > > > - Update Tomcat

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Igal Sapir
Chris, On Mon, Oct 9, 2023 at 7:29 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 10/9/23 18:53, Igal Sapir wrote: > > Chris, > > > > On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > >> Igal, > >> > >> On 10/9/23

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Christopher Schultz
Igal, On 10/9/23 18:53, Igal Sapir wrote: Chris, On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz < ch...@christopherschultz.net> wrote: Igal, On 10/9/23 18:13, Igal Sapir wrote: Chris, I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - any ideas? Yes, you will

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Christopher Schultz
All, On 10/9/23 18:01, Christopher Schultz wrote: All, On 10/9/23 17:55, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.94 release is now available for voting. The notable changes compared to 8.5.93 are: - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with   

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Igal Sapir
Chris, On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 10/9/23 18:13, Igal Sapir wrote: > > Chris, > > > > I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - > > any ideas? > > Yes, you will need to set some build

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Christopher Schultz
Igal, On 10/9/23 18:13, Igal Sapir wrote: Chris, I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - any ideas? Yes, you will need to set some build properties. Have a look at this script and look ad what I do with the "opens":

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Igal Sapir
Chris, I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 - any ideas? test-nio2: [junit] Unrecognized option: --add-opens=java.base/java.lang=ALL-UNNAMED [junit] Error: Could not create the Java Virtual Machine. [junit] Error: A fatal exception has occurred.

Re: [VOTE] Release Apache Tomcat 8.5.94 [CORRECTION]

2023-10-09 Thread Christopher Schultz
All, On 10/9/23 17:55, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.94 release is now available for voting. The notable changes compared to 8.5.93 are: - Update Tomcat Native to 1.2.39 to pick up Windows binaries built with   OpenSSL 3.0.11. - Provide a lifecycle listener that