[tomcat] 02/02: Add debug log messages for the triggering of async listener events

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit bf24a9295f6b7dd5d11cc6bd5d610b2dd1b573ec
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Oct 14 16:14:52 2019 +0100

    Add debug log messages for the triggering of async listener events
---
 java/org/apache/catalina/core/AsyncContextImpl.java   | 12 ++++++++++++
 java/org/apache/catalina/core/LocalStrings.properties |  4 ++++
 2 files changed, 16 insertions(+)

diff --git a/java/org/apache/catalina/core/AsyncContextImpl.java 
b/java/org/apache/catalina/core/AsyncContextImpl.java
index 674236c..3f801d5 100644
--- a/java/org/apache/catalina/core/AsyncContextImpl.java
+++ b/java/org/apache/catalina/core/AsyncContextImpl.java
@@ -94,6 +94,9 @@ public class AsyncContextImpl implements AsyncContext, 
AsyncContextCallback {
 
     @Override
     public void fireOnComplete() {
+        if (log.isDebugEnabled()) {
+            log.debug(sm.getString("asyncContextImpl.fireOnComplete"));
+        }
         List<AsyncListenerWrapper> listenersCopy = new ArrayList<>();
         listenersCopy.addAll(listeners);
 
@@ -124,6 +127,9 @@ public class AsyncContextImpl implements AsyncContext, 
AsyncContextCallback {
         Context context = this.context;
 
         if (result.get()) {
+            if (log.isDebugEnabled()) {
+                log.debug(sm.getString("asyncContextImpl.fireOnTimeout"));
+            }
             ClassLoader oldCL = context.bind(false, null);
             try {
                 List<AsyncListenerWrapper> listenersCopy = new ArrayList<>();
@@ -327,6 +333,9 @@ public class AsyncContextImpl implements AsyncContext, 
AsyncContextCallback {
             List<AsyncListenerWrapper> listenersCopy = new ArrayList<>();
             listenersCopy.addAll(listeners);
             listeners.clear();
+            if (log.isDebugEnabled()) {
+                log.debug(sm.getString("asyncContextImpl.fireOnStartAsync"));
+            }
             for (AsyncListenerWrapper listener : listenersCopy) {
                 try {
                     listener.fireOnStartAsync(event);
@@ -401,6 +410,9 @@ public class AsyncContextImpl implements AsyncContext, 
AsyncContextCallback {
         request.getCoyoteRequest().action(ActionCode.ASYNC_ERROR, null);
 
         if (fireOnError) {
+            if (log.isDebugEnabled()) {
+                log.debug(sm.getString("asyncContextImpl.fireOnError"));
+            }
             AsyncEvent errorEvent = new AsyncEvent(event.getAsyncContext(),
                     event.getSuppliedRequest(), event.getSuppliedResponse(), 
t);
             List<AsyncListenerWrapper> listenersCopy = new ArrayList<>();
diff --git a/java/org/apache/catalina/core/LocalStrings.properties 
b/java/org/apache/catalina/core/LocalStrings.properties
index 9be2514..2b84fa8 100644
--- a/java/org/apache/catalina/core/LocalStrings.properties
+++ b/java/org/apache/catalina/core/LocalStrings.properties
@@ -95,6 +95,10 @@ aprListener.wrongFIPSMode=Unexpected value of FIPSMode 
option of AprLifecycleLis
 asyncContextImpl.asyncDispachError=Error during asynchronous dispatch
 asyncContextImpl.asyncRunnableError=Error during processing of asynchronous 
Runnable via AsyncContext.start()
 asyncContextImpl.dispatchingStarted=Asynchronous dispatch operation has 
already been called. Additional asynchronous dispatch operation within the same 
asynchronous cycle is not allowed.
+asyncContextImpl.fireOnComplete=Firing onComplete() event for any 
AsyncListeners
+asyncContextImpl.fireOnError=Firing onError() event for any AsyncListeners
+asyncContextImpl.fireOnStartAsync=Firing onStartAsync() event for any 
AsyncListeners
+asyncContextImpl.fireOnTimeout=Firing onTimeout() event for any AsyncListeners
 asyncContextImpl.noAsyncDispatcher=The dispatcher returned from the 
ServletContext does not support asynchronous dispatching
 asyncContextImpl.onCompleteError=onComplete() call failed for listener of type 
[{0}]
 asyncContextImpl.onErrorError=onError() call failed for listener of type [{0}]


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org